Re: [PR] Use group-varint encode the positions [lucene]

2024-03-16 Thread via GitHub
easyice commented on PR #12842: URL: https://github.com/apache/lucene/pull/12842#issuecomment-2002039103 Yeah, it looks like we can optimize `writeGroupVInt` in the same way as we did for the read logic. I'd love to try and run some benchmarks. -- This is an automated message from the Apa

Re: [PR] Add new parallel merge task executor for parallel actions within a single merge action [lucene]

2024-03-16 Thread via GitHub
benwtrent commented on PR #13124: URL: https://github.com/apache/lucene/pull/13124#issuecomment-2002000206 Ah, that is likely due to this change. I bet throttling is occurring but in one of the other threadpool threads. I didn't override the thread construction, so maybe that is enou

Re: [PR] Add new parallel merge task executor for parallel actions within a single merge action [lucene]

2024-03-16 Thread via GitHub
mikemccand commented on PR #13124: URL: https://github.com/apache/lucene/pull/13124#issuecomment-2001975632 This looks like a great change! ... Lucene finally catching up to modern concurrency :) I have not looked closely yet. But nightly benchy is upset, prolly related to this, when

Re: [PR] Remove the unnecessary grow calls before append. [lucene]

2024-03-16 Thread via GitHub
easyice merged PR #13168: URL: https://github.com/apache/lucene/pull/13168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa