Re: [PR] An eye-gouging way to limit suppressAccessChecks to just the three JARs that need them. [lucene]

2024-03-07 Thread via GitHub
dweiss commented on PR #13164: URL: https://github.com/apache/lucene/pull/13164#issuecomment-1985158727 I've merged this with main and I'll follow up with the remaining halt methods in a separate PR. Thanks for your help with this! -- This is an automated message from the Apache Git Servi

Re: [PR] An eye-gouging way to limit suppressAccessChecks to just the three JARs that need them. [lucene]

2024-03-07 Thread via GitHub
dweiss merged PR #13164: URL: https://github.com/apache/lucene/pull/13164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [I] Explore moving HNSW's NeighborQueue to a radix heap [LUCENE-10383] [lucene]

2024-03-07 Thread via GitHub
angadp commented on issue #11419: URL: https://github.com/apache/lucene/issues/11419#issuecomment-1985113703 Sorry for the late reply! I think my initial thinking was wrong. I'm currently implementing this and will post the code along with the benchmarks by next week. -- This is an

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-03-07 Thread via GitHub
vsop-479 commented on code in PR #13072: URL: https://github.com/apache/lucene/pull/13072#discussion_r1515861738 ## lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java: ## @@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) { } }

Re: [PR] LUCENE-4056: Japanese Tokenizer (Kuromoji) cannot build UniDic dictionary [lucene]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #12517: URL: https://github.com/apache/lucene/pull/12517#issuecomment-1984826022 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Removing thread sleep calls from TestIndexWriter.testThreadInterruptDeadlock and TestDirectoryReader.testStressTryIncRef [lucene]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #13037: URL: https://github.com/apache/lucene/pull/13037#issuecomment-1984825452 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Made DocIdsWriter use DISI when reading documents with an IntersectVisitor [lucene]

2024-03-07 Thread via GitHub
gautamworah96 commented on code in PR #13149: URL: https://github.com/apache/lucene/pull/13149#discussion_r1516771877 ## lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java: ## @@ -318,9 +378,8 @@ private static void readLegacyDeltaVInts(IndexInput in, int count,

Re: [PR] An eye-gouging way to limit suppressAccessChecks to just the three JARs that need them. [lucene]

2024-03-07 Thread via GitHub
dweiss commented on code in PR #13164: URL: https://github.com/apache/lucene/pull/13164#discussion_r1516765998 ## lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestSimpleServer.java: ## @@ -135,39 +132,12 @@ public void run() { } } - /** currently, this

Re: [PR] Made DocIdsWriter use DISI when reading documents with an IntersectVisitor [lucene]

2024-03-07 Thread via GitHub
antonha commented on code in PR #13149: URL: https://github.com/apache/lucene/pull/13149#discussion_r1516508079 ## lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java: ## @@ -36,6 +36,66 @@ final class DocIdsWriter { private final int[] scratch; + private f

Re: [PR] Fix NPE when LeafReader return null VectorValues [lucene]

2024-03-07 Thread via GitHub
benwtrent commented on code in PR #13162: URL: https://github.com/apache/lucene/pull/13162#discussion_r1516111922 ## lucene/core/src/java/org/apache/lucene/search/FloatVectorSimilarityValuesSource.java: ## @@ -40,6 +40,9 @@ public FloatVectorSimilarityValuesSource(float[] vector

Re: [PR] An eye-gouging way to limit suppressAccessChecks to just the three JARs that need them. [lucene]

2024-03-07 Thread via GitHub
rmuir commented on PR #13164: URL: https://github.com/apache/lucene/pull/13164#issuecomment-1983386271 nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] An eye-gouging way to limit suppressAccessChecks to just the three JARs that need them. [lucene]

2024-03-07 Thread via GitHub
dweiss commented on code in PR #13164: URL: https://github.com/apache/lucene/pull/13164#discussion_r1515983135 ## lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestSimpleServer.java: ## @@ -135,39 +132,12 @@ public void run() { } } - /** currently, this

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-03-07 Thread via GitHub
vsop-479 commented on PR #13072: URL: https://github.com/apache/lucene/pull/13072#issuecomment-1983159835 > Have you tried to measure any performance change with this? E.g. you could run a luceneutil benchy with just PrefixQuery, or, Regexp/WildcardQuery that also have this property (match-

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-03-07 Thread via GitHub
vsop-479 commented on code in PR #13072: URL: https://github.com/apache/lucene/pull/13072#discussion_r1515861738 ## lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java: ## @@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) { } }

Re: [I] Fix build on Apache s390x Jenkins slave [lucene]

2024-03-07 Thread via GitHub
uschindler commented on issue #13161: URL: https://github.com/apache/lucene/issues/13161#issuecomment-1983117638 I disabled both failing jobs until the INFRA ticket is resolved. Please ping me if you have updates. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Fix build on Apache s390x Jenkins slave [lucene]

2024-03-07 Thread via GitHub
Nayana-ibm commented on issue #13161: URL: https://github.com/apache/lucene/issues/13161#issuecomment-1983084035 @uschindler I have created an issue to install Java 21 on s390x nodes https://issues.apache.org/jira/browse/INFRA-25589 -- This is an automated message from the Apache Git S

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-03-07 Thread via GitHub
vsop-479 commented on code in PR #13072: URL: https://github.com/apache/lucene/pull/13072#discussion_r1515793831 ## lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java: ## @@ -67,12 +68,16 @@ protected RunAutomaton(Automaton a, int alphabetSize) { points

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-03-07 Thread via GitHub
vsop-479 commented on code in PR #13072: URL: https://github.com/apache/lucene/pull/13072#discussion_r1515793831 ## lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java: ## @@ -67,12 +68,16 @@ protected RunAutomaton(Automaton a, int alphabetSize) { points

Re: [PR] LUCENE-8739: custom codec providing Zstandard compression/decompression [lucene]

2024-03-07 Thread via GitHub
valsong commented on code in PR #439: URL: https://github.com/apache/lucene/pull/439#discussion_r1515754118 ## lucene/codecs/src/java/org/apache/lucene/codecs/customcompression/ZstdDictCompressionMode.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] LUCENE-8739: custom codec providing Zstandard compression/decompression [lucene]

2024-03-07 Thread via GitHub
valsong commented on code in PR #439: URL: https://github.com/apache/lucene/pull/439#discussion_r1515752476 ## lucene/codecs/src/java/org/apache/lucene/codecs/customcompression/ZstdDictCompressionMode.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] An eye-gouging way to limit suppressAccessChecks to just the three JARs that need them. [lucene]

2024-03-07 Thread via GitHub
uschindler commented on code in PR #13164: URL: https://github.com/apache/lucene/pull/13164#discussion_r1515751490 ## lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestSimpleServer.java: ## @@ -135,39 +132,12 @@ public void run() { } } - /** currently, t

Re: [PR] An eye-gouging way to limit suppressAccessChecks to just the three JARs that need them. [lucene]

2024-03-07 Thread via GitHub
uschindler commented on PR #13164: URL: https://github.com/apache/lucene/pull/13164#issuecomment-1982939363 Yes, the ProcessBuilder API can also kill forcibly. Nice idea. Very clean. Uwe -- This is an automated message from the Apache Git Service. To respond to the message, please l