github-actions[bot] commented on PR #13045:
URL: https://github.com/apache/lucene/pull/13045#issuecomment-1974120352
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
kevindrosendahl commented on issue #12615:
URL: https://github.com/apache/lucene/issues/12615#issuecomment-1974089752
Think I agree with your points @benwtrent, will just jot down my thinking on
HNSW vs Vamana vs DiskANN in case it's useful.
HNSW and Vamana are "competing" proximity g
Shibi-bala opened a new issue, #13151:
URL: https://github.com/apache/lucene/issues/13151
### Description
Hey,
I found what looks to be a bug here:
https://github.com/apache/lucene/blob/releases/lucene/9.9.0/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java#L1102
epotyom commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-1973648097
> [gsmiller](/gsmiller)
> @epotyom I'd be happy to do a pass on this and help get it merged if you
like. Would you mind resolving the current merge conflicts then I'll have
uschindler commented on PR #13150:
URL: https://github.com/apache/lucene/pull/13150#issuecomment-1973572849
Lucene prefers the delegation pattern. To prevent uncontrolled subclassing
most of the components in Lucene are final.
--
This is an automated message from the Apache Git Service.
T
uschindler closed pull request #13150: Make Hnsw99Codecs Extensible
URL: https://github.com/apache/lucene/pull/13150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
Shibi-bala opened a new pull request, #13150:
URL: https://github.com/apache/lucene/pull/13150
### Description
Lucene99HnswVectorsFormat and Lucene99HnswScalarQuantizedVectorsFormat are
not extensible. With the new changes to how max vector dimension is set in the
codec, users should be
msokolov commented on issue #13147:
URL: https://github.com/apache/lucene/issues/13147#issuecomment-1973428361
I have some initial implementation working in BlockDocsEnum, but one thing
I'm unsure about is whether to provide it in all of the
PostingsEnum/ImpactsEnum specializations. I feel
romseygeek commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-1973412491
The `protected` visibility on `matchQuery()` should already be fine here -
you can override or call protected methods from within subclasses. I think
making `reportError()` and `fini
uschindler commented on PR #13146:
URL: https://github.com/apache/lucene/pull/13146#issuecomment-1973230903
> I did track it down to gradle's test listeners - it looks like a bug to
me. Whatever this delegation is doing, even a simple check on whether the
target method is already accessible
dweiss commented on PR #13146:
URL: https://github.com/apache/lucene/pull/13146#issuecomment-1973141394
I did track it down to gradle's test listeners - it looks like a bug to me.
Whatever this delegation is doing, even a simple check on whether the target
method is already accessible (or e
dweiss commented on PR #13148:
URL: https://github.com/apache/lucene/pull/13148#issuecomment-1973086127
No worries at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
uschindler commented on PR #13148:
URL: https://github.com/apache/lucene/pull/13148#issuecomment-1972920800
Thanks for fixing the typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
cpoerschke commented on code in PR #99:
URL: https://github.com/apache/lucene/pull/99#discussion_r1508783653
##
lucene/monitor/src/java/org/apache/lucene/monitor/Monitor.java:
##
@@ -55,7 +53,7 @@ public class Monitor implements Closeable {
private final long commitBatchSiz
antonha opened a new pull request, #13149:
URL: https://github.com/apache/lucene/pull/13149
Instead of calling `IntersectVisitor.visit` for each doc in the
`readDelta16` and `readInts32` methods, create a `DocIdSetIterator` and call
`IntersectVisitor.visit(DocIdSetIterator)` instead.
vsop-479 commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1972857051
There is still problem in the implementation of detecting whether accept
state can match all suffix (`RunAutomaton.canMatchAllSuffix`), I am trying to
figure it out.
On the other
uschindler commented on code in PR #13146:
URL: https://github.com/apache/lucene/pull/13146#discussion_r1508734711
##
gradle/testing/randomization/policies/tests.policy:
##
@@ -50,9 +50,6 @@ grant {
permission java.lang.RuntimePermission "getStackTrace";
// needed for mock
cpoerschke commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-1972848845
Thanks @bjacobowitz for a very detailed pull request here!
I'm not really familiar with this area of the code but intuitively would be
curious what the alternative (you mentione
ChrisHegarty commented on code in PR #13146:
URL: https://github.com/apache/lucene/pull/13146#discussion_r1508716978
##
gradle/testing/randomization/policies/tests.policy:
##
@@ -50,9 +50,6 @@ grant {
permission java.lang.RuntimePermission "getStackTrace";
// needed for mo
uschindler commented on PR #13146:
URL: https://github.com/apache/lucene/pull/13146#issuecomment-1972777086
> I'm not sure how you debugged that!
I did not debug that; it was an observation and then try/error. I was a bit
annoyed yesterday so here is my observations:
- Jenkins
20 matches
Mail list logo
