Re: [I] [Suggestion] Short circuit check for queued flushes in preUpdate() when checkPendingFlushOnUpdate is disabled [lucene]

2024-02-19 Thread via GitHub
CaptainDredge commented on issue #13079: URL: https://github.com/apache/lucene/issues/13079#issuecomment-1953630719 Thanks for merging @mikemccand I've raised the PR with `changes.txt` entry here https://github.com/apache/lucene/pull/13118 -- This is an automated message from the Apach

[PR] Added queued flush check optimization to changes.txt [lucene]

2024-02-19 Thread via GitHub
CaptainDredge opened a new pull request, #13118: URL: https://github.com/apache/lucene/pull/13118 ### Description Adding changes in #13115 to `changes.txt` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1953304146 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] LUCENE-10641: IndexSearcher#setTimeout should also abort query rewrites, point ranges and vector searches [lucene]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #12345: URL: https://github.com/apache/lucene/pull/12345#issuecomment-1953304013 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] clean up smoketester GPG leaks [lucene]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #12882: URL: https://github.com/apache/lucene/pull/12882#issuecomment-1953303739 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #13072: URL: https://github.com/apache/lucene/pull/13072#issuecomment-1953303608 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] Log MockRandomMergePolicy reverse in verbose. [lucene]

2024-02-19 Thread via GitHub
mkhludnev opened a new pull request, #13117: URL: https://github.com/apache/lucene/pull/13117 ### Description #12622 introduced surprising reversing merge in tests. Let's help to notice it in verbose test mode. -- This is an automated message from the Apache Git Service. To r

Re: [I] [Suggestion] Short circuit check for queued flushes in preUpdate() when checkPendingFlushOnUpdate is disabled [lucene]

2024-02-19 Thread via GitHub
mikemccand commented on issue #13079: URL: https://github.com/apache/lucene/issues/13079#issuecomment-1952572530 > Should we add changes entry? Ahh good catch @uschindler -- @CaptainDredge do you want to draft a quick PR with the CHANGES.txt entry? Be sure to place it in the 9.11.0 s

Re: [I] [Suggestion] Short circuit check for queued flushes in preUpdate() when checkPendingFlushOnUpdate is disabled [lucene]

2024-02-19 Thread via GitHub
uschindler commented on issue #13079: URL: https://github.com/apache/lucene/issues/13079#issuecomment-1952568703 Should we add changes entry? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Short circuit queued flush check when flush on update is disabled [lucene]

2024-02-19 Thread via GitHub
uschindler commented on PR #13115: URL: https://github.com/apache/lucene/pull/13115#issuecomment-1952567658 Thanks Mike! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Suggestion] Short circuit check for queued flushes in preUpdate() when checkPendingFlushOnUpdate is disabled [lucene]

2024-02-19 Thread via GitHub
mikemccand closed issue #13079: [Suggestion] Short circuit check for queued flushes in preUpdate() when checkPendingFlushOnUpdate is disabled URL: https://github.com/apache/lucene/issues/13079 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Short circuit queued flush check when flush on update is disabled [lucene]

2024-02-19 Thread via GitHub
mikemccand merged PR #13115: URL: https://github.com/apache/lucene/pull/13115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [I] `TestIndexWriterOnDiskFull.testAddIndexOnDiskFull` reproducible test failure [lucene]

2024-02-19 Thread via GitHub
easyice commented on issue #13116: URL: https://github.com/apache/lucene/issues/13116#issuecomment-1952432719 Thanks for explaining @mikemccand , I haven't fully understand the related between this exception and 9ab84f4be262d003781910c58751a503a92f725c, I agree with you they may not have

Re: [PR] Make `static final Set` constants immutable [lucene]

2024-02-19 Thread via GitHub
uschindler commented on PR #13087: URL: https://github.com/apache/lucene/pull/13087#issuecomment-1952428804 I checked backwards compatibility: Except the scandinavian analyzer everything is tests or implementation private. I think for scandinavian normalizer we need a short note in th

Re: [I] `TestIndexWriterOnDiskFull.testAddIndexOnDiskFull` reproducible test failure [lucene]

2024-02-19 Thread via GitHub
mikemccand commented on issue #13116: URL: https://github.com/apache/lucene/issues/13116#issuecomment-1952370021 Oooh thanks for digging @easyice! Hmm, that may just be a seed-shifting change, and not e.g. bringing the root cause for this exception? I.e. https://github.com/apache/lu

Re: [I] `TestIndexWriterOnDiskFull.testAddIndexOnDiskFull` reproducible test failure [lucene]

2024-02-19 Thread via GitHub
easyice commented on issue #13116: URL: https://github.com/apache/lucene/issues/13116#issuecomment-1952334602 bisect shows it related to : 9ab84f4be262d003781910c58751a503a92f725c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Short circuit queued flush check when flush on update is disabled [lucene]

2024-02-19 Thread via GitHub
CaptainDredge commented on PR #13115: URL: https://github.com/apache/lucene/pull/13115#issuecomment-1952288372 @msfroh sorry to tag you directly but can you please take a look at this change? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Make `static final Set` constants immutable [lucene]

2024-02-19 Thread via GitHub
uschindler commented on code in PR #13087: URL: https://github.com/apache/lucene/pull/13087#discussion_r1494397690 ## lucene/CHANGES.txt: ## @@ -260,6 +260,8 @@ Improvements * GITHUB#13092: `static final Map` constants have been made immutable (Dmitry Cherniachenko) +* GIT

Re: [I] `TestIndexWriterOnDiskFull.testAddIndexOnDiskFull` reproducible test failure [lucene]

2024-02-19 Thread via GitHub
mikemccand commented on issue #13116: URL: https://github.com/apache/lucene/issues/13116#issuecomment-1952224800 This was on Java 11: ``` raptorlake:99x[branch_9_10]$ java -fullversion openjdk full version "11.0.21+9" ``` -- This is an automated message from the Apache Git

[I] `TestIndexWriterOnDiskFull.testAddIndexOnDiskFull` reproducible test failure [lucene]

2024-02-19 Thread via GitHub
mikemccand opened a new issue, #13116: URL: https://github.com/apache/lucene/issues/13116 ### Description I was smoke testing 9.10.0 and my first attempt hit this test failure, which repros on 695c0ac84508438302cd346a812cfa2fdc5a10df: ``` org.apache.lucene.index.TestIndexWri

Re: [PR] Fix too many open files Exception for some tests [lucene]

2024-02-19 Thread via GitHub
mikemccand commented on PR #13035: URL: https://github.com/apache/lucene/pull/13035#issuecomment-1952172007 Thank you @easyice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Fix too many open files Exception for some tests [lucene]

2024-02-19 Thread via GitHub
mikemccand merged PR #13035: URL: https://github.com/apache/lucene/pull/13035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Remove redundant field initializers [lucene]

2024-02-19 Thread via GitHub
stefanvodita merged PR #13060: URL: https://github.com/apache/lucene/pull/13060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen