AndreyBozhko commented on issue #13101:
URL: https://github.com/apache/lucene/issues/13101#issuecomment-1945226818
I do realize that the issue title may have sounded too prescriptive - I
certainly didn't mean that. But I would definitely like to have a discussion on
what path forward (if an
AndreyBozhko commented on issue #13101:
URL: https://github.com/apache/lucene/issues/13101#issuecomment-1945225900
Thanks for taking a look @uschindler - I have to admit that I didn't fully
grasp your comment about having a separate Lucene per core.
My original understanding was that
hossman commented on issue #13105:
URL: https://github.com/apache/lucene/issues/13105#issuecomment-1945211363
> ... as long as a new VectorEncoding method checkField(reader, fieldName)
does not throw an exception (Adding checkField directly to VectorEncoding
seemed like the most straightfor
uschindler commented on PR #13068:
URL: https://github.com/apache/lucene/pull/13068#issuecomment-1944773941
Will take care of this tomorrow. Sorry for delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
uschindler commented on PR #13068:
URL: https://github.com/apache/lucene/pull/13068#issuecomment-1944770945
Please move entry to 9.11.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
uschindler commented on issue #13101:
URL: https://github.com/apache/lucene/issues/13101#issuecomment-1944717416
This is a general problem of Service providers in Java.
As Lucene only has a single instance in the parent classloader (Lucene is
part of Solr's classloader) it only has a
uschindler closed issue #13078: No static method version() crash in android
project
URL: https://github.com/apache/lucene/issues/13078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
uschindler commented on issue #13078:
URL: https://github.com/apache/lucene/issues/13078#issuecomment-1944674586
Android is not a supported platform. The official `java.lang.Runtime` class
has a static `version()` method. So your setup does not follow the Java
specification and we won't cha
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1944599169
Sorry, I was just irritated, because the original PR was opened against
stable branch. 😜
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1944584231
@uschindler dude I need to press buttons it took me 14 mins to port I guess
that's ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on PR #13104:
URL: https://github.com/apache/lucene/pull/13104#issuecomment-1944583551
I wonder why the token stream has a setter at all. The field should be
final.
I thought we want to have those settings all final and only set on
construction.
--
This is an
s1monw closed issue #13094: Python backward compat scripts need updating
URL: https://github.com/apache/lucene/issues/13094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1944578996
This was merged to 9.x only. Should we not have it in main, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
s1monw merged PR #13095:
URL: https://github.com/apache/lucene/pull/13095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1944559092
> P.S.: I don't know if we still need those 4 special case indexes. They
seem to be a relic from earlier times. As we only check that the indexes throw
an Exception on loading, the alread
stefanvodita commented on code in PR #13060:
URL: https://github.com/apache/lucene/pull/13060#discussion_r1490019625
##
lucene/analysis/phonetic/src/java/org/apache/lucene/analysis/phonetic/DaitchMokotoffSoundexFilter.java:
##
@@ -32,10 +32,10 @@
*/
public final class DaitchM
stefanvodita commented on code in PR #13041:
URL: https://github.com/apache/lucene/pull/13041#discussion_r1489985337
##
lucene/CHANGES.txt:
##
@@ -258,6 +258,8 @@ Improvements
Tests are running with random byte order to ensure that the order does not
affect correctness
of
stefanvodita commented on code in PR #13041:
URL: https://github.com/apache/lucene/pull/13041#discussion_r1489984421
##
lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/nodes/TokenizedPhraseQueryNode.java:
##
@@ -70,10 +70,8 @@ public QueryNode cloneTree()
rmuir commented on PR #13104:
URL: https://github.com/apache/lucene/pull/13104#issuecomment-1944453765
good catch! should we move this check to `setTokenType()`? Since it is a
`public` method, it seems like a better place to add the check?
--
This is an automated message from the Apache G
hossman opened a new issue, #13105:
URL: https://github.com/apache/lucene/issues/13105
### Description
Like most field types in lucene, `Knn(Byte|Float)VectorField` classes do not
require a field value for every document -- they support use cases where some
documents are indexed w/o
easyice opened a new pull request, #13104:
URL: https://github.com/apache/lucene/pull/13104
Related to LUCENE-10353
```
./gradlew test --tests TestRandomChains.testRandomChainsWithLargeStrings
-Dtests.seed=1B915D6C476F9BFE -Dtests.nightly=true -Dtests.locale=mn
-Dtests.timezone=Canada
easyice commented on PR #13035:
URL: https://github.com/apache/lucene/pull/13035#issuecomment-1944279470
@rmuir @mikemccand Thank you for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
mayya-sharipova opened a new issue, #13103:
URL: https://github.com/apache/lucene/issues/13103
### Description
UnifiedHighlighter based on matches incorrectly returns field 'X' was
indexed without offsets, cannot highlight
Test to reproduce:
```java
static final FieldTyp
benwtrent opened a new pull request, #13102:
URL: https://github.com/apache/lucene/pull/13102
The original tests assume particular document orders & scores. To make the
test more resilient to random flushes & merges, I adjusted the assertion
conditions. Particularly, we verify matching ids
dweiss merged PR #13100:
URL: https://github.com/apache/lucene/pull/13100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
mikemccand commented on PR #13035:
URL: https://github.com/apache/lucene/pull/13035#issuecomment-1943499386
This change looks great, and it looks like @rmuir's concern was addressed.
Thank you for focusing on test reliability @easyice! I'll merge this soon if
there are no objections.
--
dweiss commented on PR #13100:
URL: https://github.com/apache/lucene/pull/13100#issuecomment-1943484848
The changes.txt entry should be consistent with what's on main (same
section).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
dweiss commented on PR #13092:
URL: https://github.com/apache/lucene/pull/13092#issuecomment-1943481155
I'll move the changes entry, my bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dweiss commented on PR #13092:
URL: https://github.com/apache/lucene/pull/13092#issuecomment-1943480107
If the backport has been done already, I think it's good to merge it in. I'm
sure something will pop up to warrant 9.11...
--
This is an automated message from the Apache Git Service.
T
uschindler commented on PR #13092:
URL: https://github.com/apache/lucene/pull/13092#issuecomment-1943350917
Hi this won't go into 9.10 because the branch is already cut and the release
started. Please move the entry to 9.11.
I don't think we will have a 9.11 release anymore, as we wan
30 matches
Mail list logo
