Re: [PR] Fix test failure for TestTopFieldCollector.testTotalHits [lucene]

2024-02-07 Thread via GitHub
easyice commented on PR #13030: URL: https://github.com/apache/lucene/pull/13030#issuecomment-1933287710 completed via https://github.com/apache/lucene/pull/13081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix test failure for TestTopFieldCollector.testTotalHits [lucene]

2024-02-07 Thread via GitHub
easyice closed pull request #13030: Fix test failure for TestTopFieldCollector.testTotalHits URL: https://github.com/apache/lucene/pull/13030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] Add necessary assertion in CheckHits#doCheckMaxScores [lucene]

2024-02-07 Thread via GitHub
easyice opened a new pull request, #13088: URL: https://github.com/apache/lucene/pull/13088 from https://github.com/apache/lucene/pull/13069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Fix NPE in TestReqOptSumScorer.testFilterRandomRareOpt [lucene]

2024-02-07 Thread via GitHub
easyice commented on PR #13069: URL: https://github.com/apache/lucene/pull/13069#issuecomment-1933281709 Nice catch! I will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Writing a HOWTO migrate codec version [lucene]

2024-02-07 Thread via GitHub
github-actions[bot] commented on PR #12930: URL: https://github.com/apache/lucene/pull/12930#issuecomment-1933151288 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Fix test failure for TestTopFieldCollector.testTotalHits [lucene]

2024-02-07 Thread via GitHub
github-actions[bot] commented on PR #13030: URL: https://github.com/apache/lucene/pull/13030#issuecomment-1933151073 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] in BytesRefHash constructor avoid duplicate BytesStartArray.bytesUsed() call [lucene]

2024-02-07 Thread via GitHub
github-actions[bot] commented on PR #13032: URL: https://github.com/apache/lucene/pull/13032#issuecomment-1933151024 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Make FSTCompiler.compile() to only return the FSTMetadata [lucene]

2024-02-07 Thread via GitHub
mikemccand commented on PR #12831: URL: https://github.com/apache/lucene/pull/12831#issuecomment-1932617133 > Thank you for merging @mikemccand ! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Fix TestTopFieldCollector.testTotalHits #13080 [lucene]

2024-02-07 Thread via GitHub
benwtrent merged PR #13081: URL: https://github.com/apache/lucene/pull/13081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [I] TestTopFieldCollector.testTotalHits test failure [lucene]

2024-02-07 Thread via GitHub
benwtrent closed issue #13080: TestTopFieldCollector.testTotalHits test failure URL: https://github.com/apache/lucene/issues/13080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] Reproducible failure in TestParentBlockJoinFloatKnnVectorQuery.testSkewedIndex [lucene]

2024-02-07 Thread via GitHub
benwtrent closed issue #13071: Reproducible failure in TestParentBlockJoinFloatKnnVectorQuery.testSkewedIndex URL: https://github.com/apache/lucene/issues/13071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Fix test failure TestParentBlockJoinFloatKnnVectorQuery.testSkewedIndex [lucene]

2024-02-07 Thread via GitHub
benwtrent merged PR #13082: URL: https://github.com/apache/lucene/pull/13082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Do not use mock merge policy for TestFuzzyQuery#testFuzziness [lucene]

2024-02-07 Thread via GitHub
jpountz merged PR #13070: URL: https://github.com/apache/lucene/pull/13070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[PR] Make `static final Set` constants immutable [lucene]

2024-02-07 Thread via GitHub
sabi0 opened a new pull request, #13087: URL: https://github.com/apache/lucene/pull/13087 For the mutable "global" Sets changed `Collections.synchronizedSet()` to `ConcurrentHashMap.newKeySet()` for better performance. -- This is an automated message from the Apache Git Service. To re

Re: [PR] Adding binary Hamming distance as similarity option for byte vectors [lucene]

2024-02-07 Thread via GitHub
ChrisHegarty commented on PR #13076: URL: https://github.com/apache/lucene/pull/13076#issuecomment-1932304149 >One difficulty is making sure the SPI interface is one we want (seems float[] & byte[] is too restrictive?). Some other work from @ChrisHegarty (https://github.com/apache/lucene/pu

Re: [PR] SOLR-13350: Multithreaded search using collector managers [lucene-solr]

2024-02-07 Thread via GitHub
chatman closed pull request #1310: SOLR-13350: Multithreaded search using collector managers URL: https://github.com/apache/lucene-solr/pull/1310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Speedup concurrent multi-segment HNWS graph search (#12962) [lucene]

2024-02-07 Thread via GitHub
mayya-sharipova merged PR #13086: URL: https://github.com/apache/lucene/pull/13086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[PR] Speedup concurrent multi-segment HNWS graph search (#12962) [lucene]

2024-02-07 Thread via GitHub
mayya-sharipova opened a new pull request, #13086: URL: https://github.com/apache/lucene/pull/13086 Speedup concurrent multi-segment HNWS graph search by exchanging the global top candidated collected so far across segments. These global top candidates set the minimum threshold that new c

Re: [PR] SOLR-13350: Multithreaded search using collector managers [lucene-solr]

2024-02-07 Thread via GitHub
cpoerschke commented on PR #1310: URL: https://github.com/apache/lucene-solr/pull/1310#issuecomment-1931990983 newer PR here: https://github.com/apache/solr/pull/2248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Avoid allocating redundant Strings [lucene]

2024-02-07 Thread via GitHub
sabi0 commented on PR #13085: URL: https://github.com/apache/lucene/pull/13085#issuecomment-1931943716 Done. I keep forgetting about this, sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Fix NPE in TestReqOptSumScorer.testFilterRandomRareOpt [lucene]

2024-02-07 Thread via GitHub
jpountz commented on PR #13069: URL: https://github.com/apache/lucene/pull/13069#issuecomment-1931937257 Hmm actually we should probably assert that s1.iterator().nextDoc() returns NO_MORE_DOCS in this `if` block, to make sure that both scorers produce the same hits? @easyice Can you open a

Re: [PR] Fix NPE in TestReqOptSumScorer.testFilterRandomRareOpt [lucene]

2024-02-07 Thread via GitHub
dweiss merged PR #13069: URL: https://github.com/apache/lucene/pull/13069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Fix NPE in TestReqOptSumScorer.testFilterRandomRareOpt [lucene]

2024-02-07 Thread via GitHub
easyice commented on PR #13069: URL: https://github.com/apache/lucene/pull/13069#issuecomment-1931685251 Thanks for reviewing! @dweiss @jpountz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Adding binary Hamming distance as similarity option for byte vectors [lucene]

2024-02-07 Thread via GitHub
pmpailis commented on code in PR #13076: URL: https://github.com/apache/lucene/pull/13076#discussion_r1481140645 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -214,4 +214,18 @@ public static float[] checkFinite(float[] v) { } return v; } + +

Re: [PR] Adding binary Hamming distance as similarity option for byte vectors [lucene]

2024-02-07 Thread via GitHub
pmpailis commented on code in PR #13076: URL: https://github.com/apache/lucene/pull/13076#discussion_r1481140645 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -214,4 +214,18 @@ public static float[] checkFinite(float[] v) { } return v; } + +