uschindler commented on PR #12873:
URL: https://github.com/apache/lucene/pull/12873#issuecomment-1837669165
Hi, I prepared a JMH benchmark and compared results. I made the "enforce MH
mode" configurable when compiling the JS expression:
```java
package org.apache.lucene.benchmark.j
uschindler commented on PR #1837:
URL: https://github.com/apache/lucene-solr/pull/1837#issuecomment-1837534748
Replaced by https://github.com/apache/lucene/pull/12873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
uschindler closed pull request #1837: LUCENE-7882: First idea of using Java 15
hidden anonymous classes for Lucene expressions
URL: https://github.com/apache/lucene-solr/pull/1837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
easyice commented on code in PR #12841:
URL: https://github.com/apache/lucene/pull/12841#discussion_r1413151301
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java:
##
@@ -212,6 +224,51 @@ public long readLong() throws IOException {
}
}
+ @Overri
uschindler commented on code in PR #12873:
URL: https://github.com/apache/lucene/pull/12873#discussion_r1413150788
##
lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java:
##
@@ -201,48 +210,75 @@ private static void unusedTestCompile() throws
IO
uschindler opened a new pull request, #12873:
URL: https://github.com/apache/lucene/pull/12873
This PR rewrites the JavascriptCompiler for the main branch to use more
modern JVM features to be easier configurable and does not need a separate
classloader per expression (uses hidden classes).
gokaai opened a new pull request, #12872:
URL: https://github.com/apache/lucene/pull/12872
### Description
Changes:
- Allow CheckIndex to exorcise an index with missing segment info (.si) file
- Unit tests for exorciseIndex()
--
This is an automated message from the A
s1monw commented on PR #12829:
URL: https://github.com/apache/lucene/pull/12829#issuecomment-1837464516
@mikemccand @jpountz I went down a hybrid way. This change now only requires
the user to specify the field name and IW adds it to the last doc in the block
if it's configured. I will for
s1monw commented on code in PR #12829:
URL: https://github.com/apache/lucene/pull/12829#discussion_r1413065291
##
lucene/core/src/java/org/apache/lucene/search/Sort.java:
##
@@ -59,10 +61,28 @@ public Sort() {
* is still a tie after all SortFields are checked, the internal L