[GitHub] [lucene] elliotzlin commented on pull request #11724: LUCENE-10520 / #11556 HTMLStripCharFilter bugfix

2023-09-23 Thread via GitHub
elliotzlin commented on PR #11724: URL: https://github.com/apache/lucene/pull/11724#issuecomment-1732391579 @dweiss @rmuir apologies for reviving this ancient thread, but I was wondering if one of you can help run the PR checks again? -- This is an automated message from the Apache Git Se

[GitHub] [lucene] stefanvodita commented on a diff in pull request #12547: Compute multiple float aggregations in one go

2023-09-23 Thread via GitHub
stefanvodita commented on code in PR #12547: URL: https://github.com/apache/lucene/pull/12547#discussion_r1335004657 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java: ## @@ -37,33 +37,43 @@ abstract class FloatTaxonomyFacets extends TaxonomyFace

[GitHub] [lucene] stefanvodita commented on pull request #12454: Clean up ordinal map in default SSDV reader state

2023-09-23 Thread via GitHub
stefanvodita commented on PR #12454: URL: https://github.com/apache/lucene/pull/12454#issuecomment-1732315340 @gmiller, I think this PR is ready. Is there anything else you'd like to see changed? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [lucene] stefanvodita opened a new issue, #12585: Is it correct for facets to assume positive aggregation values?

2023-09-23 Thread via GitHub
stefanvodita opened a new issue, #12585: URL: https://github.com/apache/lucene/issues/12585 ### Description In `IntTaxonomyFacets` and `FloatTaxonomyFacets` when we `getTopChildrenForPath` we maintain a priority queue of aggregation values and corresponding ordinals. If an aggrega