[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
shubhamvishu commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1325111790 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf c

[GitHub] [lucene] uschindler commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
uschindler commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1325097710 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf con

[GitHub] [lucene] uschindler commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
uschindler commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1325092791 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf con

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
shubhamvishu commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1325085377 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf c

[GitHub] [lucene] uschindler commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
uschindler commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1325066260 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf con

[GitHub] [lucene] uschindler commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
uschindler commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1325065806 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf con

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
shubhamvishu commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1325031509 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,4 +68,57 @@ final List invokeAll(Collection> tasks) throws IOExcept } re

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
shubhamvishu commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1325027898 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf c

[GitHub] [lucene] uschindler commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
uschindler commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1324955170 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,4 +68,57 @@ final List invokeAll(Collection> tasks) throws IOExcept } retu

[GitHub] [lucene] jmazanec15 commented on issue #12533: Init HNSW merge with graph containing deleted documents

2023-09-13 Thread via GitHub
jmazanec15 commented on issue #12533: URL: https://github.com/apache/lucene/issues/12533#issuecomment-1717981259 Additionally, the [FreshDiskANN](https://arxiv.org/pdf/2105.09613.pdf) paper did some work in this space. They ran a test for NSG where they iteratively repeat the following proc

[GitHub] [lucene] Shradha26 opened a new issue, #12553: [DISCUSS] Identifying Gaps in Lucene’s Faceting

2023-09-13 Thread via GitHub
Shradha26 opened a new issue, #12553: URL: https://github.com/apache/lucene/issues/12553 I’d like to gather a list of areas where Lucene’s support for aggregations can be improved and discuss if faceting can be augmented to offer that support or if it would need to be separate functionality

[GitHub] [lucene] javanna commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
javanna commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1324466373 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf contex

[GitHub] [lucene] jpountz commented on pull request #12489: Add support for recursive graph bisection.

2023-09-13 Thread via GitHub
jpountz commented on PR #12489: URL: https://github.com/apache/lucene/pull/12489#issuecomment-1717341776 I just found a bug that in practice only made BP run one iteration per level, fixing it makes performance better (wikibigall): ``` TaskQPS baseline

[GitHub] [lucene] uschindler commented on a diff in pull request #12183: Make TermStates#build concurrent

2023-09-13 Thread via GitHub
uschindler commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1324259855 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf con

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12183: Make some heavy query rewrites concurrent

2023-09-13 Thread via GitHub
shubhamvishu commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1324225960 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf c

[GitHub] [lucene] javanna commented on a diff in pull request #12183: Make some heavy query rewrites concurrent

2023-09-13 Thread via GitHub
javanna commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1324093739 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf contex

[GitHub] [lucene] javanna commented on a diff in pull request #12183: Make some heavy query rewrites concurrent

2023-09-13 Thread via GitHub
javanna commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1324087271 ## lucene/CHANGES.txt: ## @@ -232,11 +172,6 @@ Other * GITHUB#12410: Refactor vectorization support (split provider from implementation classes). (Uwe Schindler,

[GitHub] [lucene] javanna commented on a diff in pull request #12183: Make some heavy query rewrites concurrent

2023-09-13 Thread via GitHub
javanna commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1324085210 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf contex

[GitHub] [lucene] javanna commented on a diff in pull request #12183: Make some heavy query rewrites concurrent

2023-09-13 Thread via GitHub
javanna commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1324086202 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +93,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf contex