[GitHub] [lucene] snow-lily-warner commented on issue #11537: StackOverflow when RegExp encounters a very large string [LUCENE-10501]

2023-09-06 Thread via GitHub
snow-lily-warner commented on issue #11537: URL: https://github.com/apache/lucene/issues/11537#issuecomment-1709027590 Given that the version would include a fix that is tracked as a security vulnerability, can there be some commitment to a timeline? Or possibly cherry-pick to a minor relea

[GitHub] [lucene] jainankitk commented on issue #12527: Optimize readInts24 performance for DocIdsWriter

2023-09-06 Thread via GitHub
jainankitk commented on issue #12527: URL: https://github.com/apache/lucene/issues/12527#issuecomment-1708857931 @mikemccand - Thanks for sharing the numbers. This is truly surprising result. Even though the impact of this small change not positive, it is significant enough to explore areas

[GitHub] [lucene] Tony-X commented on issue #12536: Remove `lastPosBlockOffset` from term metadata for Lucene90PostingsFormat

2023-09-06 Thread via GitHub
Tony-X commented on issue #12536: URL: https://github.com/apache/lucene/issues/12536#issuecomment-1708839963 https://github.com/apache/lucene/pull/12541 adds more comment for `lastPosBlockOffset` -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [lucene] Tony-X opened a new pull request, #12541: Document why we need `lastPosBlockOffset`

2023-09-06 Thread via GitHub
Tony-X opened a new pull request, #12541: URL: https://github.com/apache/lucene/pull/12541 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [lucene] benwtrent commented on issue #12440: Make HNSW merges faster

2023-09-06 Thread via GitHub
benwtrent commented on issue #12440: URL: https://github.com/apache/lucene/issues/12440#issuecomment-1708370161 > For example, if we have segment 1,2,3,4 wants to merge and form a new segment, can we just leave the HNSW graphs as-is, or we only merge the smaller ones and leave the big ones

[GitHub] [lucene] cpoerschke closed issue #12538: clarify QueryVisitor.visitLeaf interaction with QueryVisitor.acceptField

2023-09-06 Thread via GitHub
cpoerschke closed issue #12538: clarify QueryVisitor.visitLeaf interaction with QueryVisitor.acceptField URL: https://github.com/apache/lucene/issues/12538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene] cpoerschke merged pull request #12540: clarify QueryVisitor.acceptField javadoc w.r.t. not being term-specific

2023-09-06 Thread via GitHub
cpoerschke merged PR #12540: URL: https://github.com/apache/lucene/pull/12540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] cpoerschke commented on pull request #12539: remove visitor.acceptField guard for visitor.visitLeaf calls

2023-09-06 Thread via GitHub
cpoerschke commented on PR #12539: URL: https://github.com/apache/lucene/pull/12539#issuecomment-1708043810 closing in favour of #12540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [lucene] cpoerschke closed pull request #12539: remove visitor.acceptField guard for visitor.visitLeaf calls

2023-09-06 Thread via GitHub
cpoerschke closed pull request #12539: remove visitor.acceptField guard for visitor.visitLeaf calls URL: https://github.com/apache/lucene/pull/12539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [lucene] cpoerschke opened a new pull request, #12540: clarify QueryVisitor.acceptField javadoc w.r.t. not being term-specific

2023-09-06 Thread via GitHub
cpoerschke opened a new pull request, #12540: URL: https://github.com/apache/lucene/pull/12540 ### Description Adjusting javadocs as suggested by @romseygeek in https://github.com/apache/lucene/issues/12538#issuecomment-1706747711 issue comment. -- This is an automated message fro

[GitHub] [lucene] jpountz closed pull request #752: LUCENE-10474: Avoid throwing StackOverflowError when creating RegExp

2023-09-06 Thread via GitHub
jpountz closed pull request #752: LUCENE-10474: Avoid throwing StackOverflowError when creating RegExp URL: https://github.com/apache/lucene/pull/752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] jpountz commented on pull request #752: LUCENE-10474: Avoid throwing StackOverflowError when creating RegExp

2023-09-06 Thread via GitHub
jpountz commented on PR #752: URL: https://github.com/apache/lucene/pull/752#issuecomment-1708013295 This was addressed in https://github.com/apache/lucene/pull/12462. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th