[GitHub] [lucene] gsmiller commented on a diff in pull request #12472: Fix UTF32toUTF8 will produce invalid transition

gsmiller commented on code in PR #12472: URL: https://github.com/apache/lucene/pull/12472#discussion_r1294103023 ## lucene/CHANGES.txt: ## @@ -182,6 +182,10 @@ Bug Fixes * GITHUB#12451: Change TestStringsToAutomaton validation to avoid automaton conversion bug discovered in GH

[GitHub] [lucene] stefanvodita commented on a diff in pull request #12506: Clean up ByteBlockPool

stefanvodita commented on code in PR #12506: URL: https://github.com/apache/lucene/pull/12506#discussion_r1293815927 ## lucene/core/src/java/org/apache/lucene/util/ByteBlockPool.java: ## @@ -129,21 +143,22 @@ public ByteBlockPool(Allocator allocator) { } /** - * Resets

[GitHub] [lucene] epotyom commented on a diff in pull request #12337: Index arbitrary fields in taxonomy docs

epotyom commented on code in PR #12337: URL: https://github.com/apache/lucene/pull/12337#discussion_r1293702812 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyIndexReader.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [lucene] benwtrent merged pull request #12504: ToParentBlockJoin[Byte|Float]KnnVectorQuery needs to handle the case when parents are missing

benwtrent merged PR #12504: URL: https://github.com/apache/lucene/pull/12504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[GitHub] [lucene] benwtrent commented on issue #12497: Add Scalar Quantization codec for Vectors

benwtrent commented on issue #12497: URL: https://github.com/apache/lucene/issues/12497#issuecomment-1677250336 > have we considered choosing an initial quantization based on the first segment seen and using that for all subsequent segments? This may not be possible. What if they flus