[GitHub] [lucene] original-brownbear commented on a diff in pull request #12453: Faster bulk numeric reads from BufferedIndexInput

2023-07-23 Thread via GitHub
original-brownbear commented on code in PR #12453: URL: https://github.com/apache/lucene/pull/12453#discussion_r1271422741 ## lucene/core/src/java/org/apache/lucene/store/BufferedIndexInput.java: ## @@ -159,6 +159,63 @@ public final long readLong() throws IOException { }

[GitHub] [lucene] original-brownbear commented on a diff in pull request #12453: Faster bulk numeric reads from BufferedIndexInput

2023-07-23 Thread via GitHub
original-brownbear commented on code in PR #12453: URL: https://github.com/apache/lucene/pull/12453#discussion_r1271422741 ## lucene/core/src/java/org/apache/lucene/store/BufferedIndexInput.java: ## @@ -159,6 +159,63 @@ public final long readLong() throws IOException { }

[GitHub] [lucene] original-brownbear opened a new pull request, #12455: Clean up writing String to ByteBuffersDataOutput

2023-07-23 Thread via GitHub
original-brownbear opened a new pull request, #12455: URL: https://github.com/apache/lucene/pull/12455 Resolving TODO to use UnicodeUtil instead of a copy of its code here. Maybe slightly slower from the extra check for high-surrogate but that may be outweigh or better by more compact code