[GitHub] [lucene] gsmiller commented on pull request #12417: forutil add vectorized and scalar code

2023-07-08 Thread via GitHub
gsmiller commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1627487242 [Disclaimer: I'm pretty new to working with the incubator vector code, so please excuse wonky terminology or silly ideas] @ChrisHegarty have you experimented at all with narrower

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12183: Make some heavy query rewrites concurrent

2023-07-08 Thread via GitHub
shubhamvishu commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1257260830 ## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ## @@ -86,19 +92,58 @@ public TermStates( * @param needsStats if {@code true} then all leaf c

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12183: Make some heavy query rewrites concurrent

2023-07-08 Thread via GitHub
shubhamvishu commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1257260811 ## lucene/core/src/java/org/apache/lucene/document/FeatureField.java: ## @@ -622,10 +623,11 @@ public static Query newSigmoidQuery( * @param featureField the

[GitHub] [lucene] almogtavor commented on issue #12406: Register nested queries (ToParentBlockJoinQuery) to Lucene Monitor

2023-07-08 Thread via GitHub
almogtavor commented on issue #12406: URL: https://github.com/apache/lucene/issues/12406#issuecomment-1627201230 @romseygeek @dweiss I'd love to get feedback from you on the subject @jpountz I saw that Elasticsearch does have the option of percolating nested queries. I wonder if its g

[GitHub] [lucene] almogtavor commented on issue #12406: Register nested queries (ToParentBlockJoinQuery) to Lucene Monitor

2023-07-08 Thread via GitHub
almogtavor commented on issue #12406: URL: https://github.com/apache/lucene/issues/12406#issuecomment-1627194434 @mikemccand maybe you've got an idea? I tried to follow the instructions that I saw in your blog and produced code as follows: ```java @Override pu

[GitHub] [lucene] uschindler commented on pull request #12417: forutil add vectorized and scalar code

2023-07-08 Thread via GitHub
uschindler commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1627011417 > Thank you, this worked. I think we can try using lucene-util to test the performance of this draft PR, as @jpountz suggested in #12396 . If we want to compare the vector and scalar

[GitHub] [lucene] jpountz closed pull request #12382: Run top-level conjunctions of term queries with a specialized BulkScorer.

2023-07-08 Thread via GitHub
jpountz closed pull request #12382: Run top-level conjunctions of term queries with a specialized BulkScorer. URL: https://github.com/apache/lucene/pull/12382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] jpountz commented on pull request #12426: Introduce VerifyingQuery

2023-07-08 Thread via GitHub
jpountz commented on PR #12426: URL: https://github.com/apache/lucene/pull/12426#issuecomment-1626920803 I'm not clear how/when it's expected to be used, is it something for the testing framework? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [lucene] tang-hi commented on pull request #12417: forutil add vectorized and scalar code

2023-07-08 Thread via GitHub
tang-hi commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1626894765 Thank you, this worked. I think we can try using lucene-util to test the performance of this draft PR, as @jpountz suggested in #12396 . If we want to compare the vector and scalar ver

[GitHub] [lucene] uschindler commented on pull request #12417: forutil add vectorized and scalar code

2023-07-08 Thread via GitHub
uschindler commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1626892057 You ran wrong task. It is called internal. 😜 Easiest to just run `gradlew :lucene:core:regenerate` -- This is an automated message from the Apache Git Service. To respond to t