[GitHub] [lucene] dweiss commented on pull request #12323: hunspell (minor): reduce allocations when reading the dictionary's morphological data

dweiss commented on PR #12323: URL: https://github.com/apache/lucene/pull/12323#issuecomment-1571452613 Hi and sorry, Peter - I was away and then ill. This looks good to me (although I really liked the stream version, it was much easier to follow). We're getting close to C here. :) -- T

[GitHub] [lucene] jmazanec15 opened a new issue, #12342: Prevent VectorSimilarity.DOT_PRODUCT from returning negative scores

jmazanec15 opened a new issue, #12342: URL: https://github.com/apache/lucene/issues/12342 Currently, [VectorSimilarityFunction.DOT_PRODUCT](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java#L54) function can return negative

[GitHub] [lucene] zhaih commented on a diff in pull request #12324: Speed up IndexedDISI Sparse #AdvanceExactWithinBlock for tiny step advance

zhaih commented on code in PR #12324: URL: https://github.com/apache/lucene/pull/12324#discussion_r1212568041 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java: ## @@ -495,6 +496,7 @@ private void readBlockHeader() throws IOException { if (numValues

[GitHub] [lucene] zhaih opened a new pull request, #12341: Add updateDocuments API which accept a query

zhaih opened a new pull request, #12341: URL: https://github.com/apache/lucene/pull/12341 ### Description Essentially just wire up `updateDocuments(Query, Iterable)` API, we could probably also add `updateDocument` for single document update, but I don't see a good reason to add

[GitHub] [lucene] zhaih commented on pull request #12322: NeighborQueue set incomplemete false when call clear

zhaih commented on PR #12322: URL: https://github.com/apache/lucene/pull/12322#issuecomment-1571257281 Oh just realized @msokolov has already made the very same change 2 weeks ago LOL https://github.com/apache/lucene/commit/6b51cce0b8404d79468dfee0c80d9992d5234960 Wonder why doesn't gi

[GitHub] [lucene] tang-hi commented on pull request #12322: NeighborQueue set incomplemete false when call clear

tang-hi commented on PR #12322: URL: https://github.com/apache/lucene/pull/12322#issuecomment-1571255082 > Ah sorry! Almost forgot this PR, I'll merge and backport it now thanks! 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene] zhaih merged pull request #12322: NeighborQueue set incomplemete false when call clear

zhaih merged PR #12322: URL: https://github.com/apache/lucene/pull/12322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[GitHub] [lucene] zhaih commented on pull request #12322: NeighborQueue set incomplemete false when call clear

zhaih commented on PR #12322: URL: https://github.com/apache/lucene/pull/12322#issuecomment-1571249189 Ah sorry! Almost forgot this PR, I'll merge and backport it now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene] gsmiller closed issue #12333: PagingFieldCollector is not able to skip documents for searchAfter value for which no competitive hits are present.

gsmiller closed issue #12333: PagingFieldCollector is not able to skip documents for searchAfter value for which no competitive hits are present. URL: https://github.com/apache/lucene/issues/12333 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene] gsmiller commented on issue #12333: PagingFieldCollector is not able to skip documents for searchAfter value for which no competitive hits are present.

gsmiller commented on issue #12333: URL: https://github.com/apache/lucene/issues/12333#issuecomment-1571058983 Thanks for the PR @gashutos! Merged and back-ported under 9.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] gsmiller merged pull request #12334: Fix searchafter query high latency when after value is out of range for segment

gsmiller merged PR #12334: URL: https://github.com/apache/lucene/pull/12334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] gsmiller commented on a diff in pull request #12334: Fix searchafter query high latency when after value is out of range for segment

gsmiller commented on code in PR #12334: URL: https://github.com/apache/lucene/pull/12334#discussion_r1212360862 ## lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java: ## @@ -204,13 +200,21 @@ private void updateCompetitiveIterator() throws IOExcep

[GitHub] [lucene] donnerpeter commented on pull request #12323: hunspell (minor): reduce allocations when reading the dictionary's morphological data

donnerpeter commented on PR #12323: URL: https://github.com/apache/lucene/pull/12323#issuecomment-1570486210 @dweiss ping? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene] tang-hi commented on pull request #12322: NeighborQueue set incomplemete false when call clear

tang-hi commented on PR #12322: URL: https://github.com/apache/lucene/pull/12322#issuecomment-1570479428 @zhaih Hi,may be we could merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [lucene] Deepika0510 commented on issue #11677: IndexSearcher#setTimeout should also abort query rewrites, point ranges and vector searches [LUCENE-10641]

Deepika0510 commented on issue #11677: URL: https://github.com/apache/lucene/issues/11677#issuecomment-1569947331 I am exploring this issue. Will try to come up with PR soon for timeout in query rewrites. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene] fudongyingluck opened a new issue, #12340: SoftDeletesRetentionMergePolicy class not final

fudongyingluck opened a new issue, #12340: URL: https://github.com/apache/lucene/issues/12340 ### Description I wonder if there are any possilbe that the class `SoftDeletesRetentionMergePolicy` can be not a final class, So that the user can do something such as cache, accroding to th

[GitHub] [lucene] gashutos commented on a diff in pull request #12334: Fix searchafter query high latency when after value is out of range for segment

gashutos commented on code in PR #12334: URL: https://github.com/apache/lucene/pull/12334#discussion_r1211208875 ## lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java: ## @@ -204,13 +200,21 @@ private void updateCompetitiveIterator() throws IOExcep