MarcusSorealheis commented on code in PR #12208:
URL: https://github.com/apache/lucene/pull/12208#discussion_r1160478745
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java:
##
@@ -842,6 +843,96 @@ public void testRewriteSimplePhrase() throws
zacharymorn commented on PR #12194:
URL: https://github.com/apache/lucene/pull/12194#issuecomment-1499988872
Thanks @mikemccand for the additional context!
> Thanks for testing this. We've debated the merits of disabling background
compilation (-Xbatch) in the past, but decided it's t
MarcusSorealheis commented on PR #12208:
URL: https://github.com/apache/lucene/pull/12208#issuecomment-1499452503
What I did to test if there was no match was hacky and basically
non-functional. Your suggestion is the right way.
--
This is an automated message from the Apache Git Service.
MarcusSorealheis commented on PR #12208:
URL: https://github.com/apache/lucene/pull/12208#issuecomment-1499406344
You're right again. Thanks for the help. The tests were the hardest part
and taught me the most.
On Thu, Apr 6, 2023 at 9:17 AM Patrick Zhai ***@***.***>
wrote:
zhaih commented on code in PR #12208:
URL: https://github.com/apache/lucene/pull/12208#discussion_r1160010214
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java:
##
@@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws Exception {
HoustonPutman commented on issue #12226:
URL: https://github.com/apache/lucene/issues/12226#issuecomment-1499125356
I created a PR for this. According to Apache policy, when a release has a
NOTICE.txt file, that file should only contain information on the
source/binaries included in that re
HoustonPutman opened a new pull request, #12227:
URL: https://github.com/apache/lucene/pull/12227
Resolves #12226
- Ant is no longer used as the build system for Lucene (Some classes are
used in gradle tasks, but I'm not sure it needs to be called out still)
- JUnit is not package
mikemccand opened a new issue, #12226:
URL: https://github.com/apache/lucene/issues/12226
### Description
Spinoff from [this discussion on
java-user](https://lists.apache.org/thread/zg01tkq8wtmym27q3dolcg1msbtoxoxl):
There is confusion about why our `NOTICE.txt` for some module
mikemccand commented on issue #12224:
URL: https://github.com/apache/lucene/issues/12224#issuecomment-1498801223
I like this term "forever home"! It is like a forever memory.
Though, it may not live here forever? Healthy code is still alive and
twitching... maybe just its next / bet
mikemccand commented on PR #12194:
URL: https://github.com/apache/lucene/pull/12194#issuecomment-1498797871
> PKLookup seems varies a lot as well when there are no changes.
I wonder if `luceneutil` maybe has a bug where `PKLookup` task is not using
the specified random seed to derive
MarcusSorealheis commented on code in PR #12208:
URL: https://github.com/apache/lucene/pull/12208#discussion_r1159444007
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java:
##
@@ -842,6 +843,92 @@ public void testRewriteSimplePhrase() throws
MarcusSorealheis commented on code in PR #12208:
URL: https://github.com/apache/lucene/pull/12208#discussion_r1159415882
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java:
##
@@ -842,6 +843,92 @@ public void testRewriteSimplePhrase() throws
MarcusSorealheis commented on code in PR #12208:
URL: https://github.com/apache/lucene/pull/12208#discussion_r1159363981
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java:
##
@@ -842,6 +843,92 @@ public void testRewriteSimplePhrase() throws
13 matches
Mail list logo
