[GitHub] [lucene] MarcusSorealheis commented on pull request #12208: Explain term automaton queries

MarcusSorealheis commented on PR #12208: URL: https://github.com/apache/lucene/pull/12208#issuecomment-1475118236 > For the test question, usually we use QueryUtils which should exercise and test the explanations. https://github.com/apache/lucene/blob/0782535017c9e737350e96fb0f53457c7b8ecf0

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1141264483 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -38,23 +38,8 @@ import org.apache.lucene.index.LeafReaderConte

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1141049657 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -38,23 +38,8 @@ import org.apache.lucene.index.LeafReaderConte

[GitHub] [lucene] rmuir commented on pull request #12208: Explain term automaton queries

rmuir commented on PR #12208: URL: https://github.com/apache/lucene/pull/12208#issuecomment-1474819042 For the test question, usually we use QueryUtils which should exercise and test the explanations. https://github.com/apache/lucene/blob/0782535017c9e737350e96fb0f53457c7b8ecf03/lucene/test

[GitHub] [lucene] mkhludnev commented on a diff in pull request #12208: Explain term automaton queries

mkhludnev commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1140972961 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -38,23 +38,8 @@ import org.apache.lucene.index.LeafReaderContext; im

[GitHub] [lucene] jpountz commented on pull request #12205: Remove remaining sources of contention on indexing.

jpountz commented on PR #12205: URL: https://github.com/apache/lucene/pull/12205#issuecomment-1474759453 The test failure looks interesting, pasting here for reference: ``` org.apache.lucene.sandbox.codecs.idversion.TestIDVersionPostingsFormat > testGlobalVersions FAILED jav