[GitHub] [lucene] zacharymorn commented on issue #11428: Handle soft deletes via LiveDocsFormat [LUCENE-10392]

2023-01-24 Thread via GitHub
zacharymorn commented on issue #11428: URL: https://github.com/apache/lucene/issues/11428#issuecomment-1403063251 Hi @jpountz @dnhatn, I have been looking at this issue and studying the code for soft delete, and have some general understanding of the complexity of this issue. If I understan

[GitHub] [lucene] javanna commented on issue #11212: Remove VectorValues#binaryValue? [LUCENE-10175]

2023-01-24 Thread via GitHub
javanna commented on issue #11212: URL: https://github.com/apache/lucene/issues/11212#issuecomment-1402791699 Done in #12101 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [lucene] javanna closed issue #11212: Remove VectorValues#binaryValue? [LUCENE-10175]

2023-01-24 Thread via GitHub
javanna closed issue #11212: Remove VectorValues#binaryValue? [LUCENE-10175] URL: https://github.com/apache/lucene/issues/11212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene] javanna closed issue #11963: Improve vector quantization API

2023-01-24 Thread via GitHub
javanna closed issue #11963: Improve vector quantization API URL: https://github.com/apache/lucene/issues/11963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] javanna opened a new pull request, #12111: SimpleText codec to support writing byte vectors

2023-01-24 Thread via GitHub
javanna opened a new pull request, #12111: URL: https://github.com/apache/lucene/pull/12111 A recent test failure signaled that when the simple text codec was randomly selected, byte vectors could not be written. This commit addressed that by adding support for writing byte vectors to Simpl

[GitHub] [lucene] benwtrent opened a new pull request, #12110: Fix flaky TestHnswByteVectorGraph.testSortedAndUnsortedIndicesReturnSameResults test

2023-01-24 Thread via GitHub
benwtrent opened a new pull request, #12110: URL: https://github.com/apache/lucene/pull/12110 Every once in a while, this test has a document with a duplicate score in the `n+1` position given the `TopDocs` size of `n`. This verifies the test is valid if the `ids` are not equal by ch

[GitHub] [lucene] jpountz commented on issue #11963: Improve vector quantization API

2023-01-24 Thread via GitHub
jpountz commented on issue #11963: URL: https://github.com/apache/lucene/issues/11963#issuecomment-1402147042 +1 to close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] javanna commented on issue #11963: Improve vector quantization API

2023-01-24 Thread via GitHub
javanna commented on issue #11963: URL: https://github.com/apache/lucene/issues/11963#issuecomment-1402141048 #12105 and #12107 should complete the improvements that the description of this issue mentioned. I am leaning towards closing this if there are no objections. -- This is an autom

[GitHub] [lucene] javanna merged pull request #12107: Remove deprecated float vector classes and methods

2023-01-24 Thread via GitHub
javanna merged PR #12107: URL: https://github.com/apache/lucene/pull/12107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz merged pull request #12109: MemoryIndex should not fail integer fields that enable doc values.

2023-01-24 Thread via GitHub
jpountz merged PR #12109: URL: https://github.com/apache/lucene/pull/12109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz commented on pull request #12109: MemoryIndex should not fail integer fields that enable doc values.

2023-01-24 Thread via GitHub
jpountz commented on PR #12109: URL: https://github.com/apache/lucene/pull/12109#issuecomment-1401717980 Thanks @romseygeek ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene] jpountz commented on a diff in pull request #12109: MemoryIndex should not fail integer fields that enable doc values.

2023-01-24 Thread via GitHub
jpountz commented on code in PR #12109: URL: https://github.com/apache/lucene/pull/12109#discussion_r1085101798 ## lucene/memory/src/test/org/apache/lucene/index/memory/TestMemoryIndex.java: ## @@ -793,4 +793,42 @@ private static boolean arrayBinaryContains(BytesRef[] array, By

[GitHub] [lucene] romseygeek commented on a diff in pull request #12109: MemoryIndex should not fail integer fields that enable doc values.

2023-01-24 Thread via GitHub
romseygeek commented on code in PR #12109: URL: https://github.com/apache/lucene/pull/12109#discussion_r1085097916 ## lucene/memory/src/test/org/apache/lucene/index/memory/TestMemoryIndex.java: ## @@ -793,4 +793,42 @@ private static boolean arrayBinaryContains(BytesRef[] array,

[GitHub] [lucene] javanna merged pull request #12108: Update references to deprecated vector classes in comments and javadocs

2023-01-24 Thread via GitHub
javanna merged PR #12108: URL: https://github.com/apache/lucene/pull/12108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz opened a new pull request, #12109: MemoryIndex should not fail integer fields that enable doc values.

2023-01-24 Thread via GitHub
jpountz opened a new pull request, #12109: URL: https://github.com/apache/lucene/pull/12109 When a field indexes numeric doc values, `MemoryIndex` does an unchecked cast to `java.lang.Long`. However, the new `IntField` represents the value as a `java.lang.Integer` so this cast fails. This c

[GitHub] [lucene] javanna opened a new pull request, #12108: Update references to deprecated vector classes in comments and javadocs

2023-01-24 Thread via GitHub
javanna opened a new pull request, #12108: URL: https://github.com/apache/lucene/pull/12108 Follow-up of https://github.com/apache/lucene/pull/12105 to update references to the deprecated classes in comments and javadocs -- This is an automated message from the Apache Git Service. To resp

[GitHub] [lucene] javanna opened a new pull request, #12107: Remove deprecated float vector classes and methods

2023-01-24 Thread via GitHub
javanna opened a new pull request, #12107: URL: https://github.com/apache/lucene/pull/12107 Follow-up of #12105 to remove the deprecated classes on main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene] javanna merged pull request #12106: Rename vector float classes and methods (#12105)

2023-01-24 Thread via GitHub
javanna merged PR #12106: URL: https://github.com/apache/lucene/pull/12106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] javanna opened a new pull request, #12106: Rename vector float classes and methods (#12105)

2023-01-24 Thread via GitHub
javanna opened a new pull request, #12106: URL: https://github.com/apache/lucene/pull/12106 We recently introduced KnnByteVectorField, KnnByteVectorQuery and ByteVectorValues. The corresponding float variants of the same classes don't follow the same naming convention: KnnVectorField, KnnVe

[GitHub] [lucene] javanna merged pull request #12105: Rename vector float classes and methods

2023-01-24 Thread via GitHub
javanna merged PR #12105: URL: https://github.com/apache/lucene/pull/12105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz commented on a diff in pull request #12105: Rename vector float classes and methods

2023-01-24 Thread via GitHub
jpountz commented on code in PR #12105: URL: https://github.com/apache/lucene/pull/12105#discussion_r1084959329 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -48,8 +50,20 @@ protected KnnVectorsReader() {} * Returns the {@link VectorValues} fo