zhaih merged PR #11815:
URL: https://github.com/apache/lucene/pull/11815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
donnerpeter commented on PR #11960:
URL: https://github.com/apache/lucene/pull/11960#issuecomment-1323247726
Aha! What do you think should be added there? I'd expect the APIs to stay
the same, maybe with more of them available in 10.
--
This is an automated message from the Apache Git Ser
jpountz commented on PR #11947:
URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323233839
No worries at all @dweiss, thanks a lot for modernizing Maven staging
upload, it's a relief we no longer have a dependency on a 8.x build!
--
This is an automated message from the Apac
dweiss commented on PR #11947:
URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323217423
Hi @jpountz . Sorry about this - I'm not sure what happened there but the
relative upload path of those artifacts was indeed wrong (and I'm also not sure
why nexus isn't complaining about
dweiss commented on PR #11947:
URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323185638
Give me a sec. you're getting a different output than I do then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
jpountz commented on PR #11947:
URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323185011
This is the folder I ran it against. I used the same folder that the release
wizard recommended using with the Ant build.
--
This is an automated message from the Apache Git Service.
T
dweiss commented on PR #11947:
URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323178110
The script should be pointed at the maven folder, including parent
subfolders, as in:
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.4.0-RC2-rev-0384b4fcad7856ddc574c8b994c
elliotzlin commented on PR #11724:
URL: https://github.com/apache/lucene/pull/11724#issuecomment-1323161181
@dweiss @rmuir bumping this old thread again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dweiss commented on PR #11947:
URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323158142
I think I know what the problem is, but would like a confirmation from you
first - let me know what you pointed the script at (which directory).
--
This is an automated message from the
dweiss commented on PR #11947:
URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323156175
@jpountz What did you point the script at, exactly? I'll look into it - drop
the staging repo, please.
--
This is an automated message from the Apache Git Service.
To respond to the me
dweiss commented on PR #11960:
URL: https://github.com/apache/lucene/pull/11960#issuecomment-1323154169
Sorry - typed from memory, here it is:
https://github.com/apache/lucene/blob/main/lucene/MIGRATE.md
--
This is an automated message from the Apache Git Service.
To respond to the mess
donnerpeter commented on PR #11960:
URL: https://github.com/apache/lucene/pull/11960#issuecomment-1322653084
What's migration.txt? I see no such file in the repository :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jpountz commented on PR #11947:
URL: https://github.com/apache/lucene/pull/11947#issuecomment-1322642852
@dweiss Your new script put all files at the top level, which seems to make
the release step not work. I did a release several hours ago and 9.4.2 still
doesn't appear on Maven Central w
dweiss commented on code in PR #11958:
URL: https://github.com/apache/lucene/pull/11958#discussion_r1028411698
##
lucene/core/src/java/org/apache/lucene/store/FilterIndexOutput.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
shubhamvishu commented on code in PR #11950:
URL: https://github.com/apache/lucene/pull/11950#discussion_r1028378099
##
lucene/core/src/java/org/apache/lucene/document/BinaryRangeFieldRangeQuery.java:
##
@@ -91,7 +92,11 @@ public Query rewrite(IndexSearcher indexSearcher) throws
shubhamvishu commented on code in PR #11950:
URL: https://github.com/apache/lucene/pull/11950#discussion_r1028378099
##
lucene/core/src/java/org/apache/lucene/document/BinaryRangeFieldRangeQuery.java:
##
@@ -91,7 +92,11 @@ public Query rewrite(IndexSearcher indexSearcher) throws
shubhamvishu commented on code in PR #11950:
URL: https://github.com/apache/lucene/pull/11950#discussion_r1028376885
##
lucene/core/src/test/org/apache/lucene/search/TestRangeFieldsDocValuesQuery.java:
##
@@ -226,4 +228,30 @@ public void testToString() {
Query q4 = LongRang
mdmarshmallow commented on code in PR #11958:
URL: https://github.com/apache/lucene/pull/11958#discussion_r1028358333
##
lucene/core/src/java/org/apache/lucene/store/FilterIndexOutput.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
mdmarshmallow commented on issue #11868:
URL: https://github.com/apache/lucene/issues/11868#issuecomment-1322431148
Here's the PR: https://github.com/apache/lucene/pull/11958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dweiss closed issue #11957: false warning around 'gitStatus' on newish macos X
URL: https://github.com/apache/lucene/issues/11957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dweiss merged PR #11959:
URL: https://github.com/apache/lucene/pull/11959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1322354312
Sorry for the delay - thanks for testing, Robert. The reason jgit does this
is, I believe, to extract user-specific git options so that jgit and git behave
the same (for example per-
dweiss commented on PR #11960:
URL: https://github.com/apache/lucene/pull/11960#issuecomment-1322351054
No, absolutely - I think these changes are great and everyone on 9x would
benefit from them. We should probably add a note to migration.txt but otherwise
I'm more than fine for everything
gsmiller commented on PR #11901:
URL: https://github.com/apache/lucene/pull/11901#issuecomment-1322333279
> Ah yeah good point on the FacetSets... so I actually already use
LongRangeDocValueFields here: public class LongRangeDocValuesFacetField extends
LongRangeDocValuesField. The differenc
benwtrent commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1028208385
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsFormat.java:
##
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
benwtrent commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1028205980
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsFormat.java:
##
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
benwtrent commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1028205264
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsFormat.java:
##
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
rmuir commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1028082967
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/ExpandingVectorValues.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Fou
rmuir commented on PR #11955:
URL: https://github.com/apache/lucene/pull/11955#issuecomment-1322116142
There's just nothing we can do to workaround such bugs effectively.
Applications are better positioned to implement workarounds. We are just
another library. I'd recommend opening an issue
jpountz commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1028076412
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/ExpandingVectorValues.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software F
kotman12 commented on PR #11955:
URL: https://github.com/apache/lucene/pull/11955#issuecomment-1322109984
> > Thanks for the clarification, that does make things simpler to analyze.
I still think there is a race condition between parallel calls to
`FilterFactory:create` mainly because of un
rmuir commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1028073537
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/ExpandingVectorValues.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Fou
rmuir commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1028071843
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/ExpandingVectorValues.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Fou
uschindler commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1322106594
> It is different if there is a real risk to some user.
Let me try to trick jenkins to print /etc/passwd when checking out something
with jgit.
--
This is an automated m
rmuir commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1322103222
i know, but i hate how "security" gets abused for purposes like that.
It is different if there is a real risk to some user.
--
This is an automated message from the Apache Git
rmuir commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1028070021
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/ExpandingVectorValues.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Fou
rmuir commented on PR #11955:
URL: https://github.com/apache/lucene/pull/11955#issuecomment-1322098085
> Thanks for the clarification, that does make things simpler to analyze. I
still think there is a race condition between parallel calls to
`FilterFactory:create` mainly because of unsynch
uschindler commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1322097248
I was not against fixing it here. But as a good open source citizen we
should at least report this. If we declare it as security issue (e.g., it could
affect Jenkin's git plugin
benwtrent commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1028062221
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/ExpandingVectorValues.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software
kotman12 commented on PR #11955:
URL: https://github.com/apache/lucene/pull/11955#issuecomment-1322093451
> > > Does this library also check for race conditions that can arise
between ResourceLoaderAware::inform vs TokenStream creation and processing? I
know it may be out of the scope of th
rmuir commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1322092882
i'll help dawid and fix the unix side by setting the env var. we can clear
it up right now, we don't need to push this to our downstream users.
as far as upstream, no need to w
uschindler commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1322084003
But without that export and the env var, this oculd still be a security
issue, as Dawid showed. I just think this should be fixed downstream and it
should not fork processes by d
rmuir commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1322079238
well for us there is no concern of anything, we don't need to suck in any
fancy git configuration for the minimal way we use this jgit (simply checking
the status)
--
This is an au
uschindler commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1322059176
Hi,
> Yeah... it's absolutely terrible that jgit blindly forks git off the path.
I just made the Lucene build open a file editor by renaming it to git.exe...
I think
rmuir commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1322043978
we should `export` on its own line, if thats how other env vars are working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
donnerpeter commented on PR #11960:
URL: https://github.com/apache/lucene/pull/11960#issuecomment-1322018484
@dweiss I've scheduled them for 10 for now, thanks! Actually, if there
happens to be a new major release from the 9x branch, I'd like to backport all
recent Hunspell changes there. D
uschindler commented on PR #11955:
URL: https://github.com/apache/lucene/pull/11955#issuecomment-1321850829
> > Does this library also check for race conditions that can arise between
ResourceLoaderAware::inform vs TokenStream creation and processing? I know it
may be out of the scope of th
dweiss commented on PR #11960:
URL: https://github.com/apache/lucene/pull/11960#issuecomment-1321846471
Pater, would you mark the milestone these changes go into? If they're not
going to be backported to 9x, then only main (10.0.0) would be the right one to
select.
--
This is an automate
romseygeek merged PR #11941:
URL: https://github.com/apache/lucene/pull/11941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
romseygeek closed issue #11864: ArrayIndexOutOfBoundException
URL: https://github.com/apache/lucene/issues/11864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
stefanvodita commented on code in PR #11815:
URL: https://github.com/apache/lucene/pull/11815#discussion_r1027768094
##
lucene/misc/src/java/org/apache/lucene/misc/index/BinaryDocValueSelector.java:
##
@@ -30,52 +31,94 @@
import org.apache.lucene.store.Directory;
import org.ap
dweiss commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1321715665
Windows part at: #11959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dweiss commented on issue #11957:
URL: https://github.com/apache/lucene/issues/11957#issuecomment-1321712405
Should we do:
```
GIT_CONFIG_NOSYSTEM=1 exec "$JAVACMD" "$@"
```
or a separate set/export above?
I am a bit concerned by the amount of customizations that go into th
53 matches
Mail list logo
