[GitHub] [lucene] dweiss commented on a diff in pull request #11893: hunspell: allow for faster dictionary iteration during 'suggest' by using more memory (opt-in)

dweiss commented on code in PR #11893: URL: https://github.com/apache/lucene/pull/11893#discussion_r1014272956 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Suggester.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] gsmiller commented on a diff in pull request #11881: Further optimize DrillSideways scoring

gsmiller commented on code in PR #11881: URL: https://github.com/apache/lucene/pull/11881#discussion_r1014106369 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java: ## @@ -166,89 +160,158 @@ public int score(LeafCollector collector, Bits acceptDocs, int m

[GitHub] [lucene] gsmiller commented on a diff in pull request #11881: Further optimize DrillSideways scoring

gsmiller commented on code in PR #11881: URL: https://github.com/apache/lucene/pull/11881#discussion_r1014106369 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java: ## @@ -166,89 +160,158 @@ public int score(LeafCollector collector, Bits acceptDocs, int m

[GitHub] [lucene] msokolov closed issue #11896: TestLucene91HnswVectorsFormat reproducible failure

msokolov closed issue #11896: TestLucene91HnswVectorsFormat reproducible failure URL: https://github.com/apache/lucene/issues/11896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [lucene] msokolov commented on issue #11896: TestLucene91HnswVectorsFormat reproducible failure

msokolov commented on issue #11896: URL: https://github.com/apache/lucene/issues/11896#issuecomment-1303544526 should be fixed; feel free to re-open if you see it happen again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [lucene] msokolov merged pull request #11899: #11896: reduce top k in test to avoid split-graph

msokolov merged PR #11899: URL: https://github.com/apache/lucene/pull/11899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] donnerpeter commented on a diff in pull request #11893: hunspell: allow for faster dictionary iteration during 'suggest' by using more memory (opt-in)

donnerpeter commented on code in PR #11893: URL: https://github.com/apache/lucene/pull/11893#discussion_r1013968050 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Suggester.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [lucene] dweiss commented on a diff in pull request #11893: hunspell: allow for faster dictionary iteration during 'suggest' by using more memory (opt-in)

dweiss commented on code in PR #11893: URL: https://github.com/apache/lucene/pull/11893#discussion_r1013880109 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Suggester.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] donnerpeter commented on pull request #11893: hunspell: allow for faster dictionary iteration during 'suggest' by using more memory (opt-in)

donnerpeter commented on PR #11893: URL: https://github.com/apache/lucene/pull/11893#issuecomment-1303240921 I've realized that the entry cache should have a longer lifetime than `checkCanceled`, so I moved the suggester stuff into a separate class (where I also plan to add more optimizatio

[GitHub] [lucene] A-U commented on pull request #816: LUCENE-10519: Improvement for CloseableThreadLocal

A-U commented on PR #816: URL: https://github.com/apache/lucene/pull/816#issuecomment-1303067203 I tried to replace the `ThreadLocal` in `SolrQueryTimeoutImpl` with this new `CloseableThreadLocal`, some of the test cases were timeout when reading the DocValues. It still happened when switch

[GitHub] [lucene] zhaih commented on a diff in pull request #11881: Further optimize DrillSideways scoring

zhaih commented on code in PR #11881: URL: https://github.com/apache/lucene/pull/11881#discussion_r1013684022 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java: ## @@ -166,89 +160,158 @@ public int score(LeafCollector collector, Bits acceptDocs, int min,