[GitHub] [lucene] zhaih commented on pull request #11780: GH#11601: Add ability to compute reader states after refresh

zhaih commented on PR #11780: URL: https://github.com/apache/lucene/pull/11780#issuecomment-1257538633 How is it different from making a subclass/alternative of ReaderManager and just put the state calculation inside `refreshIfNeed`? -- This is an automated message from the Apache Git Ser

[GitHub] [lucene] zhaih commented on a diff in pull request #11815: Support deletions in rearrange (#11814)

zhaih commented on code in PR #11815: URL: https://github.com/apache/lucene/pull/11815#discussion_r979581760 ## lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java: ## @@ -175,5 +202,7 @@ public CacheHelper getReaderCacheHelper() { /** Select document withi

[GitHub] [lucene] caohassl commented on issue #11805: Add a InterruptedCollector to received thread interrupt request and exit search task early

caohassl commented on issue #11805: URL: https://github.com/apache/lucene/issues/11805#issuecomment-1257428712 hi, @uschindler @rmuir Thank you for reply Yes, we use the MMapDirectory implementation mainly, and Interrupted collect seems to work fine so far. I‘m sorry for not

[GitHub] [lucene] elliotzlin commented on pull request #11724: LUCENE-10520 / #11556 HTMLStripCharFilter bugfix

elliotzlin commented on PR #11724: URL: https://github.com/apache/lucene/pull/11724#issuecomment-1257315679 @dweiss can you help run the workflows again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] joshsouza commented on pull request #2671: Add sts support

joshsouza commented on PR #2671: URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1257263376 Thank you so much! On Sun, Sep 25, 2022, 1:32 PM Kevin Risden ***@***.***> wrote: > Thanks @joshsouza - I updated the branch > you push

[GitHub] [lucene-solr] risdenk commented on pull request #2671: Add sts support

risdenk commented on PR #2671: URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1257263160 Thanks @joshsouza - I updated the branch you pushed to be based off of branch_8_11, add license and notice files, and add changes.txt. This just kicked off precommit as well. -- Th

[GitHub] [lucene] dweiss merged pull request #11817: Regenerate sources after dependency updates.

dweiss merged PR #11817: URL: https://github.com/apache/lucene/pull/11817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] dweiss commented on pull request #11817: Regenerate sources after dependency updates.

dweiss commented on PR #11817: URL: https://github.com/apache/lucene/pull/11817#issuecomment-1257224319 I allow myself to merge this in without a review since it's an automatic update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] dweiss merged pull request #11816: Dependency upgrades and regenerate (9x backport)

dweiss merged PR #11816: URL: https://github.com/apache/lucene/pull/11816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] dweiss commented on pull request #11816: Dependency upgrades and regenerate (9x backport)

dweiss commented on PR #11816: URL: https://github.com/apache/lucene/pull/11816#issuecomment-1257223431 I allow myself to merge this in without a review since it's an automatic update. Thanks to @rmuir for reminding me about the need for it. I'll have to think how to make this need more evi

[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.

dweiss commented on PR #11812: URL: https://github.com/apache/lucene/pull/11812#issuecomment-1257217466 Sorry, I was wrong about javacc and possibly other tasks - I'll do a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] uschindler closed issue #11805: Add a InterruptedCollector to received thread interrupt request and exit search task early

uschindler closed issue #11805: Add a InterruptedCollector to received thread interrupt request and exit search task early URL: https://github.com/apache/lucene/issues/11805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene] uschindler commented on issue #11805: Add a InterruptedCollector to received thread interrupt request and exit search task early

uschindler commented on issue #11805: URL: https://github.com/apache/lucene/issues/11805#issuecomment-1257217007 This won't work when the thread is blocked on I/O (e.g. when it reads from IndexInput). Java has the behaviour to close file handles for safety when a thread doing IO was interru

[GitHub] [lucene] uschindler closed pull request #11806: GITHUB#11805: Add a InterruptedCollector to received thread interrupt request and exit search task early

uschindler closed pull request #11806: GITHUB#11805: Add a InterruptedCollector to received thread interrupt request and exit search task early URL: https://github.com/apache/lucene/pull/11806 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [lucene] uschindler commented on pull request #11806: GITHUB#11728: Add a InterruptedCollector to received thread interrupt request and exit search task early

uschindler commented on PR #11806: URL: https://github.com/apache/lucene/pull/11806#issuecomment-1257216396 This won't work when the thread is blocked on I/O (e.g. when it reads from IndexInput). Java has the behaviour to close file handles for safety when a thread doing IO was interrupted.

[GitHub] [lucene] dweiss merged pull request #11812: Upgrade several build dependencies.

dweiss merged PR #11812: URL: https://github.com/apache/lucene/pull/11812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.

dweiss commented on PR #11812: URL: https://github.com/apache/lucene/pull/11812#issuecomment-1257215252 I re-ran javacc and the generated files just seem to be identical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.

dweiss commented on PR #11812: URL: https://github.com/apache/lucene/pull/11812#issuecomment-1257214001 > oh, one question @dweiss, since javacc is upgraded, should we force a gradlew regenerate? Hmmm.. isn't javacc part of the checksum? It should regenerate itself when javacc is upg