[GitHub] [lucene] limingnihao commented on pull request #1050: LUCENE-10663: KnnVectorQuery explain incorrect when multiple segments

2022-07-27 Thread GitBox
limingnihao commented on PR #1050: URL: https://github.com/apache/lucene/pull/1050#issuecomment-1197663762 @jtibshirani I have added the CHANGES.txt entry for this change in the Bug Fixes section for the 9.3.0. Please help to review it. Thanks. -- This is an automated message from the Ap

[GitHub] [lucene] limingnihao closed pull request #1050: LUCENE-10663: KnnVectorQuery explain incorrect when multiple segments

2022-07-27 Thread GitBox
limingnihao closed pull request #1050: LUCENE-10663: KnnVectorQuery explain incorrect when multiple segments URL: https://github.com/apache/lucene/pull/1050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-10216) Add concurrency to addIndexes(CodecReader…) API

2022-07-27 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572164#comment-17572164 ] Vigya Sharma commented on LUCENE-10216: --- Raised a PR for backporting changes to 9

[GitHub] [lucene] vigyasharma opened a new pull request, #1051: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-07-27 Thread GitBox
vigyasharma opened a new pull request, #1051: URL: https://github.com/apache/lucene/pull/1051 Backport the following changes to branch 9x - 1. Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges. (#633) 2. LUCENE-10648: Fix failures in TestAssertingPointsForma

[jira] [Commented] (LUCENE-10658) Merges should periodically check for abort

2022-07-27 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572161#comment-17572161 ] Vigya Sharma commented on LUCENE-10658: --- How about interrupting the merge threads

Re: [jira] [Commented] (LUCENE-10054) Handle hierarchy in HNSW graph

2022-07-27 Thread David Smiley
FYI I had filed https://issues.apache.org/jira/browse/INFRA-23503 ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Tue, Jul 26, 2022 at 3:54 PM Michael Sokolov wrote: > searching JIRA for "slkjfdf" I found a few issues in other projects, > but none

[jira] [Commented] (LUCENE-10664) SearcherManager should return new IndexSearchers every time

2022-07-27 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572105#comment-17572105 ] Michael McCandless commented on LUCENE-10664: - Hmm, {{SearcherLifetimeManag

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #83: tweak legacy-jira-label texts

2022-07-27 Thread GitBox
mikemccand commented on PR #83: URL: https://github.com/apache/lucene-jira-archive/pull/83#issuecomment-1197284122 > I decided to take this approach. #84. > There are about 20 issues with such error-causing labels. It'd be possible to manually recover these labels afterward. +1

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #84: Skip errorcausing labels

2022-07-27 Thread GitBox
mikemccand commented on PR #84: URL: https://github.com/apache/lucene-jira-archive/pull/84#issuecomment-1197283074 Good grief that is so strange that GitHub import API blocks these specific labels!? Thanks @mocobeta. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

2022-07-27 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572080#comment-17572080 ] Julie Tibshirani commented on LUCENE-10404: --- Checking I understand the number

[jira] [Commented] (LUCENE-8810) Flattening of nested disjunctions does not take into account number of clause limitation of builder

2022-07-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572021#comment-17572021 ] Adrien Grand commented on LUCENE-8810: -- Indeed this change no longer makes sense on

[GitHub] [lucene] jpountz commented on pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-27 Thread GitBox
jpountz commented on PR #1017: URL: https://github.com/apache/lucene/pull/1017#issuecomment-1196903627 I chatted a bit with @iverase (we work together at Elastic) about this change. Like Ignacio wrote, we are interested in it since it maps to similar functionality that we have in Elasticsea

[GitHub] [lucene-jira-archive] mocobeta commented on issue #1: Fix markup conversion error

2022-07-27 Thread GitBox
mocobeta commented on issue #1: URL: https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1196840911 Problems were fixed in #82 and #84. I restarted the rehearsal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (LUCENE-10661) Reduce memory copy in BytesStore

2022-07-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571971#comment-17571971 ] Adrien Grand commented on LUCENE-10661: --- Thank you [~luyuncheng]! > Reduce memor

[jira] [Commented] (LUCENE-10661) Reduce memory copy in BytesStore

2022-07-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571961#comment-17571961 ] ASF subversion and git services commented on LUCENE-10661: -- Co

[GitHub] [lucene-jira-archive] mocobeta merged pull request #84: Skip errorcausing labels

2022-07-27 Thread GitBox
mocobeta merged PR #84: URL: https://github.com/apache/lucene-jira-archive/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[jira] [Commented] (LUCENE-10661) Reduce memory copy in BytesStore

2022-07-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571960#comment-17571960 ] ASF subversion and git services commented on LUCENE-10661: -- Co

[jira] [Commented] (LUCENE-10661) Reduce memory copy in BytesStore

2022-07-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571959#comment-17571959 ] ASF subversion and git services commented on LUCENE-10661: -- Co

[jira] [Resolved] (LUCENE-10661) Reduce memory copy in BytesStore

2022-07-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10661. --- Fix Version/s: 9.4 Resolution: Fixed > Reduce memory copy in BytesStore > --

[GitHub] [lucene-jira-archive] mocobeta closed pull request #83: tweak legacy-jira-label texts

2022-07-27 Thread GitBox
mocobeta closed pull request #83: tweak legacy-jira-label texts URL: https://github.com/apache/lucene-jira-archive/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #83: tweak legacy-jira-label texts

2022-07-27 Thread GitBox
mocobeta commented on PR #83: URL: https://github.com/apache/lucene-jira-archive/pull/83#issuecomment-1196823563 > Or... we can just skip these labels with a warning message, then manually attach them after migration from GitHub web GUI. I decided to take this approach. #84. There

[jira] [Commented] (LUCENE-10661) Reduce memory copy in BytesStore

2022-07-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571958#comment-17571958 ] ASF subversion and git services commented on LUCENE-10661: -- Co

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #84: Skip errorcausing labels

2022-07-27 Thread GitBox
mocobeta opened a new pull request, #84: URL: https://github.com/apache/lucene-jira-archive/pull/84 An alternative for #83. I don't have an idea about the cause but GitHub won't accept some label texts via import API. Example logs of the converter script with this change. ```

[GitHub] [lucene] jpountz merged pull request #1047: LUCENE-10661: Reduce memory copy in BytesStore

2022-07-27 Thread GitBox
jpountz merged PR #1047: URL: https://github.com/apache/lucene/pull/1047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[GitHub] [lucene] jpountz commented on a diff in pull request #1047: LUCENE-10661: Reduce memory copy in BytesStore

2022-07-27 Thread GitBox
jpountz commented on code in PR #1047: URL: https://github.com/apache/lucene/pull/1047#discussion_r931121046 ## lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java: ## @@ -179,6 +179,30 @@ void writeBytes(long dest, byte[] b, int offset, int len) { } } + @

[jira] [Commented] (LUCENE-10664) SearcherManager should return new IndexSearchers every time

2022-07-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571935#comment-17571935 ] Adrien Grand commented on LUCENE-10664: --- Or maybe we should just deprecate/remove

[jira] [Created] (LUCENE-10664) SearcherManager should return new IndexSearchers every time

2022-07-27 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10664: - Summary: SearcherManager should return new IndexSearchers every time Key: LUCENE-10664 URL: https://issues.apache.org/jira/browse/LUCENE-10664 Project: Lucene - Cor

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #83: tweak legacy-jira-label texts

2022-07-27 Thread GitBox
mocobeta commented on PR #83: URL: https://github.com/apache/lucene-jira-archive/pull/83#issuecomment-1196723212 Or... we can just skip these labels with a warning message, then manually attach them after migration from GitHub web GUI. -- This is an automated message from the Apache Git

[jira] [Commented] (LUCENE-8810) Flattening of nested disjunctions does not take into account number of clause limitation of builder

2022-07-27 Thread Wads (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571861#comment-17571861 ] Wads commented on LUCENE-8810: -- What is the state of this? 8.11.2 has a way to flattening v

[GitHub] [lucene] shaie commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-27 Thread GitBox
shaie commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r930947493 ## lucene/CHANGES.txt: ## @@ -39,6 +39,8 @@ New Features * LUCENE-10626 Hunspell: add tools to aid dictionary editing: analysis introspection, stem expansion and stem/f

[GitHub] [lucene] limingnihao opened a new pull request, #1050: LUCENE-10663: KnnVectorQuery explain incorrect when multiple segments

2022-07-27 Thread GitBox
limingnihao opened a new pull request, #1050: URL: https://github.com/apache/lucene/pull/1050 ### Description (or a Jira issue link if you have one) [LUCENE-10663](https://issues.apache.org/jira/browse/LUCENE-10663) If there are multiple segments. KnnVectorQuery explain has a bu

[GitHub] [lucene] shaie commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-27 Thread GitBox
shaie commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r930938148 ## lucene/facet/src/java/org/apache/lucene/facet/FacetCountsWithFilterQuery.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene] shaie commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-27 Thread GitBox
shaie commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r930937074 ## lucene/facet/src/java/org/apache/lucene/facet/FacetCountsWithFilterQuery.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Created] (LUCENE-10663) KnnVectorQuery explain incorrect when multiple segments

2022-07-27 Thread shiming.li (Jira)
shiming.li created LUCENE-10663: --- Summary: KnnVectorQuery explain incorrect when multiple segments Key: LUCENE-10663 URL: https://issues.apache.org/jira/browse/LUCENE-10663 Project: Lucene - Core

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #75: Update account-map.csv.20220722.verified

2022-07-27 Thread GitBox
mocobeta commented on PR #75: URL: https://github.com/apache/lucene-jira-archive/pull/75#issuecomment-1196552168 Agreed, `manish1982` also should be added. https://github.com/apache/lucene-jira-archive/commit/cdd8bceea44913bcdc47495e338916794473881d -- This is an automated message fro

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #83: tweak legacy-jira-label texts

2022-07-27 Thread GitBox
mocobeta commented on PR #83: URL: https://github.com/apache/lucene-jira-archive/pull/83#issuecomment-1196546487 @mikemccand I have no idea why but it seems we cannot preserve all jira labels as-is. Would the tweaks be okay? -- This is an automated message from the Apache Git Service. T

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #83: tweak legacy-jira-label texts

2022-07-27 Thread GitBox
mocobeta opened a new pull request, #83: URL: https://github.com/apache/lucene-jira-archive/pull/83 I really don't have idea but GitHub won't accept some label texts via import API. e.g. ``` [2022-07-26 10:06:40,904] ERROR:import_github_issues: Import GitHub issue /mnt/hdd/repo

[GitHub] [lucene] luyuncheng commented on pull request #1047: LUCENE-10661: Reduce memory copy in BytesStore

2022-07-27 Thread GitBox
luyuncheng commented on PR #1047: URL: https://github.com/apache/lucene/pull/1047#issuecomment-1196542776 > Since you are optimizing this call, can you remove the `DataInput` and `numBytes` parameters from the `BytesStore` constructor, and fix call sites to call `BytesStore#copyBytes` inste

[GitHub] [lucene] luyuncheng commented on a diff in pull request #1047: LUCENE-10661: Reduce memory copy in BytesStore

2022-07-27 Thread GitBox
luyuncheng commented on code in PR #1047: URL: https://github.com/apache/lucene/pull/1047#discussion_r930884228 ## lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java: ## @@ -179,6 +179,30 @@ void writeBytes(long dest, byte[] b, int offset, int len) { } } +

[jira] [Updated] (LUCENE-10583) Deadlock with MMapDirectory while waitForMerges

2022-07-27 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-10583: Fix Version/s: 9.4 (was: 9.3) > Deadlock with MMapDirector

[jira] [Resolved] (LUCENE-10583) Deadlock with MMapDirectory while waitForMerges

2022-07-27 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-10583. - Fix Version/s: 10.0 (main) 9.3 Resolution: Fixed > De

[jira] [Commented] (LUCENE-10583) Deadlock with MMapDirectory while waitForMerges

2022-07-27 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571822#comment-17571822 ] Michael McCandless commented on LUCENE-10583: - bq. We could assert that com

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #75: Update account-map.csv.20220722.verified

2022-07-27 Thread GitBox
mikemccand commented on PR #75: URL: https://github.com/apache/lucene-jira-archive/pull/75#issuecomment-1196496660 In general, we could/should just add both Jira accounts (mapping to the same GitHub account), right? We can dedup the user on import? In this case it does not matter so

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #82: Avoid duplicate labels

2022-07-27 Thread GitBox
mikemccand commented on PR #82: URL: https://github.com/apache/lucene-jira-archive/pull/82#issuecomment-1196490153 LOL! That error message was because of duplicate labels!? Maybe open an issue on GitHub about itself somewhere ;) Thank you for tracking it down @mocobeta. -- This

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #82: Avoid duplicate labels

2022-07-27 Thread GitBox
mikemccand commented on PR #82: URL: https://github.com/apache/lucene-jira-archive/pull/82#issuecomment-1196490547 It's also sort of interesting that Jira doesn't mind having duplicate labels! -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene-jira-archive] mocobeta merged pull request #82: Avoid duplicate labels

2022-07-27 Thread GitBox
mocobeta merged PR #82: URL: https://github.com/apache/lucene-jira-archive/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #82: Avoid duplicate labels

2022-07-27 Thread GitBox
mocobeta opened a new pull request, #82: URL: https://github.com/apache/lucene-jira-archive/pull/82 If there are duplicate labels, the GitHub import request fails. This is the (not very informative) error message. ``` [2022-07-26 04:15:07,711] ERROR:import_github_issues: Import G

[jira] [Commented] (LUCENE-10633) Dynamic pruning for queries sorted by SORTED(_SET) field

2022-07-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571807#comment-17571807 ] Adrien Grand commented on LUCENE-10633: --- The PR is ready for review now if someon

[GitHub] [lucene-jira-archive] mocobeta merged pull request #75: Update account-map.csv.20220722.verified

2022-07-27 Thread GitBox
mocobeta merged PR #75: URL: https://github.com/apache/lucene-jira-archive/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #75: Update account-map.csv.20220722.verified

2022-07-27 Thread GitBox
mocobeta commented on code in PR #75: URL: https://github.com/apache/lucene-jira-archive/pull/75#discussion_r930707143 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -169,3 +169,4 @@ mharwood,markharwood,Mark Harwood hossman,hossman,Chris M. Hostetter mune

[GitHub] [lucene-jira-archive] manishbafna commented on a diff in pull request #75: Update account-map.csv.20220722.verified

2022-07-27 Thread GitBox
manishbafna commented on code in PR #75: URL: https://github.com/apache/lucene-jira-archive/pull/75#discussion_r930701655 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -169,3 +169,4 @@ mharwood,markharwood,Mark Harwood hossman,hossman,Chris M. Hostetter m

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #75: Update account-map.csv.20220722.verified

2022-07-27 Thread GitBox
mocobeta commented on code in PR #75: URL: https://github.com/apache/lucene-jira-archive/pull/75#discussion_r930697825 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -169,3 +169,4 @@ mharwood,markharwood,Mark Harwood hossman,hossman,Chris M. Hostetter mune

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #75: Update account-map.csv.20220722.verified

2022-07-27 Thread GitBox
mocobeta commented on code in PR #75: URL: https://github.com/apache/lucene-jira-archive/pull/75#discussion_r930697825 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -169,3 +169,4 @@ mharwood,markharwood,Mark Harwood hossman,hossman,Chris M. Hostetter mune

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #75: Update account-map.csv.20220722.verified

2022-07-27 Thread GitBox
mocobeta commented on code in PR #75: URL: https://github.com/apache/lucene-jira-archive/pull/75#discussion_r930697825 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -169,3 +169,4 @@ mharwood,markharwood,Mark Harwood hossman,hossman,Chris M. Hostetter mune

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #75: Update account-map.csv.20220722.verified

2022-07-27 Thread GitBox
mocobeta commented on code in PR #75: URL: https://github.com/apache/lucene-jira-archive/pull/75#discussion_r930697825 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -169,3 +169,4 @@ mharwood,markharwood,Mark Harwood hossman,hossman,Chris M. Hostetter mune