[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-21 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r927333254 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-21 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r927333254 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [lucene-jira-archive] mocobeta commented on issue #63: Jira username mentions are not converted?

2022-07-21 Thread GitBox
mocobeta commented on issue #63: URL: https://github.com/apache/lucene-jira-archive/issues/63#issuecomment-1192179474 I recognize this issue. I think It'd be great if we can handle `[~user]` as well as `@user`. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene-jira-archive] mocobeta commented on issue #61: Should we carry over Jira "labels"?

2022-07-21 Thread GitBox
mocobeta commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1192175427 It was an intentional omission by me. Personally, I don't think we should bloat issue labels in GitHub... should we port all Jira "Labels" to GitHub labels? -- This is a

[GitHub] [lucene-jira-archive] mocobeta commented on issue #59: Module label is sometimes missing?

2022-07-21 Thread GitBox
mocobeta commented on issue #59: URL: https://github.com/apache/lucene-jira-archive/issues/59#issuecomment-1192173312 This is a bug (typo) in the label mapping; I'll fix this. https://github.com/apache/lucene-jira-archive/blob/75e70ce3abad1b070a44a0b75e0df96afd3eae65/migration/src/common

[GitHub] [lucene-jira-archive] mocobeta commented on issue #58: Errors setting assignee when running `import_github_issues.py`

2022-07-21 Thread GitBox
mocobeta commented on issue #58: URL: https://github.com/apache/lucene-jira-archive/issues/58#issuecomment-1192171388 You cannot assign accounts that have no push access to the repository. This is the reason I invited you to my test repository in #8. -- This is an automated message fr

[GitHub] [lucene] wuwm opened a new pull request, #1042: Cache decoded length bytes for TFIDFSimilarity scorer.

2022-07-21 Thread GitBox
wuwm opened a new pull request, #1042: URL: https://github.com/apache/lucene/pull/1042 ### Description When doing A/B testing between TF-IDF and BM25 similarity, we found scorer() method in TFIDFSimilarity is somewhat slower than that in BM25Similarity. After reading the code and pro

[GitHub] [lucene-jira-archive] mocobeta commented on issue #53: Remove "module" for core components?

2022-07-21 Thread GitBox
mocobeta commented on issue #53: URL: https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1192109634 Yes, I think so. I'm closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-jira-archive] mocobeta closed issue #53: Remove "module" for core components?

2022-07-21 Thread GitBox
mocobeta closed issue #53: Remove "module" for core components? URL: https://github.com/apache/lucene-jira-archive/issues/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #63: Jira username mentions are not converted?

2022-07-21 Thread GitBox
mikemccand opened a new issue, #63: URL: https://github.com/apache/lucene-jira-archive/issues/63 I noticed [this comment](https://github.com/mikemccand/stargazers-migration-test/issues/213#issuecomment-1192043461) is calling Jira user `[~ben.manes]`. Should we replace it with the presenta

[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #62: Missing closing paren in conversion

2022-07-21 Thread GitBox
mikemccand opened a new issue, #62: URL: https://github.com/apache/lucene-jira-archive/issues/62 I noticed that [this comment](https://github.com/mikemccand/stargazers-migration-test/issues/213#issuecomment-1192043447) is missing the closing paren after the link to GitHub PR, but in the [c

[GitHub] [lucene-jira-archive] mikemccand merged pull request #57: Enable hyperlinks to a commit in commitbots' comments

2022-07-21 Thread GitBox
mikemccand merged PR #57: URL: https://github.com/apache/lucene-jira-archive/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] mikemccand closed issue #54: Hyperlinks are sometimes not actual links on import

2022-07-21 Thread GitBox
mikemccand closed issue #54: Hyperlinks are sometimes not actual links on import URL: https://github.com/apache/lucene-jira-archive/issues/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #61: Should we carry over Jira "labels"?

2022-07-21 Thread GitBox
mikemccand opened a new issue, #61: URL: https://github.com/apache/lucene-jira-archive/issues/61 Some Jira issues have labels, like [this one](https://issues.apache.org/jira/browse/LUCENE-8213) with `labels: performance`. But when we don't seem to carry over the label to the [GitHub issue

[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #60: Invalid unicode character in conversion of comment

2022-07-21 Thread GitBox
mikemccand opened a new issue, #60: URL: https://github.com/apache/lucene-jira-archive/issues/60 Spot checking a few converted issues, I noticed the invalid Unicode character, I think (U+FFDD) in [this comment](https://github.com/mikemccand/stargazers-migration-test/issues/329#issuecomment-

[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #59: Module label is sometimes missing?

2022-07-21 Thread GitBox
mikemccand opened a new issue, #59: URL: https://github.com/apache/lucene-jira-archive/issues/59 I am test importing all Jira issues from 8000 to 9000, and spot checking. I noticed [this issue](https://github.com/mikemccand/stargazers-migration-test/issues/161), which in Jira is unde

[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #58: Errors setting assignee when running `import_github_issues.py`

2022-07-21 Thread GitBox
mikemccand opened a new issue, #58: URL: https://github.com/apache/lucene-jira-archive/issues/58 Is this expected? Am I doing something wrong in running the tool? ``` > python3 src/import_github_issues.py --min 8000 -max 9000 [2022-07-21 19:38:46,024] WARNING:github_issues_util:

[GitHub] [lucene-jira-archive] mikemccand commented on issue #53: Remove "module" for core components?

2022-07-21 Thread GitBox
mikemccand commented on issue #53: URL: https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1192045923 Can this be closed now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-21 Thread GitBox
nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r926982395 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [lucene] JoeHF commented on pull request #1003: LUCENE-10616: optimizing decompress when only retrieving some fields

2022-07-21 Thread GitBox
JoeHF commented on PR #1003: URL: https://github.com/apache/lucene/pull/1003#issuecomment-1191678569 https://github.com/apache/lucene/pull/1003/commits/4b9086fc1bbb31f0ca36986f3adaa770665215e1 found alternatives that we can skip non needed compressed bytes by reading compressed length. Thi

[GitHub] [lucene] JoeHF commented on a diff in pull request #1003: LUCENE-10616: optimizing decompress when only retrieving some fields

2022-07-21 Thread GitBox
JoeHF commented on code in PR #1003: URL: https://github.com/apache/lucene/pull/1003#discussion_r926864645 ## lucene/core/src/java/org/apache/lucene/document/DocumentStoredFieldVisitor.java: ## @@ -98,6 +100,16 @@ public void doubleField(FieldInfo fieldInfo, double value) {

[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-21 Thread GitBox
nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r926815794 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-21 Thread GitBox
nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r926815794 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Resolved] (LUCENE-10659) Fix random TestDisiPriorityQueue bug

2022-07-21 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10659. -- Fix Version/s: 9.3 Resolution: Fixed > Fix random TestDisiPriorityQueue bug >

[GitHub] [lucene] gsmiller merged pull request #1038: Fix TestDisiPriorityQueue test bug

2022-07-21 Thread GitBox
gsmiller merged PR #1038: URL: https://github.com/apache/lucene/pull/1038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[jira] [Commented] (LUCENE-10655) can we optimize visited bitset usage in HNSW graph search/indexing?

2022-07-21 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569457#comment-17569457 ] Michael Sokolov commented on LUCENE-10655: -- Ah, I see - I hadn't followed your

[jira] [Resolved] (LUCENE-10655) can we optimize visited bitset usage in HNSW graph search/indexing?

2022-07-21 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov resolved LUCENE-10655. -- Resolution: Fixed > can we optimize visited bitset usage in HNSW graph search/indexin

[jira] [Commented] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

2022-07-21 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569429#comment-17569429 ] Michael Sokolov commented on LUCENE-10404: -- I tried using IntIntHashMap (mappi

[jira] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

2022-07-21 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10404 ] Michael Sokolov deleted comment on LUCENE-10404: -- was (Author: sokolov): I tried using IntIntHashMap (mapping to 1 for visited nodes) and indeed does seem to be a small speedup. I have

[jira] [Comment Edited] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

2022-07-21 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569420#comment-17569420 ] Michael Sokolov edited comment on LUCENE-10404 at 7/21/22 1:39 PM: --

[jira] [Commented] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

2022-07-21 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569420#comment-17569420 ] Michael Sokolov commented on LUCENE-10404: -- I tried using IntIntHashMap (mappi

[GitHub] [lucene] mayya-sharipova commented on pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-21 Thread GitBox
mayya-sharipova commented on PR #992: URL: https://github.com/apache/lucene/pull/992#issuecomment-1191496667 @jpountz @jtibshirani Thanks for your review. It looks like we are removing Lucene93Hnsw* codecs in the `main` and `branch_9_3` branches. So once this removal is done, my plan

[GitHub] [lucene] mayya-sharipova commented on pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-21 Thread GitBox
mayya-sharipova commented on PR #992: URL: https://github.com/apache/lucene/pull/992#issuecomment-1191493127 @jtibshirani Thanks for the review. > It's a bit confusing that the baseline slows down so much from 533s to 654s, which is almost 2 minutes slower. Do you have a sense for wh

[jira] [Resolved] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-21 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Meisels resolved LUCENE-10650. - Resolution: Done > "after_effect": "no" was removed what replaces it? > ---

[jira] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-21 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650 ] Nathan Meisels deleted comment on LUCENE-10650: - was (Author: JIRAUSER292626): Hi [~jpountz]! Appreciate your help until now! Another question. I did a reindex and I get different scor

[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #57: Enable hyperlinks to a commit in commitbots' comments

2022-07-21 Thread GitBox
mikemccand commented on code in PR #57: URL: https://github.com/apache/lucene-jira-archive/pull/57#discussion_r926614459 ## migration/src/jira2github_import.py: ## @@ -123,6 +123,17 @@ def comment_author(author_name, author_dispname): author_gh = account_map.get(aut

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #57: Enable hyperlinks to a commit in commitbots' comments

2022-07-21 Thread GitBox
mocobeta commented on PR #57: URL: https://github.com/apache/lucene-jira-archive/pull/57#issuecomment-1191402838 Fortunately, this works also for old issues (in 2013). https://github.com/mocobeta/migration-test-3/issues/445 ![Screenshot from 2022-07-21 21-03-18](https://user-image

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #57: Enable hyperlinks to a commit in commitbots' comments

2022-07-21 Thread GitBox
mocobeta opened a new pull request, #57: URL: https://github.com/apache/lucene-jira-archive/pull/57 Close #11 Removes `[` and `]` if and only if it contains a URL-like string. We perhaps could apply it to all comments though, I applied it only to jira-bot's comments not to accidenta

[jira] [Commented] (LUCENE-10583) Deadlock with MMapDirectory while waitForMerges

2022-07-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569345#comment-17569345 ] ASF subversion and git services commented on LUCENE-10583: -- Co

[GitHub] [lucene] mikemccand commented on pull request #963: LUCENE-10583: Add docstring warning to not lock on Lucene objects

2022-07-21 Thread GitBox
mikemccand commented on PR #963: URL: https://github.com/apache/lucene/pull/963#issuecomment-1191325044 I backported to 9.x as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (LUCENE-10583) Deadlock with MMapDirectory while waitForMerges

2022-07-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569344#comment-17569344 ] ASF subversion and git services commented on LUCENE-10583: -- Co

[GitHub] [lucene] mikemccand merged pull request #963: LUCENE-10583: Add docstring warning to not lock on Lucene objects

2022-07-21 Thread GitBox
mikemccand merged PR #963: URL: https://github.com/apache/lucene/pull/963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-21 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r926482543 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-21 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r926470931 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-21 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r926470931 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[jira] [Commented] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-21 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569289#comment-17569289 ] Nathan Meisels commented on LUCENE-10650: - Hi [~jpountz]! Appreciate your help