[GitHub] [lucene] vigyasharma commented on pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-29 Thread GitBox
vigyasharma commented on PR #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1140767642 > I could either wrap the runningMerges update with a synchronized (IndexWriter.this) {}, or make runningMerges a synchronizedSet. I like the second approach as it automatically fixes th

[jira] [Comment Edited] (LUCENE-10596) Remove unused parameter in #getOrAddPerField

2022-05-29 Thread tangdh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543754#comment-17543754 ] tangdh edited comment on LUCENE-10596 at 5/30/22 5:51 AM: -- I h

[GitHub] [lucene] dweiss commented on pull request #912: MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-29 Thread GitBox
dweiss commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1140717409 Thanks for the explanation, Uwe. In the meantime I recalled what it was about toolchains that was a showstopper - indeed it was the possibility to specify a toolchain pointing at a particular

[jira] [Commented] (LUCENE-10596) Remove unused parameter in #getOrAddPerField

2022-05-29 Thread tangdh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543754#comment-17543754 ] tangdh commented on LUCENE-10596: - I have raised a PR,[PR|https://github.com/apache/luc

[GitHub] [lucene] tang-hi opened a new pull request, #930: (LUCENE-10596)Remove unused parameter in #getOrAddPerField

2022-05-29 Thread GitBox
tang-hi opened a new pull request, #930: URL: https://github.com/apache/lucene/pull/930 ### Description (or a Jira issue link if you have one) Please see [LUCENE-10596](https://issues.apache.org/jira/browse/LUCENE-10596?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpan

[GitHub] [lucene] uschindler commented on pull request #912: MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-29 Thread GitBox
uschindler commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1140527102 Hi Dawid, Thanks for feedback. Indeed the Tool chain API is very limited and in my honest opinion far from useful for Lucenes usages. There's no way to configure anything inside the Gr

[GitHub] [lucene] dweiss commented on pull request #912: MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-29 Thread GitBox
dweiss commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1140517332 Hi Uwe. I recall I had problems with toolchains - some things just refused to work (or we couldn't customize them? Can't remember precisely what the problem was). I looked at the code you wro

[jira] [Commented] (LUCENE-10596) Remove unused parameter in #getOrAddPerField

2022-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543691#comment-17543691 ] Michael McCandless commented on LUCENE-10596: - Thanks for noticing this!! 

[jira] [Comment Edited] (LUCENE-10596) Remove unused parameter in #getOrAddPerField

2022-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543691#comment-17543691 ] Michael McCandless edited comment on LUCENE-10596 at 5/29/22 5:44 PM: ---

[jira] [Created] (LUCENE-10596) Remove unused parameter in #getOrAddPerField

2022-05-29 Thread tangdh (Jira)
tangdh created LUCENE-10596: --- Summary: Remove unused parameter in #getOrAddPerField Key: LUCENE-10596 URL: https://issues.apache.org/jira/browse/LUCENE-10596 Project: Lucene - Core Issue Type: Impr

[GitHub] [lucene] uschindler commented on pull request #912: MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-29 Thread GitBox
uschindler commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1140447638 It is now possible to compile and run tests with different JVMs: If `RUNTIME_JAVA_HOME` does not point to *exactly* Java 19, it won't compile and give error message. This is needed

[GitHub] [lucene] gsmiller commented on pull request #929: LUCENE-10584: Properly support #getSpecificValue for hierarchical dims in SSDV faceting

2022-05-29 Thread GitBox
gsmiller commented on PR #929: URL: https://github.com/apache/lucene/pull/929#issuecomment-1140414699 @mdmarshmallow - might be a good one for you to have a look at when you get a minute. Pretty simple change but you've got a lot of context since you added hierarchical dim support to SSDV f

[GitHub] [lucene] gsmiller opened a new pull request, #929: LUCENE-10584: Properly support #getSpecificValue for hierarchical dims in SSDV faceting

2022-05-29 Thread GitBox
gsmiller opened a new pull request, #929: URL: https://github.com/apache/lucene/pull/929 ### Description (or a Jira issue link if you have one) Please see: LUCENE-10584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Created] (LUCENE-10595) TestGroupFacetCollector#testRandom has caught IndexOutOfBoundsException a couple times

2022-05-29 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10595: Summary: TestGroupFacetCollector#testRandom has caught IndexOutOfBoundsException a couple times Key: LUCENE-10595 URL: https://issues.apache.org/jira/browse/LUCENE-10595

[jira] [Resolved] (LUCENE-10585) Cleanup copy/paste code in facets, particularly in SSDV

2022-05-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10585. -- Fix Version/s: 10.0 (main) 9.3 Resolution: Fixed > Cleanup copy/pas

[GitHub] [lucene] gsmiller commented on pull request #915: LUCENE-10585: Scrub copy/paste code in the facets module and attempt to simplify a bit

2022-05-29 Thread GitBox
gsmiller commented on PR #915: URL: https://github.com/apache/lucene/pull/915#issuecomment-1140406510 @Yuti-G this is merged onto `main` and backported to `branch_9x`. Please feel free to rebase your PR on top of it, and let me know if you have any questions. Also, thanks for mentioning you

[jira] [Commented] (LUCENE-10585) Cleanup copy/paste code in facets, particularly in SSDV

2022-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543598#comment-17543598 ] ASF subversion and git services commented on LUCENE-10585: -- Co

[jira] [Commented] (LUCENE-10585) Cleanup copy/paste code in facets, particularly in SSDV

2022-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543587#comment-17543587 ] ASF subversion and git services commented on LUCENE-10585: -- Co

[GitHub] [lucene] gsmiller merged pull request #915: LUCENE-10585: Scrub copy/paste code in the facets module and attempt to simplify a bit

2022-05-29 Thread GitBox
gsmiller merged PR #915: URL: https://github.com/apache/lucene/pull/915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache