[jira] [Commented] (LUCENE-10510) Check module access prior to running gjf/spotless/errorprone tasks

2022-05-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542778#comment-17542778 ] Dawid Weiss commented on LUCENE-10510: -- This is caused by google formatter accessi

[jira] [Commented] (LUCENE-8806) WANDScorer should support two-phase iterator

2022-05-26 Thread Denilson Amorim (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542717#comment-17542717 ] Denilson Amorim commented on LUCENE-8806: - I was curious on the status of this i

[jira] [Commented] (LUCENE-10593) VectorSimilarityFunction reverse removal

2022-05-26 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542677#comment-17542677 ] Alessandro Benedetti commented on LUCENE-10593: --- https://github.com/apach

[GitHub] [lucene] alessandrobenedetti commented on a diff in pull request #926: VectorSimilarityFunction reverse removal

2022-05-26 Thread GitBox
alessandrobenedetti commented on code in PR #926: URL: https://github.com/apache/lucene/pull/926#discussion_r883088833 ## lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java: ## @@ -193,25 +204,36 @@ public void testAdvanceShallow() throws IOException {

[GitHub] [lucene] alessandrobenedetti opened a new pull request, #926: Neigbour queue reversed

2022-05-26 Thread GitBox
alessandrobenedetti opened a new pull request, #926: URL: https://github.com/apache/lucene/pull/926 (https://issues.apache.org/jira/browse/LUCENE-10593) org.apache.lucene.index.VectorSimilarityFunction#EUCLIDEAN similarity behaves in an opposite way in comparison to the other similari

[jira] [Commented] (LUCENE-10510) Check module access prior to running gjf/spotless/errorprone tasks

2022-05-26 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542669#comment-17542669 ] Alessandro Benedetti commented on LUCENE-10510: --- [~dweiss] Your help has

[jira] [Created] (LUCENE-10593) VectorSimilarityFunction reverse removal

2022-05-26 Thread Alessandro Benedetti (Jira)
Alessandro Benedetti created LUCENE-10593: - Summary: VectorSimilarityFunction reverse removal Key: LUCENE-10593 URL: https://issues.apache.org/jira/browse/LUCENE-10593 Project: Lucene - Core

[jira] [Commented] (LUCENE-10510) Check module access prior to running gjf/spotless/errorprone tasks

2022-05-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542668#comment-17542668 ] Dawid Weiss commented on LUCENE-10510: -- Delete your gradle.properties and allow it

[jira] [Commented] (LUCENE-10510) Check module access prior to running gjf/spotless/errorprone tasks

2022-05-26 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542666#comment-17542666 ] Alessandro Benedetti commented on LUCENE-10510: --- I spent roughly one hour

[GitHub] [lucene] Yuti-G commented on pull request #915: LUCENE-10585: Scrub copy/paste code in the facets module and attempt to simplify a bit

2022-05-26 Thread GitBox
Yuti-G commented on PR #915: URL: https://github.com/apache/lucene/pull/915#issuecomment-1138982348 Looks good to me! I will rebase my current work at https://github.com/apache/lucene/pull/914 - `getAllChildren` after this PR is merged. Thank you so much for making the code so clean! --

[GitHub] [lucene] gsmiller commented on pull request #915: LUCENE-10585: Scrub copy/paste code in the facets module and attempt to simplify a bit

2022-05-26 Thread GitBox
gsmiller commented on PR #915: URL: https://github.com/apache/lucene/pull/915#issuecomment-1138932259 Since this change is purely meant to remove some code duplication and make some very minor optimizations, and doesn't modify the API or expose any additional API surface area, I plan to mer

[GitHub] [lucene] gsmiller commented on pull request #915: LUCENE-10585: Scrub copy/paste code in the facets module and attempt to simplify a bit

2022-05-26 Thread GitBox
gsmiller commented on PR #915: URL: https://github.com/apache/lucene/pull/915#issuecomment-1138931375 @Yuti-G I just updated the PR with some additional comments/javadoc and a very minor optimization in the SSDV#getTopDims case. Could you have a look at the latest changes when you get a cha

[GitHub] [lucene] Yuti-G commented on pull request #915: LUCENE-10585: Scrub copy/paste code in the facets module and attempt to simplify a bit

2022-05-26 Thread GitBox
Yuti-G commented on PR #915: URL: https://github.com/apache/lucene/pull/915#issuecomment-1138850060 > But: the `getAllDims` time for SSDV seems to have gotten much faster with this PR, which is great! Was that expected? Or is this some horrible noise? Is it repeatable? I think it's j

[GitHub] [lucene-solr] thelabdude merged pull request #2662: SOLR-16215 Escape query characters in Solr SQL Array UDF functions

2022-05-26 Thread GitBox
thelabdude merged PR #2662: URL: https://github.com/apache/lucene-solr/pull/2662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@luce

[GitHub] [lucene] msokolov commented on pull request #924: Create Lucene93 Codec and move Lucene92 to backwards_codecs

2022-05-26 Thread GitBox
msokolov commented on PR #924: URL: https://github.com/apache/lucene/pull/924#issuecomment-1138630677 Hmm I got confused about the capitalization of the format name. I saw that the names were initial-lower-case, which I thought was a mistake introduced during this refactoring, but now I see

[GitHub] [lucene] msokolov commented on a diff in pull request #924: Create Lucene93 Codec and move Lucene92 to backwards_codecs

2022-05-26 Thread GitBox
msokolov commented on code in PR #924: URL: https://github.com/apache/lucene/pull/924#discussion_r882700613 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene92/TestLucene92HnswVectorsFormat.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene] msokolov commented on a diff in pull request #924: Create Lucene93 Codec and move Lucene92 to backwards_codecs

2022-05-26 Thread GitBox
msokolov commented on code in PR #924: URL: https://github.com/apache/lucene/pull/924#discussion_r882698450 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene92/Lucene92RWHnswVectorsFormat.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software

[jira] [Comment Edited] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

2022-05-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542440#comment-17542440 ] Uwe Schindler edited comment on LUCENE-10562 at 5/26/22 10:58 AM: ---

[jira] [Commented] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

2022-05-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542440#comment-17542440 ] Uwe Schindler commented on LUCENE-10562: Hi [~zhuming], this is better a questi