[
https://issues.apache.org/jira/browse/LUCENE-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541292#comment-17541292
]
ASF subversion and git services commented on LUCENE-10586:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541290#comment-17541290
]
ASF subversion and git services commented on LUCENE-10586:
--
Co
mocobeta merged PR #918:
URL: https://github.com/apache/lucene/pull/918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
mocobeta merged PR #916:
URL: https://github.com/apache/lucene/pull/916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
mocobeta commented on PR #916:
URL: https://github.com/apache/lucene/pull/916#issuecomment-1135442476
Thank you @rmuir for reviewing.
I'd merge this - let's restart from a blank sheet (all necessary information
should be written in the contribution guide), but if anyone has suggestion
[
https://issues.apache.org/jira/browse/LUCENE-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541282#comment-17541282
]
Kaival Parikh commented on LUCENE-10559:
The graph construction parameters were
[
https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10590:
---
Attachment: (was: image.png)
> Indexing all zero vectors leads to heat death of the universe
>
[
https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10590:
---
Attachment: image.png
> Indexing all zero vectors leads to heat death of the universe
> ---
mocobeta commented on code in PR #916:
URL: https://github.com/apache/lucene/pull/916#discussion_r879967339
##
CONTRIBUTING.md:
##
@@ -78,8 +78,11 @@ Please be patient. Committers are busy people too. If no one
responds to your pa
Please refer to [GitHub's
documentation](ht
mocobeta commented on code in PR #916:
URL: https://github.com/apache/lucene/pull/916#discussion_r879964992
##
CONTRIBUTING.md:
##
@@ -78,8 +78,11 @@ Please be patient. Committers are busy people too. If no one
responds to your pa
Please refer to [GitHub's
documentation](ht
[
https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541185#comment-17541185
]
Julie Tibshirani edited comment on LUCENE-10590 at 5/23/22 10:26 PM:
[
https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541185#comment-17541185
]
Julie Tibshirani edited comment on LUCENE-10590 at 5/23/22 10:26 PM:
[
https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541193#comment-17541193
]
Michael Sokolov commented on LUCENE-10590:
--
Thanks Julie, this is definitely t
[
https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541185#comment-17541185
]
Julie Tibshirani commented on LUCENE-10590:
---
I don't have a deep understandin
jtibshirani commented on PR #920:
URL: https://github.com/apache/lucene/pull/920#issuecomment-1135164651
Thank you @mocobeta for looking into this! I don't think the failure is
caused having multiple segments, since we make sure to force merge to one
segment before starting the searches. St
[
https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541180#comment-17541180
]
Michael Sokolov commented on LUCENE-10590:
--
> Love the title, Michael Sokolov.
gsmiller commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r879871471
##
lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/HyperRectangleFacetCounts.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
gsmiller commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r879870847
##
lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/HyperRectangle.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
gsmiller commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r879869751
##
lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/LongPointFacetField.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
gsmiller commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r879866385
##
lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/HyperRectangleFacetCounts.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Yuti-G commented on PR #915:
URL: https://github.com/apache/lucene/pull/915#issuecomment-1135050190
Hi @gsmiller, thanks for making a lot of improvements to the code, and it
looks great to me! I also ran the benchmarks for facet and do not observe much
difference from the main branch. I add
Yuti-G commented on code in PR #915:
URL: https://github.com/apache/lucene/pull/915#discussion_r879786369
##
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##
@@ -0,0 +1,333 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541100#comment-17541100
]
Dawid Weiss commented on LUCENE-10590:
--
Love the title, [~sokolov]. Very Douglas-y
shahrs87 commented on PR #897:
URL: https://github.com/apache/lucene/pull/897#issuecomment-1134875992
@jpountz Thank you for the feedback. I have addressed your comments in the
latest revision. I have one question. To make changes in the CHANGES.txt file,
will this change go in `API change
shahrs87 commented on code in PR #897:
URL: https://github.com/apache/lucene/pull/897#discussion_r879640718
##
lucene/core/src/java/org/apache/lucene/search/NearestNeighbor.java:
##
@@ -31,12 +31,8 @@
import org.apache.lucene.util.Bits;
import org.apache.lucene.util.SloppyMath
shahrs87 commented on code in PR #897:
URL: https://github.com/apache/lucene/pull/897#discussion_r879640507
##
lucene/core/src/java/org/apache/lucene/document/LatLonPoint.java:
##
@@ -362,4 +377,72 @@ public static Query newDistanceFeatureQuery(
}
return query;
}
+
mocobeta commented on code in PR #916:
URL: https://github.com/apache/lucene/pull/916#discussion_r879634562
##
CONTRIBUTING.md:
##
@@ -78,8 +78,11 @@ Please be patient. Committers are busy people too. If no one
responds to your pa
Please refer to [GitHub's
documentation](ht
msokolov commented on PR #920:
URL: https://github.com/apache/lucene/pull/920#issuecomment-1134842970
Yeah, I'm just not sure that all the implications are desirable for this
test. For example if we have a segment with 5 docs, their "tags" might all be >
the threshold of the filter?
--
T
mocobeta commented on PR #920:
URL: https://github.com/apache/lucene/pull/920#issuecomment-1134837438
According to the javadocs of the test, using a randomly skewed index with
RandomIndexWriter is an intentional choice I think?
```
/** Tests with random vectors and a random filter. Us
rmuir commented on code in PR #916:
URL: https://github.com/apache/lucene/pull/916#discussion_r879605545
##
CONTRIBUTING.md:
##
@@ -78,8 +78,11 @@ Please be patient. Committers are busy people too. If no one
responds to your pa
Please refer to [GitHub's
documentation](https
Michael Sokolov created LUCENE-10590:
Summary: Indexing all zero vectors leads to heat death of the
universe
Key: LUCENE-10590
URL: https://issues.apache.org/jira/browse/LUCENE-10590
Project: Luce
[
https://issues.apache.org/jira/browse/LUCENE-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541000#comment-17541000
]
Rushabh Shah commented on LUCENE-8519:
--
[~dsmiley] Thank you for the review and the
msokolov commented on PR #920:
URL: https://github.com/apache/lucene/pull/920#issuecomment-1134805154
I suspect what's happening is RandomIndexWriter is causing some very small
segment to be written, and within that segment the query *is* highly selective
causing us to fall back to brute fo
[
https://issues.apache.org/jira/browse/LUCENE-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540996#comment-17540996
]
Adrien Grand commented on LUCENE-10586:
---
+1
The reason is historical indeed. The
mocobeta commented on PR #918:
URL: https://github.com/apache/lucene/pull/918#issuecomment-1134773996
Thanks @mikemccand for confirming this.
I'll keep this open for a few more days for others to review it.
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540979#comment-17540979
]
Adrien Grand commented on LUCENE-10078:
---
We had discussions about this in the con
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540961#comment-17540961
]
ASF subversion and git services commented on LUCENE-10229:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540955#comment-17540955
]
ASF subversion and git services commented on LUCENE-10229:
--
Co
rmuir merged PR #901:
URL: https://github.com/apache/lucene/pull/901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or
[
https://issues.apache.org/jira/browse/LUCENE-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540950#comment-17540950
]
Tomoko Uchida commented on LUCENE-10589:
You’re welcome - debugging this was a
jpountz opened a new pull request, #921:
URL: https://github.com/apache/lucene/pull/921
This gives implementations of `findFullFlushMerges` to `LogMergePolicy` and
`TieredMergePolicy` and enables merge-on-refresh with a default timeout of
500ms.
The idea behind the 500ms default
mocobeta commented on PR #920:
URL: https://github.com/apache/lucene/pull/920#issuecomment-1134641142
It looks like the test can be tweaked not to fall into the corner cases but
I'm not fully sure if this is correct - is there a better way to fix it?
--
This is an automated message from t
[
https://issues.apache.org/jira/browse/LUCENE-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540935#comment-17540935
]
Dawid Weiss commented on LUCENE-10589:
--
I don't know anything about this code area
mocobeta opened a new pull request, #920:
URL: https://github.com/apache/lucene/pull/920
This is a small tweak for `TestKnnVectorQuery.testRandomWithFilter()`.
See https://issues.apache.org/jira/browse/LUCENE-10589.
On main:
```
./gradlew test --tests TestKnnVectorQuery.te
Tomoko Uchida created LUCENE-10589:
--
Summary: Fix corner case in TestKnnVectorQuery.testRandomWithFilter
Key: LUCENE-10589
URL: https://issues.apache.org/jira/browse/LUCENE-10589
Project: Lucene - Cor
romseygeek commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134383958
Thanks Dawid!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
dweiss commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134379491
I've committed a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/LUCENE-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540837#comment-17540837
]
ASF subversion and git services commented on LUCENE-10370:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540836#comment-17540836
]
ASF subversion and git services commented on LUCENE-10370:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540835#comment-17540835
]
Adrien Grand commented on LUCENE-10574:
---
The stored fields benchmark aimed at rep
uschindler commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134378329
Yes, your Jenkins seems to call `gradlew clean test`, too, so this is
failing.
On ASF and Policeman Jenkins we do not do this, so it passes. Jenkins on my
managed Jenkins instances
romseygeek commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134378224
Can confirm that adding the `createDirectories` line before the
`writeString` fixes the problem. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
dweiss commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134375202
I know why you're getting it. clean executes after configuration and wipes
the temporary task directory for test. We'll have to recreate it properly. I'll
commit a fix soon.
--
This is an
dweiss commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134374008
try Files.createDirectories(forkProperties.toPath().getParent());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dweiss commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134373557
No. I think it's the parent path that is missing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
romseygeek commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134370810
Hey Dawid, yes I get local failures if I run `./gradlew clean check`.
```
* Where:
Script '/Users/romseygeek/projects/lucene/gradle/java/modules.gradle' line:
215
* Wha
dweiss commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134368823
Hi Alan. Is the Lucene build failing for you locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
romseygeek commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134364141
Aha, and it's failing locally for me as well. I'll see if I can work out
where the issue is!
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
romseygeek commented on PR #909:
URL: https://github.com/apache/lucene/pull/909#issuecomment-1134360770
Hiya, this is making the elasticsearch CI cross; all builds are failing with
this message:
```
* Where:
08:09:37 Script
'/var/lib/jenkins/workspace/apache+lucene+main/gradle/java
shaie merged PR #919:
URL: https://github.com/apache/lucene/pull/919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or
mocobeta commented on PR #917:
URL: https://github.com/apache/lucene/pull/917#issuecomment-1134306924
> One change I think we could try is to run the forked command with a higher
priority
Thanks for your suggestion; we could try this workaround though, I feel like
it'd be better to k
Tomoko Uchida created LUCENE-10588:
--
Summary: Make Luke launching code faster
Key: LUCENE-10588
URL: https://issues.apache.org/jira/browse/LUCENE-10588
Project: Lucene - Core
Issue Type: Imp
62 matches
Mail list logo
