[GitHub] [lucene] dweiss commented on pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
dweiss commented on PR #917: URL: https://github.com/apache/lucene/pull/917#issuecomment-1133832324 It is impossible and insane - something is wrong. I don't believe forking a simple process requires 600 seconds to complete, while running gradle tasks completes orders of magnitude faster. T

[GitHub] [lucene] mocobeta opened a new pull request, #918: Lucene-10586: Minor cleanup for local variables in BlockTreeTermsReader

2022-05-21 Thread GitBox
mocobeta opened a new pull request, #918: URL: https://github.com/apache/lucene/pull/918 See https://issues.apache.org/jira/browse/LUCENE-10586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (LUCENE-10586) Minor refactoring in Lucene90BlockTreeTermsReader local variables: metaIn, indexMetaIn, termsMetaIn

2022-05-21 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-10586: -- Summary: Minor refactoring in Lucene90BlockTreeTermsReader local variables: metaIn, indexMetaIn, termsMetaIn Key: LUCENE-10586 URL: https://issues.apache.org/jira/browse/LUCEN

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-05-21 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r878796006 ## lucene/core/src/java/org/apache/lucene/document/DoublePointDocValuesField.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [lucene] mocobeta commented on pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
mocobeta commented on PR #917: URL: https://github.com/apache/lucene/pull/917#issuecomment-1133823694 I tested several timeouts. - 60 seconds: occasionally fails - 120 seconds: occasionally fails - 600 seconds: didn't see any failure in several dozens of runs It looks like inc

[jira] [Commented] (LUCENE-10583) Deadlock with MMapDirectory while waitForMerges

2022-05-21 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540532#comment-17540532 ] Vigya Sharma commented on LUCENE-10583: --- Added some comments to   [LUCENE-3373|ht

[jira] [Commented] (LUCENE-3373) waitForMerges deadlocks if background merge fails

2022-05-21 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540531#comment-17540531 ] Vigya Sharma commented on LUCENE-3373: -- I have a hypothesis... When we IndexWriter

[jira] [Commented] (LUCENE-3373) waitForMerges deadlocks if background merge fails

2022-05-21 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540526#comment-17540526 ] Vigya Sharma commented on LUCENE-3373: -- Sorry you ran into this Thomas. I tried bea

[jira] [Resolved] (LUCENE-8519) MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8519. -- Fix Version/s: 9.3 Resolution: Fixed Thanks for contributing Rushabh! > MultiDocValues

[GitHub] [lucene] dsmiley closed pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-21 Thread GitBox
dsmiley closed pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos URL: https://github.com/apache/lucene/pull/898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] dsmiley commented on pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-21 Thread GitBox
dsmiley commented on PR #898: URL: https://github.com/apache/lucene/pull/898#issuecomment-1133815329 I ended up cherry picking #902 so I'll close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (LUCENE-8519) MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540523#comment-17540523 ] ASF subversion and git services commented on LUCENE-8519: - Commi

[GitHub] [lucene] mocobeta commented on pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
mocobeta commented on PR #917: URL: https://github.com/apache/lucene/pull/917#issuecomment-1133810346 Repeating the test in the same machine didn't reproduce the failure for me too. I tried setting up 20 virtual machines and one of them failed. https://github.com/mocobeta/lucene/p

[jira] [Commented] (LUCENE-8519) MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540521#comment-17540521 ] ASF subversion and git services commented on LUCENE-8519: - Commi

[GitHub] [lucene] dsmiley merged pull request #902: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-21 Thread GitBox
dsmiley merged PR #902: URL: https://github.com/apache/lucene/pull/902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-05-21 Thread GitBox
mdmarshmallow commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r878767917 ## lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/HyperRectangle.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] dweiss commented on pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
dweiss commented on PR #917: URL: https://github.com/apache/lucene/pull/917#issuecomment-1133749390 https://github.com/dweiss/lucene/actions/runs/2363545679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [lucene] dweiss commented on pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
dweiss commented on PR #917: URL: https://github.com/apache/lucene/pull/917#issuecomment-1133749382 I've been trying to reproduce this with more debugging info but can't, in spite of several dozen attempts. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene] mocobeta commented on pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
mocobeta commented on PR #917: URL: https://github.com/apache/lucene/pull/917#issuecomment-1133669396 Just a quick note: I noticed that it looks like some virtual display/monitor is enabled on the Windows Server VM in https://github.com/mocobeta/lucene/pull/2. I'm not sure the Windows VM in

[GitHub] [lucene] mocobeta commented on pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
mocobeta commented on PR #917: URL: https://github.com/apache/lucene/pull/917#issuecomment-1133656519 Thanks. I muted it for now since I thought we shouldn't experiment in the upstream repository, but I'll also look at it when I have spare time. It looks like it can be easily reproduc

[GitHub] [lucene] dweiss commented on pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
dweiss commented on PR #917: URL: https://github.com/apache/lucene/pull/917#issuecomment-1133651444 I'm not sure what's causing this. It looks strange. I'll play around and report if I find out anything. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (LUCENE-10531) Mark testLukeCanBeLaunched @Nightly test and make a dedicated Github CI workflow for it

2022-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540437#comment-17540437 ] ASF subversion and git services commented on LUCENE-10531: -- Co

[jira] [Commented] (LUCENE-10531) Mark testLukeCanBeLaunched @Nightly test and make a dedicated Github CI workflow for it

2022-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540436#comment-17540436 ] ASF subversion and git services commented on LUCENE-10531: -- Co

[GitHub] [lucene] mocobeta merged pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
mocobeta merged PR #917: URL: https://github.com/apache/lucene/pull/917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[GitHub] [lucene] mocobeta commented on pull request #917: LUCENE-10531: Disable distribution test (gui test) on windows.

2022-05-21 Thread GitBox
mocobeta commented on PR #917: URL: https://github.com/apache/lucene/pull/917#issuecomment-1133646096 I would merge this now not to fail the CI in unrelated pull requests; we could re-enable it on windows vm in the future if the GH actions runner is improved. -- This is an automated mess

[GitHub] [lucene] msokolov commented on a diff in pull request #913: Lucene 10577

2022-05-21 Thread GitBox
msokolov commented on code in PR #913: URL: https://github.com/apache/lucene/pull/913#discussion_r878686983 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -213,4 +213,21 @@ public static void add(float[] u, float[] v) { u[i] += v[i]; } } + +

[GitHub] [lucene] msokolov commented on a diff in pull request #913: Lucene 10577

2022-05-21 Thread GitBox
msokolov commented on code in PR #913: URL: https://github.com/apache/lucene/pull/913#discussion_r878686983 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -213,4 +213,21 @@ public static void add(float[] u, float[] v) { u[i] += v[i]; } } + +

[GitHub] [lucene] msokolov commented on pull request #913: Lucene 10577

2022-05-21 Thread GitBox
msokolov commented on PR #913: URL: https://github.com/apache/lucene/pull/913#issuecomment-1133605270 > It's not a part of the mandatory test suite but you can run it headlessly with a virtual display (if you are on Linux). Please see: Thanks, I guess it runs as part of `check` tasks? An

[GitHub] [lucene] mocobeta commented on a diff in pull request #912: Initial rewrite of MMapDirectory for JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-21 Thread GitBox
mocobeta commented on code in PR #912: URL: https://github.com/apache/lucene/pull/912#discussion_r87874 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -232,55 +224,62 @@ public IndexInput openInput(String name, IOContext context) throws IOExceptio

[GitHub] [lucene] vigyasharma commented on a diff in pull request #892: LUCENE-10581: Optimize stored fields bulk merges on the first segment

2022-05-21 Thread GitBox
vigyasharma commented on code in PR #892: URL: https://github.com/apache/lucene/pull/892#discussion_r878666817 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsWriter.java: ## @@ -553,14 +554,20 @@ private void copyChunks(

[GitHub] [lucene] mocobeta commented on a diff in pull request #912: Initial rewrite of MMapDirectory for JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-21 Thread GitBox
mocobeta commented on code in PR #912: URL: https://github.com/apache/lucene/pull/912#discussion_r87874 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -232,55 +224,62 @@ public IndexInput openInput(String name, IOContext context) throws IOExceptio

[GitHub] [lucene] mocobeta commented on a diff in pull request #912: Initial rewrite of MMapDirectory for JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-21 Thread GitBox
mocobeta commented on code in PR #912: URL: https://github.com/apache/lucene/pull/912#discussion_r878663653 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -232,55 +224,62 @@ public IndexInput openInput(String name, IOContext context) throws IOExceptio

[GitHub] [lucene] uschindler commented on a diff in pull request #912: Initial rewrite of MMapDirectory for JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-21 Thread GitBox
uschindler commented on code in PR #912: URL: https://github.com/apache/lucene/pull/912#discussion_r878662352 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -232,55 +224,62 @@ public IndexInput openInput(String name, IOContext context) throws IOExcept

[jira] [Commented] (LUCENE-10184) Move "how to contribute" documentation to the git repo

2022-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540366#comment-17540366 ] ASF subversion and git services commented on LUCENE-10184: -- Co