[GitHub] [lucene] LuXugang closed pull request #511: LUCENE-10281: Error condition used to judge whether hits are sparse in StringValueFacetCounts

LuXugang closed pull request #511: LUCENE-10281: Error condition used to judge whether hits are sparse in StringValueFacetCounts URL: https://github.com/apache/lucene/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [lucene] mocobeta commented on a diff in pull request #890: Detect CI builds and enable errorprone by default for those CI builds

mocobeta commented on code in PR #890: URL: https://github.com/apache/lucene/pull/890#discussion_r873102060 ## lucene/CHANGES.txt: ## @@ -211,7 +211,9 @@ Build * Upgrade forbiddenapis to version 3.3. (Uwe Schindler) -* LUCENE-10532: Remove LuceneTestCase.Slow annotation. A

[GitHub] [lucene] mocobeta commented on a diff in pull request #890: Detect CI builds and enable errorprone by default for those CI builds

mocobeta commented on code in PR #890: URL: https://github.com/apache/lucene/pull/890#discussion_r873099427 ## lucene/CHANGES.txt: ## @@ -211,7 +211,9 @@ Build * Upgrade forbiddenapis to version 3.3. (Uwe Schindler) -* LUCENE-10532: Remove LuceneTestCase.Slow annotation. A

[GitHub] [lucene] mocobeta commented on a diff in pull request #890: Detect CI builds and enable errorprone by default for those CI builds

mocobeta commented on code in PR #890: URL: https://github.com/apache/lucene/pull/890#discussion_r873099330 ## lucene/CHANGES.txt: ## @@ -211,7 +211,9 @@ Build * Upgrade forbiddenapis to version 3.3. (Uwe Schindler) -* LUCENE-10532: Remove LuceneTestCase.Slow annotation. A

[GitHub] [lucene] uschindler merged pull request #890: Detect CI builds and enable errorprone by default for those CI builds

uschindler merged PR #890: URL: https://github.com/apache/lucene/pull/890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] uschindler commented on pull request #890: Detect CI builds and enable errorprone by default for those CI builds

uschindler commented on PR #890: URL: https://github.com/apache/lucene/pull/890#issuecomment-1126793622 The owasp check currently fails because of vulns in Jetty. We should upgrade (that's a separate task). -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene] uschindler commented on pull request #890: Detect CI builds and enable errorprone by default for those CI builds

uschindler commented on PR #890: URL: https://github.com/apache/lucene/pull/890#issuecomment-1126790330 I renamed the project property to just "errorprone". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] uschindler commented on a diff in pull request #890: Detect CI builds and enable errorprone by default for those CI builds

uschindler commented on code in PR #890: URL: https://github.com/apache/lucene/pull/890#discussion_r872968994 ## gradle/globals.gradle: ## @@ -147,5 +147,10 @@ allprojects { } return taskList } + +// detect if we run in CI environment by looking at existen

[GitHub] [lucene] uschindler opened a new pull request, #890: Detect CI builds and enable errorprone by default for those CI builds

uschindler opened a new pull request, #890: URL: https://github.com/apache/lucene/pull/890 This detects CI builds (Github and Jenkins) using existence of some environment variables. There is a new ext property `project.ext.isCIBuild`. The ext property is used to enable errorprone on t

[jira] [Commented] (LUCENE-10572) Can we optimize BytesRefHash?

[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537023#comment-17537023 ] Michael McCandless commented on LUCENE-10572: - {quote}Mike, could you make

[jira] [Commented] (LUCENE-10572) Can we optimize BytesRefHash?

[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537018#comment-17537018 ] Robert Muir commented on LUCENE-10572: -- {quote} Most terms are shorter than 128 by

[jira] [Comment Edited] (LUCENE-10572) Can we optimize BytesRefHash?

[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537013#comment-17537013 ] Uwe Schindler edited comment on LUCENE-10572 at 5/14/22 10:29 AM: ---

[jira] [Comment Edited] (LUCENE-10572) Can we optimize BytesRefHash?

[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537013#comment-17537013 ] Uwe Schindler edited comment on LUCENE-10572 at 5/14/22 10:28 AM: ---

[jira] [Comment Edited] (LUCENE-10572) Can we optimize BytesRefHash?

[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537013#comment-17537013 ] Uwe Schindler edited comment on LUCENE-10572 at 5/14/22 10:27 AM: ---

[jira] [Commented] (LUCENE-10572) Can we optimize BytesRefHash?

[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537013#comment-17537013 ] Uwe Schindler commented on LUCENE-10572: Mike, could you make a test on how muc

[jira] [Commented] (LUCENE-10572) Can we optimize BytesRefHash?

[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537009#comment-17537009 ] Uwe Schindler commented on LUCENE-10572: Hi, actually the reason why BE encodin