Yuti-G commented on PR #843:
URL: https://github.com/apache/lucene/pull/843#issuecomment-1110592769
Please see the benchmark results below:
```
TaskQPS baseline StdDevQPS candidate
StdDevPct diffp-value
BrowseMonthTaxoFac
[
https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10538:
Priority: Minor (was: Major)
> TopN is not being used in getTopChildren()
>
[
https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10538:
Description: When looking at the overridden implementation
getTopChildren(int topN, String dim, S
[
https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10538:
Description: When looking at the overridden implementation
getTopChildren(int topN, String dim, S
[
https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10538:
Description: When looking at the overridden implementation
getTopChildren(int topN, String dim, S
[
https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528554#comment-17528554
]
ASF subversion and git services commented on LUCENE-10508:
--
Co
Yuti-G opened a new pull request, #843:
URL: https://github.com/apache/lucene/pull/843
# Description
This change fixed the issue that top-n parameter is not being used in the
getTopChildren function in RangeFacetCounts.
# Solution
Evaluate if top-n value is less than th
[
https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528552#comment-17528552
]
ASF subversion and git services commented on LUCENE-10508:
--
Co
iverase merged PR #824:
URL: https://github.com/apache/lucene/pull/824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528541#comment-17528541
]
Lu Xugang commented on LUCENE-10537:
Thanks [~jpountz] for your note.
{quote}we di
Yuting Gan created LUCENE-10538:
---
Summary: TopN is not being used in getTopChildren()
Key: LUCENE-10538
URL: https://issues.apache.org/jira/browse/LUCENE-10538
Project: Lucene - Core
Issue Type
[
https://issues.apache.org/jira/browse/LUCENE-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528507#comment-17528507
]
Greg Miller commented on LUCENE-10204:
--
Yeah +1 to not pursuing further right now.
[
https://issues.apache.org/jira/browse/LUCENE-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10204.
--
Resolution: Won't Fix
> Support iteration of sub-matches in join queries (ToParentBlockJoinQu
[
https://issues.apache.org/jira/browse/LUCENE-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528504#comment-17528504
]
Greg Miller commented on LUCENE-10529:
--
Just pushed a fix for the NPE (rare random
[
https://issues.apache.org/jira/browse/LUCENE-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528502#comment-17528502
]
ASF subversion and git services commented on LUCENE-10529:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528499#comment-17528499
]
ASF subversion and git services commented on LUCENE-10529:
--
Co
dnhatn opened a new pull request, #842:
URL: https://github.com/apache/lucene/pull/842
This change relaxes the field consistency check for old indices as we didn't
enforce that in the previous versions. This commit also disables the
optimization that relies on the field consistency for old
[ https://issues.apache.org/jira/browse/LUCENE-10519 ]
Lucifer Boice deleted comment on LUCENE-10519:
was (Author: JIRAUSER288072):
@[mikemccand|https://github.com/mikemccand] can you help give some opinion,
please? appreciated.
> Improvem
[
https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528488#comment-17528488
]
Lucifer Boice commented on LUCENE-10519:
@[mikemccand|https://github.com/mikemc
[
https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucifer Boice updated LUCENE-10519:
---
Summary: Improvement for CloseableThreadLocal (was: ThreadLocal.remove
under G1GC takes 10
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528448#comment-17528448
]
Chris M. Hostetter commented on LUCENE-10534:
-
{quote}I found the same patt
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528447#comment-17528447
]
Chris M. Hostetter commented on LUCENE-10534:
-
Your two PRs seem good to me
[
https://issues.apache.org/jira/browse/LUCENE-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528445#comment-17528445
]
Marc D'Mello commented on LUCENE-10274:
---
Created a basic unoptimized initial comm
mdmarshmallow opened a new pull request, #841:
URL: https://github.com/apache/lucene/pull/841
# Description
Added basic hyperrectangle faceting capabilities. This is mostly just a
draft PR to sketch out what the API will look like. Added new fields to store
points as a Bi
[
https://issues.apache.org/jira/browse/LUCENE-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528401#comment-17528401
]
Greg Miller commented on LUCENE-10529:
--
Looks like maybe the same thing reported i
[
https://issues.apache.org/jira/browse/LUCENE-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528402#comment-17528402
]
Greg Miller commented on LUCENE-10530:
--
Possibly the same issue also reported in L
[
https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10495.
--
Fix Version/s: 9.2
Resolution: Fixed
> Fix return statement of siblingsLoaded() in Tax
[
https://issues.apache.org/jira/browse/LUCENE-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528377#comment-17528377
]
Dawid Weiss commented on LUCENE-10386:
--
Hi Petr. Sorry for the delay. I'll try to
[
https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528375#comment-17528375
]
Michael Sokolov commented on LUCENE-10519:
--
I looked at the patch. It's hard t
risdenk commented on code in PR #840:
URL: https://github.com/apache/lucene/pull/840#discussion_r859076455
##
lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/DoubleFieldSource.java:
##
@@ -52,55 +50,32 @@ public SortField getSortField(boolean reverse) {
risdenk commented on code in PR #840:
URL: https://github.com/apache/lucene/pull/840#discussion_r859074624
##
lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/LongFieldSource.java:
##
@@ -147,10 +122,6 @@ protected NumericDocValues getNumericDocValues(
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528369#comment-17528369
]
Kevin Risden commented on LUCENE-10534:
---
I'm still getting used to flamegraphs so
risdenk commented on code in PR #840:
URL: https://github.com/apache/lucene/pull/840#discussion_r859065937
##
lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/DoubleFieldSource.java:
##
@@ -52,55 +50,32 @@ public SortField getSortField(boolean reverse) {
risdenk opened a new pull request, #840:
URL: https://github.com/apache/lucene/pull/840
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the approach taken to implement
[
https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528362#comment-17528362
]
Michael Sokolov commented on LUCENE-10527:
--
Yes, good find! Agree that users m
[
https://issues.apache.org/jira/browse/LUCENE-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528360#comment-17528360
]
Michael Sokolov commented on LUCENE-8580:
-
It seems we have generally stuck with
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528338#comment-17528338
]
Chris M. Hostetter commented on LUCENE-10534:
-
So you're thinking that we c
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528331#comment-17528331
]
Kevin Risden edited comment on LUCENE-10534 at 4/26/22 5:45 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528331#comment-17528331
]
Kevin Risden commented on LUCENE-10534:
---
Here is a small part of the flamegraph h
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10534:
--
Attachment: flamegraph_getValueForDoc.png
> MinFloatFunction / MaxFloatFunction exists check
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528329#comment-17528329
]
Kevin Risden commented on LUCENE-10534:
---
So my thoughts about 0.0f were based on
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10534:
--
Attachment: flamegraph.png
> MinFloatFunction / MaxFloatFunction exists check can be slow
> -
jpountz commented on PR #838:
URL: https://github.com/apache/lucene/pull/838#issuecomment-1109956838
> is it just the case for the old indexes that because we indexed with
initial empty dictionary that anything we put in the dictionary will be
effectively "ignored" (e.g. basically pushed ou
rmuir commented on PR #838:
URL: https://github.com/apache/lucene/pull/838#issuecomment-1109947215
i'm just asking questions because i have only worked with the deflate
dictionaries not the lz4 ones. is it just the case for the old indexes that
because we indexed with initial empty dictiona
[
https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10436:
--
Fix Version/s: 9.2
> Combine DocValuesFieldExistsQuery, NormsFieldExistsQuery and
> KnnVecto
jpountz commented on code in PR #833:
URL: https://github.com/apache/lucene/pull/833#discussion_r858834778
##
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java:
##
@@ -323,6 +325,62 @@ public int nextDoc() throws IOException {
: sortedSetDocVal
[
https://issues.apache.org/jira/browse/LUCENE-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528224#comment-17528224
]
Adrien Grand commented on LUCENE-10537:
---
On previous issues, we discussed that it
jpountz commented on PR #838:
URL: https://github.com/apache/lucene/pull/838#issuecomment-1109906929
It's backward compatible, old indices will just never have references to
content that lives in the compression dictionary.
I'm happy to still create a new Lucene92Codec+Lucene92DocValu
LuXugang opened a new pull request, #839:
URL: https://github.com/apache/lucene/pull/839
If scores are not needed, could we let BooleanWeight deal with optimizing
things?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
Lu Xugang created LUCENE-10537:
--
Summary: DisjunctionMaxWeight could rewrite to BooleanWeight if
score is disable
Key: LUCENE-10537
URL: https://issues.apache.org/jira/browse/LUCENE-10537
Project: Lucene
[
https://issues.apache.org/jira/browse/LUCENE-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10537:
---
Summary: DisjunctionMaxWeight could be rewrite to BooleanWeight if score is
disable (was: Disjunct
rmuir commented on PR #838:
URL: https://github.com/apache/lucene/pull/838#issuecomment-1109826778
nice idea. but is it really backwards-compatible? Shouldn't we force a new
version (preferred) or at least bump internal constant?
--
This is an automated message from the Apache Git Service
[
https://issues.apache.org/jira/browse/LUCENE-10499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10499.
---
Fix Version/s: 9.2
Resolution: Fixed
Thanks [~wjp719]!
> reduce unnecessary copy da
[
https://issues.apache.org/jira/browse/LUCENE-10499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528176#comment-17528176
]
ASF subversion and git services commented on LUCENE-10499:
--
Co
jpountz merged PR #786:
URL: https://github.com/apache/lucene/pull/786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
jpountz opened a new pull request, #838:
URL: https://github.com/apache/lucene/pull/838
Doc values terms dictionaries keep the first term of each block uncompressed
so
that they can somewhat efficiently perform binary searches across blocks.
Suffixes of the other 63 terms are compresse
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528159#comment-17528159
]
Kevin Risden commented on LUCENE-10534:
---
Thanks [~hossman] for the comments and e
Adrien Grand created LUCENE-10536:
-
Summary: Doc values terms dicts should use the first term of each
block as a dictionary
Key: LUCENE-10536
URL: https://issues.apache.org/jira/browse/LUCENE-10536
Pr
boicehuang commented on PR #816:
URL: https://github.com/apache/lucene/pull/816#issuecomment-1109518481
@mikemccand can you also help review this improvement for
`CloseableThreadLocal`? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
[
https://issues.apache.org/jira/browse/LUCENE-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528001#comment-17528001
]
Petr Portnov commented on LUCENE-10386:
---
Thanks for your response!
If this would
60 matches
Mail list logo
