mocobeta commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103423089
> Maybe it could be in a .properties file? Not gradle, not groovy, a real
actual .properties file that we can read with java.io.Properties too?
+1 to a single source of source/target
[
https://issues.apache.org/jira/browse/LUCENE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524664#comment-17524664
]
Robert Muir commented on LUCENE-10525:
--
I added a PR with a stab at the refactorin
rmuir opened a new pull request, #822:
URL: https://github.com/apache/lucene/pull/822
Currently "new FilterPath" is called from everywhere, making it impossible
for a mockfilesystem to use a custom subclass.
See JIRA for full description.
The use case here is to e.g. allow Wind
Robert Muir created LUCENE-10526:
Summary: add single method to mockfile to wrap a Path
Key: LUCENE-10526
URL: https://issues.apache.org/jira/browse/LUCENE-10526
Project: Lucene - Core
Issue
[
https://issues.apache.org/jira/browse/LUCENE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524662#comment-17524662
]
Tomoko Uchida commented on LUCENE-10524:
I think it is great to have good docum
[
https://issues.apache.org/jira/browse/LUCENE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524647#comment-17524647
]
Robert Muir commented on LUCENE-10525:
--
So the "real" windowsfilesystem fails in t
[
https://issues.apache.org/jira/browse/LUCENE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524644#comment-17524644
]
Robert Muir commented on LUCENE-10525:
--
good idea. there are quite a few banned ch
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103301886
OK, i cleaned up the messaging here to emit better messages so we don't lead
users through a maze of downloading and retrying. I didn't touch the gradle
checks. And yeah, it would be great to
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103286863
OK, @dweiss can you take another look when you get a chance?
java 8:
```
$ ./gradlew check
Unrecognized option: --source
Error: Could not create the Java Virtual Machine.
E
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103272545
> I agree with this (as someone who disables the daemon and runs the
commands every time). The only reason I specified it as a different command was
due to the fact that if the downloader fail
rmuir commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1103262627
no reason to rush it in, take some time to think about it. i do think the
change is worth the trouble though, reduce friction for new developers.
--
This is an automated message from the Apa
[
https://issues.apache.org/jira/browse/LUCENE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah updated LUCENE-10525:
--
Description:
In PR ([https://github.com/apache/lucene/pull/762)] we missed the case where a
Gautam Worah created LUCENE-10525:
-
Summary: Improve WindowsFS emulation to catch directory names with
: in them (which is not allowed)
Key: LUCENE-10525
URL: https://issues.apache.org/jira/browse/LUCENE-10525
Gautam Worah created LUCENE-10524:
-
Summary: Augment CONTRIBUTING.md guide with instructions on
how/when to benchmark
Key: LUCENE-10524
URL: https://issues.apache.org/jira/browse/LUCENE-10524
Project:
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524582#comment-17524582
]
Nhat Nguyen commented on LUCENE-10518:
--
[~mayya] That's correct. We only reduce th
rmuir commented on PR #807:
URL: https://github.com/apache/lucene/pull/807#issuecomment-1103079108
> I don't know, Mike... Gradle doesn't seem like a tool that you can ever
make dead-simple (like ant). I like what Robert added but with hacks like that
a question always pops to my mind of wh
dweiss commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1103022163
You can commit this in or leave this open for a day or two. I'm catching up
with work after a short holiday but maybe I can take a stab at this as a
breather.
--
This is an automated messa
dweiss commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103018456
> Maybe it could be in a .properties file? Not gradle, not groovy, a real
actual .properties file that we can read with java.io.Properties too?
I was thinking about something like this
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524548#comment-17524548
]
Mayya Sharipova edited comment on LUCENE-10518 at 4/19/22 7:17 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524548#comment-17524548
]
Mayya Sharipova edited comment on LUCENE-10518 at 4/19/22 7:16 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524548#comment-17524548
]
Mayya Sharipova edited comment on LUCENE-10518 at 4/19/22 7:15 PM:
--
rmuir commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1102998198
> Maybe it'd be better to create a single finalizer task (at the root
level), collect all the spotless tasks in the graph and add finalizedBy
pointing at that single task (it's still need to c
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524548#comment-17524548
]
Mayya Sharipova commented on LUCENE-10518:
--
[~dnhatn] [~jpountz] Thanks for y
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1102995607
> Yep. I wonder if we could do it in one script (the downloader?) to avoid
running java so many times but overall I think it's better than before. :)
I agree with this (as someone who di
dweiss commented on PR #807:
URL: https://github.com/apache/lucene/pull/807#issuecomment-1102961503
I don't know, Mike... Gradle doesn't seem like a tool that you can ever make
dead-simple (like ant). I like what Robert added but with hacks like that a
question always pops to my mind of wha
dweiss commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1102953991
This attaches to each and every spotless task (and would print a message for
all of them).
Maybe it'd be better to create a single finalizer task (at the root level),
collect all the
dweiss commented on PR #818:
URL: https://github.com/apache/lucene/pull/818#issuecomment-1102946084
> I wish we could fix ./gradlew to detect you are using an unsupported JDK
version and say so (exit with error/exception with a clear message).
I really don't understand why gradle does
dweiss commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1102943639
Yep. I wonder if we could do it in one script (the downloader?) to avoid
running java so many times but overall I think it's better than before. :)
This also reminds me that the various
[
https://issues.apache.org/jira/browse/LUCENE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524471#comment-17524471
]
Gautam Worah commented on LUCENE-10521:
---
Tests are passing now. Latest main build
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524409#comment-17524409
]
Nhat Nguyen commented on LUCENE-10518:
--
+1 to disable consistency checks for 8.x i
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524408#comment-17524408
]
Adrien Grand commented on LUCENE-10518:
---
I'm unsure of the value of the consisten
[
https://issues.apache.org/jira/browse/LUCENE-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova reassigned LUCENE-9848:
---
Assignee: Mayya Sharipova
> Correctly sort HNSW graph neighbors when applying diver
[
https://issues.apache.org/jira/browse/LUCENE-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524316#comment-17524316
]
ASF subversion and git services commented on LUCENE-10503:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524317#comment-17524317
]
ASF subversion and git services commented on LUCENE-10503:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524314#comment-17524314
]
Adrien Grand commented on LUCENE-10153:
---
Sorry for the noise, I pushed a commit t
mocobeta commented on PR #808:
URL: https://github.com/apache/lucene/pull/808#issuecomment-1102669627
I didn't know the figure, it's very simple and helpful, thanks! I'll read
the article next holidays.
> I have been capitalizing it ever since I learned it but I will try to
stop.
[
https://issues.apache.org/jira/browse/LUCENE-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10503.
---
Fix Version/s: 9.2
Resolution: Fixed
I mixed up the JIRA number in the commit messag
[
https://issues.apache.org/jira/browse/LUCENE-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10506.
---
Fix Version/s: 9.2
Resolution: Fixed
> ProfilerCollector to support customizing how
[
https://issues.apache.org/jira/browse/LUCENE-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524310#comment-17524310
]
ASF subversion and git services commented on LUCENE-10506:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524309#comment-17524309
]
ASF subversion and git services commented on LUCENE-10506:
--
Co
jpountz merged PR #799:
URL: https://github.com/apache/lucene/pull/799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated LUCENE-10523:
-
Description:
If the {{UnifiedHighlighter}} had a protected {{newFieldHighlighte
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524304#comment-17524304
]
ASF subversion and git services commented on LUCENE-10153:
--
Co
cpoerschke opened a new pull request, #821:
URL: https://github.com/apache/lucene/pull/821
https://issues.apache.org/jira/browse/LUCENE-10523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Christine Poerschke created LUCENE-10523:
Summary: facilitate UnifiedHighlighter extension w.r.t.
FieldHighlighter
Key: LUCENE-10523
URL: https://issues.apache.org/jira/browse/LUCENE-10523
Pro
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524302#comment-17524302
]
ASF subversion and git services commented on LUCENE-10153:
--
Co
jpountz merged PR #794:
URL: https://github.com/apache/lucene/pull/794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
mikemccand commented on PR #808:
URL: https://github.com/apache/lucene/pull/808#issuecomment-1102642347
> oh, I learned that wikipedia has an article on Shoshin (初心) for the first
time. It's a common noun in Japanese (and also in Chinese I think) so there are
no corresponding articles in th
cpoerschke opened a new pull request, #820:
URL: https://github.com/apache/lucene/pull/820
No JIRA ticket required for this change, in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mocobeta commented on PR #808:
URL: https://github.com/apache/lucene/pull/808#issuecomment-1102598934
oh, I learned that wikipedia has an article on Shoshin (初心) for the first
time. It's a common noun in Japanese (and also in Chinese I think) so there are
no corresponding articles in those
rmuir commented on PR #818:
URL: https://github.com/apache/lucene/pull/818#issuecomment-1102585523
> I wish we could fix `./gradlew` to detect you are using an unsupported JDK
version and say so (exit with error/exception with a clear message).
https://github.com/apache/lucene/pull/81
rmuir opened a new pull request, #819:
URL: https://github.com/apache/lucene/pull/819
Gradle will give a very confusing error, let's make it absolutely clear.
, this PR is
unlikely going to get merged.
--
This is an automated message from the Apache Git Service.
T
[
https://issues.apache.org/jira/browse/LUCENE-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524277#comment-17524277
]
Adrien Grand commented on LUCENE-10517:
---
Very impressive indeed. This makes me wo
rmuir opened a new pull request, #818:
URL: https://github.com/apache/lucene/pull/818
These instructions tell the user to install 17 (or greater), then run
`./gradlew`. This will not actually work if they install something greater than
java 17.
--
This is an automated message from the Ap
ssigut commented on PR #439:
URL: https://github.com/apache/lucene/pull/439#issuecomment-1102537548
Is this PR going to be merged? What release is this planned for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
[
https://issues.apache.org/jira/browse/LUCENE-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524262#comment-17524262
]
Michael McCandless commented on LUCENE-10517:
-
This is a very impressive pe
[
https://issues.apache.org/jira/browse/LUCENE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524258#comment-17524258
]
Michael McCandless commented on LUCENE-10521:
-
Phew! This time I put the {
[
https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524256#comment-17524256
]
ASF subversion and git services commented on LUCENE-10482:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524257#comment-17524257
]
ASF subversion and git services commented on LUCENE-10521:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524254#comment-17524254
]
ASF subversion and git services commented on LUCENE-10482:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524255#comment-17524255
]
ASF subversion and git services commented on LUCENE-10521:
--
Co
rmuir commented on code in PR #817:
URL: https://github.com/apache/lucene/pull/817#discussion_r852889508
##
gradle/validation/spotless.gradle:
##
@@ -111,3 +111,9 @@ configure(project(":lucene").subprojects) { prj ->
v.dependsOn ":checkJdkInternalsExportedToGradle"
}
}
[
https://issues.apache.org/jira/browse/LUCENE-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522838#comment-17522838
]
Chris Hegarty edited comment on LUCENE-10517 at 4/19/22 10:38 AM:
---
LuXugang commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1102336772
Result of dense case in Luceneutil's benchmark by running `python
src/python/localrun.py -source wikivector10k`:
LowTermVector 1493.52 (9.1%) 1457.88 (11.5%)
LuXugang commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1102297367
Thanks @jtibshirani @mayya-sharipova , Indeed, only dense case was coverd in
[luceneutil](https://github.com/mikemccand/luceneutil), so I write a
[demo](https://github.com/LuXugang/Lucene-7
[
https://issues.apache.org/jira/browse/LUCENE-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Alishevskikh updated LUCENE-10520:
---
Description:
If HTML input contains attributes with '<' or '>' characters in their
uschindler commented on code in PR #817:
URL: https://github.com/apache/lucene/pull/817#discussion_r852697178
##
gradle/validation/spotless.gradle:
##
@@ -111,3 +111,9 @@ configure(project(":lucene").subprojects) { prj ->
v.dependsOn ":checkJdkInternalsExportedToGradle"
68 matches
Mail list logo
