iverase commented on PR #756:
URL: https://github.com/apache/lucene/pull/756#issuecomment-1096194673
@yixunx if there is no further input I am planning to push this change
shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
[
https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10508.
---
Fix Version/s: 9.2
Assignee: Ignacio Vera
Resolution: Fixed
> GeoArea failu
[
https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520929#comment-17520929
]
ASF subversion and git services commented on LUCENE-10508:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520926#comment-17520926
]
ASF subversion and git services commented on LUCENE-10508:
--
Co
iverase merged PR #804:
URL: https://github.com/apache/lucene/pull/804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
mocobeta commented on PR #808:
URL: https://github.com/apache/lucene/pull/808#issuecomment-1096056476
Elaborating CONTRIBUTING.md might be good, on the other hand, we also makes
it wordy and increase the maintenance cost (I know few people care about it,
then it'd easily become out-of-date)
dweiss commented on PR #808:
URL: https://github.com/apache/lucene/pull/808#issuecomment-1095406753
I allowed myself to push minor changes to your branch, including what @rmuir
suggested, which indeed seems like an omission.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/LUCENE-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rich Bowen resolved LUCENE-10512.
-
Resolution: Fixed
Thank you, folks. PR merged, and much learned about the process and tooling
rmuir commented on PR #808:
URL: https://github.com/apache/lucene/pull/808#issuecomment-1095247184
Thanks for following up here! These changes look fine. I'm wondering if
there's anything we could improve in the CONTRIBUTING.md to make this easier,
too, maybe something in "checks" section.
[
https://issues.apache.org/jira/browse/LUCENE-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520651#comment-17520651
]
Rich Bowen commented on LUCENE-10513:
-
Thanks. [https://github.com/apache/lucene/pu
rbowen opened a new pull request, #808:
URL: https://github.com/apache/lucene/pull/808
Encourage running `gradlew tidy` first, which, in turn, prevents failures in
later steps.
# Description
In contributing my first change, I encountered formatting advice that would
have been
dweiss commented on PR #807:
URL: https://github.com/apache/lucene/pull/807#issuecomment-1095199898
bq. Since the Spotless check seems to be fail-fast, maybe we should fix the
exception message to just suggest ./gradlew tidy instead?
Gradle runs tasks in parallel so it's not really "f
[
https://issues.apache.org/jira/browse/LUCENE-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520643#comment-17520643
]
Dawid Weiss commented on LUCENE-10513:
--
Perhaps you could add a line to:
[https:/
[
https://issues.apache.org/jira/browse/LUCENE-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520641#comment-17520641
]
Dawid Weiss commented on LUCENE-10513:
--
You should make yourself familiar with var
[
https://issues.apache.org/jira/browse/LUCENE-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520638#comment-17520638
]
ASF subversion and git services commented on LUCENE-10512:
--
Co
mikemccand merged PR #807:
URL: https://github.com/apache/lucene/pull/807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
Rich Bowen created LUCENE-10513:
---
Summary: Make it more obvious how to fix Spotless issues for new
users
Key: LUCENE-10513
URL: https://issues.apache.org/jira/browse/LUCENE-10513
Project: Lucene - Core
mikemccand commented on PR #807:
URL: https://github.com/apache/lucene/pull/807#issuecomment-1095144308
> > You should be able to re-style your code automatically by running
`./gradlew :lucene:core:spotlessApply`
>
> Personally I would not recommend running it this way. I run `./gradl
rmuir commented on PR #807:
URL: https://github.com/apache/lucene/pull/807#issuecomment-1095141887
> You should be able to re-style your code automatically by running
`./gradlew :lucene:core:spotlessApply`
Personally I would not recommend running it this way. I run `./gradlew
tidy`,
[
https://issues.apache.org/jira/browse/LUCENE-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520603#comment-17520603
]
Rich Bowen commented on LUCENE-10512:
-
[https://github.com/apache/lucene/pull/807]
mikemccand commented on PR #807:
URL: https://github.com/apache/lucene/pull/807#issuecomment-109589
That CI build failure is a code styling issue. Lucene uses a [strict
code-styling plugin called
Spotless](https://issues.apache.org/jira/browse/LUCENE-9564), which removes all
ambiguity
mikemccand commented on PR #807:
URL: https://github.com/apache/lucene/pull/807#issuecomment-1095108824
Whoa, thanks @rbowen for the attention to detail! This reminds me of the
world's hardest band for search engines to find: [The
The](https://en.wikipedia.org/wiki/The_The).
--
This is
rbowen opened a new pull request, #807:
URL: https://github.com/apache/lucene/pull/807
# Description
Identify and fix "the the" repeated words in comments/docs.
# Solution
Purely cosmetic/grammar: Remove/replace "the the" in comments, documentation.
# Tests
Rich Bowen created LUCENE-10512:
---
Summary: Trivial: Identify and fix "the the" in comments, docs
Key: LUCENE-10512
URL: https://issues.apache.org/jira/browse/LUCENE-10512
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520560#comment-17520560
]
Michael Sokolov commented on LUCENE-9269:
-
# Does the checkBoosts test case you
mocobeta commented on PR #805:
URL: https://github.com/apache/lucene/pull/805#issuecomment-1094989501
I took the same bottom-up approach as
https://issues.apache.org/jira/browse/LUCENE-10393 here again (determine the
duplicate code and sort out the interfaces).
I'll look through this aga
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520524#comment-17520524
]
Ignacio Vera commented on LUCENE-10315:
---
I think adding BulkAdder#add(int[] docs,
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520523#comment-17520523
]
Ignacio Vera commented on LUCENE-10315:
---
> I'm seeing readInts24ForUtil runs 3 ti
DaddyWri commented on PR #804:
URL: https://github.com/apache/lucene/pull/804#issuecomment-1094949367
As you suggest, it is essential that the limits of the resolution of planes
be taken into account when building structures in Geo3D. This change looks
like it would possibly do a better jo
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520487#comment-17520487
]
ASF subversion and git services commented on LUCENE-10229:
--
Co
iverase commented on PR #804:
URL: https://github.com/apache/lucene/pull/804#issuecomment-1094868606
@DaddyWri would you be able to have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10229:
-
Priority: Minor (was: Major)
> Match offsets should be consistent for fields with positions an
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned LUCENE-10229:
Assignee: Dawid Weiss
> Match offsets should be consistent for fields with positions and
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10229:
-
Fix Version/s: 9.2
> Match offsets should be consistent for fields with positions and fields wi
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520468#comment-17520468
]
ASF subversion and git services commented on LUCENE-10229:
--
Co
dweiss merged PR #803:
URL: https://github.com/apache/lucene/pull/803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.o
Lu Xugang created LUCENE-10511:
--
Summary: IntersectIterators is not necessary under matchAll case
in Facet
Key: LUCENE-10511
URL: https://issues.apache.org/jira/browse/LUCENE-10511
Project: Lucene - Core
37 matches
Mail list logo
