vigyasharma commented on a change in pull request #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r830568703
##
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##
@@ -567,6 +605,21 @@ public abstract MergeSpecification findMerges(
Vigya Sharma created LUCENE-10476:
-
Summary: Modify the findMerges policy for
addIndexes(CodecReader[]) to create 1 segment per reader
Key: LUCENE-10476
URL: https://issues.apache.org/jira/browse/LUCENE-10476
vigyasharma commented on a change in pull request #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r830568250
##
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##
@@ -813,12 +866,24 @@ protected final boolean verbose(MergeContext
mergeC
[
https://issues.apache.org/jira/browse/LUCENE-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509385#comment-17509385
]
Vigya Sharma commented on LUCENE-8580:
--
I started looking into this, and had some e
[
https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509384#comment-17509384
]
Vigya Sharma commented on LUCENE-10216:
---
While making this change, I found an exi
[
https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509383#comment-17509383
]
Vigya Sharma commented on LUCENE-10216:
---
Updated the PR to retain transactionalit
vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1073177695
Thanks @mikemccand . I figured that I had changed the exception signature
for addIndexes() in my last revision. I was throwing a blanket
MergePolicyException when addIndexes f
vigyasharma commented on pull request #738:
URL: https://github.com/apache/lucene/pull/738#issuecomment-1073176564
> Since a release candidate is out for testing, I'll wait until that process
completes before merging this. It would be safe anyway, and this is small, but
just in case there
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509380#comment-17509380
]
Vigya Sharma commented on LUCENE-10448:
---
{color:#172b4d}Thanks for making the cha
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509380#comment-17509380
]
Vigya Sharma edited comment on LUCENE-10448 at 3/20/22, 6:11 AM:
mocobeta edited a comment on pull request #755:
URL: https://github.com/apache/lucene/pull/755#issuecomment-1073174420
My `tmpfs` partition (where system `/tmp` is mounted) has 8GB of available
disk space.
The test itself has been there for a long time and I think I had not seen
this "d
mocobeta commented on pull request #755:
URL: https://github.com/apache/lucene/pull/755#issuecomment-1073174420
My `tmpfs` partition (where system `/tmp` is mounted) has 8GB of available
disk space.
The test itself has been there for a long time and I think I had not seen
this "disk ful
[
https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509373#comment-17509373
]
ASF subversion and git services commented on LUCENE-9905:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509371#comment-17509371
]
ASF subversion and git services commented on LUCENE-9905:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509368#comment-17509368
]
ASF subversion and git services commented on LUCENE-9905:
-
Commi
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r830539688
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/sortedset/TestSortedSetDocValuesFacets.java
##
@@ -1221,6 +1326,12 @@ public void testRandomHiera
Yuti-G commented on pull request #747:
URL: https://github.com/apache/lucene/pull/747#issuecomment-1073132559
> I didn't really have a lot of real feedback, just minor nits here and
there. I did want to say that I have a PR out for a benchmark that compares the
faceting API performance for
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r830539916
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -411,7 +484,109 @@ public int compare(FacetRes
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r830539828
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -411,7 +484,109 @@ public int compare(FacetRes
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r830539760
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -114,7 +116,7 @@ public FacetResult getTopChil
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r830539688
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/sortedset/TestSortedSetDocValuesFacets.java
##
@@ -1221,6 +1326,12 @@ public void testRandomHiera
msokolov commented on pull request #755:
URL: https://github.com/apache/lucene/pull/755#issuecomment-1073041616
Big plus one for this. I can never complete the smoke test without it and I
always forget the parameter name and where it has to go on the command
line. I don't think it can
mocobeta opened a new pull request #755:
URL: https://github.com/apache/lucene/pull/755
I encountered several times a "disk full" error when running the smoke
tester.
From my observation, there is a test that (intentionally) creates very large
index files. It might be helpful to have a
uschindler edited a comment on pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1072980556
I am not sure about the consequences for scripts, but this variant should be
fine. The spec version inside jar files stays with version base so the
compatibility
uschindler commented on pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1072980556
I am not sure about the consequences for scripts, but this variant should be
fine. The spec version inside jar files stays with version base so the
compatibility is ensu
uschindler commented on a change in pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#discussion_r830460575
##
File path: lucene/common-build.xml
##
@@ -63,7 +63,7 @@
-
+
Review comment:
At least there must be a `\b`
uschindler commented on a change in pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#discussion_r830460575
##
File path: lucene/common-build.xml
##
@@ -63,7 +63,7 @@
-
+
Review comment:
At least there must be a `\b`
uschindler commented on a change in pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#discussion_r830460575
##
File path: lucene/common-build.xml
##
@@ -63,7 +63,7 @@
-
+
Review comment:
At least there must be a `\b`
mdmarshmallow commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r830444294
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -114,7 +116,7 @@ public FacetResult get
29 matches
Mail list logo
