[GitHub] [lucene] vigyasharma commented on pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

vigyasharma commented on pull request #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1036989788 The `addIndexes(CodecReaders[])` API is transactional in nature - either all readers get added or all of them fail. Retaining this behavior with concurrent background merges n

[GitHub] [lucene] gautamworah96 commented on a change in pull request #658: LUCENE-10378 Implement Weight#count for PointRangeQuery

gautamworah96 commented on a change in pull request #658: URL: https://github.com/apache/lucene/pull/658#discussion_r805112108 ## File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java ## @@ -369,6 +378,100 @@ public Scorer scorer(LeafReaderContext contex

[GitHub] [lucene] msokolov commented on a change in pull request #676: Lucene-10176: Remove VectorValues#size()

msokolov commented on a change in pull request #676: URL: https://github.com/apache/lucene/pull/676#discussion_r804844197 ## File path: lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java ## @@ -929,6 +931,17 @@ private void add(

[GitHub] [lucene] msokolov commented on a change in pull request #676: Lucene-10176: Remove VectorValues#size()

msokolov commented on a change in pull request #676: URL: https://github.com/apache/lucene/pull/676#discussion_r804842543 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -38,15 +38,6 @@ protected VectorValues() {} /** Return the dimension o

[GitHub] [lucene] uschindler commented on pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on pull request #673: URL: https://github.com/apache/lucene/pull/673#issuecomment-1036218874 I will just commit some changes in thanks for starting the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [lucene] mocobeta commented on pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

mocobeta commented on pull request #673: URL: https://github.com/apache/lucene/pull/673#issuecomment-1036212423 @uschindler Thanks for your review, I have to leave but will be back next week and refine this. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene] uschindler commented on pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on pull request #673: URL: https://github.com/apache/lucene/pull/673#issuecomment-1036164896 Hi, I would make the still missing changes, because the deprecation is a bit tricky and hard to explain. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804604627 ## File path: lucene/core/src/java/org/apache/lucene/util/IOConsumer.java ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804603025 ## File path: lucene/core/src/java/org/apache/lucene/util/IOConsumer.java ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] mocobeta commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

mocobeta commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804576732 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) thr

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804540458 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804539288 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804539288 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804527726 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804526911 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804523983 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804516322 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804516322 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r804516322 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t