gf2121 opened a new pull request #653:
URL: https://github.com/apache/lucene/pull/653
CHANGES entry was missed in https://github.com/apache/lucene/pull/541.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
gf2121 opened a new pull request #652:
URL: https://github.com/apache/lucene/pull/652
Backport of https://github.com/apache/lucene/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487919#comment-17487919
]
ASF subversion and git services commented on LUCENE-10315:
--
Co
gf2121 merged pull request #541:
URL: https://github.com/apache/lucene/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10405.
---
Fix Version/s: 9.1
Assignee: Ignacio Vera
Resolution: Fixed
> MemoryIndex:
[
https://issues.apache.org/jira/browse/LUCENE-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487896#comment-17487896
]
ASF subversion and git services commented on LUCENE-10405:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487895#comment-17487895
]
ASF subversion and git services commented on LUCENE-10405:
--
Co
iverase merged pull request #647:
URL: https://github.com/apache/lucene/pull/647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
uschindler commented on a change in pull request #643:
URL: https://github.com/apache/lucene/pull/643#discussion_r800200763
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java
##
@@ -38,21 +44,73 @@
* @param resourceS
gsmiller merged pull request #651:
URL: https://github.com/apache/lucene/pull/651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
gsmiller commented on pull request #651:
URL: https://github.com/apache/lucene/pull/651#issuecomment-1030861399
Ah, great! Thanks @mocobeta and @dweiss. I had cherry-picked this over in
#644 as well but was having trouble getting the checks to actually run. Maybe
there was a github delay i
mocobeta commented on a change in pull request #643:
URL: https://github.com/apache/lucene/pull/643#discussion_r800197929
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java
##
@@ -38,21 +44,73 @@
* @param resourceSch
uschindler edited a comment on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1030835988
> > The try...catch posted above is bad code anyways. Better use finally
blocks to ensure something is executed for sure.
>
> I know it can be written differen
uschindler edited a comment on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1030835988
> > The try...catch posted above is bad code anyways. Better use finally
blocks to ensure something is executed for sure.
>
> I know it can be written differen
uschindler commented on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1030835988
> > The try...catch posted above is bad code anyways. Better use finally
blocks to ensure something is executed for sure.
>
> I know it can be written differently, bu
dweiss commented on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1030826955
> The try...catch posted above is bad code anyways. Better use finally
blocks to ensure something is executed for sure.
I know it can be written differently, but that's n
mocobeta commented on a change in pull request #643:
URL: https://github.com/apache/lucene/pull/643#discussion_r800166250
##
File path:
lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseTokenizer.java
##
@@ -491,6 +491,7 @@ public void testUserDict3()
uschindler commented on a change in pull request #643:
URL: https://github.com/apache/lucene/pull/643#discussion_r800164098
##
File path:
lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseTokenizer.java
##
@@ -491,6 +491,7 @@ public void testUserDict3
uschindler edited a comment on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1030807558
> This isn't exactly right - it is legal bytecode but it isn't exactly
playing well with the language.
Hi @dweiss: Let's not discuss this here, the whole thing do
uschindler edited a comment on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1030807558
> This isn't exactly right - it is legal bytecode but it isn't exactly
playing well with the language.
Hi @dweiss: Let's not discuss this here, the whole thing do
uschindler commented on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1030807558
> This isn't exactly right - it is legal bytecode but it isn't exactly
playing well with the language.
Hi @dweiss: Let's not discuss this here, the whole thing does not
mocobeta commented on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1030807427
Assuming this is close to being ready for merge, I'm going to prepare a
changes entry for 9.1 (for deprecated APIs with removal.) Once this is
backported I will open another pull
dweiss commented on pull request #651:
URL: https://github.com/apache/lucene/pull/651#issuecomment-1030772672
> Or, it could be better to have only one large CI workflow that executes
all checks/tests just like we do so in the Jenkins servers, instead of multiple
ones.
This workflow
23 matches
Mail list logo
