[jira] [Assigned] (LUCENE-10036) Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

2021-07-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller reassigned LUCENE-10036: Assignee: Greg Miller > Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap ano

[jira] [Commented] (LUCENE-10036) Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

2021-07-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387629#comment-17387629 ] Greg Miller commented on LUCENE-10036: -- PRs open to make this change main/9.0 as w

[jira] [Updated] (LUCENE-10036) Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

2021-07-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-10036: - Lucene Fields: New,Patch Available (was: New) > Ensure ScoreCachingWrappingScorer doesn't unne

[jira] [Updated] (LUCENE-10036) Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

2021-07-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-10036: - Affects Version/s: 8.10 > Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another

[GitHub] [lucene] gsmiller opened a new pull request #226: LUCENE-10036: Add factory method to ScoreCachingWrappingScorer that ensures unnecessary wrapping doesn't occur

2021-07-26 Thread GitBox
gsmiller opened a new pull request #226: URL: https://github.com/apache/lucene/pull/226 # Description Current users of `ScoreCachingWrappingScorer` must do their own instancetype checks if they want to avoid unnecessarily wrapping an existing `ScoreCachingWrappingScorer` instance. T

[GitHub] [lucene-solr] gsmiller opened a new pull request #2534: LUCENE-10036: Add factory method to ScoreCachingWrappingScorer that ensures unnecessary wrapping doesn't occur

2021-07-26 Thread GitBox
gsmiller opened a new pull request #2534: URL: https://github.com/apache/lucene-solr/pull/2534 Backport from `lucene/main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (LUCENE-10010) Should we have a NFA Query?

2021-07-26 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387626#comment-17387626 ] Haoyu Zhai commented on LUCENE-10010: - Here's a WIP PR: https://github.com/apache/l

[GitHub] [lucene] zhaih opened a new pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-07-26 Thread GitBox
zhaih opened a new pull request #225: URL: https://github.com/apache/lucene/pull/225 # Description https://issues.apache.org/jira/browse/LUCENE-10010 Introduces `NFARunAutomaton` to run NFA directly Works to to: 1. Integrate with current `RunAutomaton` cla

[jira] [Created] (LUCENE-10036) Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

2021-07-26 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10036: Summary: Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer Key: LUCENE-10036 URL: https://issues.apache.org/jira/browse/LUCENE-10036

[jira] [Commented] (LUCENE-10030) [DrillSidewaysScorer] redundant score() calculations in doQueryFirstScoring

2021-07-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387611#comment-17387611 ] ASF subversion and git services commented on LUCENE-10030: -- Co

[jira] [Commented] (LUCENE-10030) [DrillSidewaysScorer] redundant score() calculations in doQueryFirstScoring

2021-07-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387607#comment-17387607 ] Greg Miller commented on LUCENE-10030: -- Thanks again for taking this up [~gtroitsk

[jira] [Commented] (LUCENE-10030) [DrillSidewaysScorer] redundant score() calculations in doQueryFirstScoring

2021-07-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387605#comment-17387605 ] ASF subversion and git services commented on LUCENE-10030: -- Co

[GitHub] [lucene] gsmiller commented on pull request #217: LUCENE-10030: [DrillSidewaysScorer.doQueryFirstScoring] disable scoring for near-miss hits

2021-07-26 Thread GitBox
gsmiller commented on pull request #217: URL: https://github.com/apache/lucene/pull/217#issuecomment-886989427 Thanks again @gtroitskiy ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [lucene] gsmiller merged pull request #217: LUCENE-10030: [DrillSidewaysScorer.doQueryFirstScoring] disable scoring for near-miss hits

2021-07-26 Thread GitBox
gsmiller merged pull request #217: URL: https://github.com/apache/lucene/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] mikemccand commented on a change in pull request #220: LUCENE-9450: Use BinaryDocValue fields with a different name in the taxonomy index

2021-07-26 Thread GitBox
mikemccand commented on a change in pull request #220: URL: https://github.com/apache/lucene/pull/220#discussion_r676902852 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java ## @@ -475,8 +476,20 @@ private int addCatego

[GitHub] [lucene] gsmiller commented on a change in pull request #217: LUCENE-10030: [DrillSidewaysScorer.doQueryFirstScoring] disable scoring for near-miss hits

2021-07-26 Thread GitBox
gsmiller commented on a change in pull request #217: URL: https://github.com/apache/lucene/pull/217#discussion_r676894541 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java ## @@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits acceptDo

[GitHub] [lucene] gtroitskiy commented on a change in pull request #217: LUCENE-10030: [DrillSidewaysScorer.doQueryFirstScoring] disable scoring for near-miss hits

2021-07-26 Thread GitBox
gtroitskiy commented on a change in pull request #217: URL: https://github.com/apache/lucene/pull/217#discussion_r676888240 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java ## @@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits accept

[jira] [Commented] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

2021-07-26 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387588#comment-17387588 ] Gautam Worah commented on LUCENE-9450: -- Posted a new PR revision that implements th

[GitHub] [lucene] gautamworah96 commented on pull request #220: LUCENE-9450: Use BinaryDocValue fields with a different name in the taxonomy index

2021-07-26 Thread GitBox
gautamworah96 commented on pull request #220: URL: https://github.com/apache/lucene/pull/220#issuecomment-886968851 Changes in the new b9cbc4c commit: 1. The reason why the `SegmentInfos.readLatestCommit(dir).getMinSegmentLuceneVersion()` call was returning 9 as the version, was tha

[GitHub] [lucene] gsmiller commented on a change in pull request #217: LUCENE-10030: [DrillSidewaysScorer.doQueryFirstScoring] disable scoring for near-miss hits

2021-07-26 Thread GitBox
gsmiller commented on a change in pull request #217: URL: https://github.com/apache/lucene/pull/217#discussion_r676879074 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java ## @@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits acceptDo

[GitHub] [lucene] gtroitskiy commented on a change in pull request #217: LUCENE-10030: [DrillSidewaysScorer.doQueryFirstScoring] disable scoring for near-miss hits

2021-07-26 Thread GitBox
gtroitskiy commented on a change in pull request #217: URL: https://github.com/apache/lucene/pull/217#discussion_r676822527 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java ## @@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits accept