[GitHub] [lucene] dweiss commented on a change in pull request #215: LUCENE-10028: Add git pre-commit hook that runs precommit task.

2021-07-17 Thread GitBox
dweiss commented on a change in pull request #215: URL: https://github.com/apache/lucene/pull/215#discussion_r671789348 ## File path: dev-tools/git/hooks/pre-commit ## @@ -0,0 +1,7 @@ +#!/usr/bin/sh +# +# Run precommit check +# + +## TODO: Windows support Review comment:

[jira] [Commented] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-07-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382588#comment-17382588 ] ASF subversion and git services commented on LUCENE-10016: -- Co

[GitHub] [lucene] msokolov merged pull request #210: LUCENE-10016: remove fanout parameter from nearest neighbor vector search

2021-07-17 Thread GitBox
msokolov merged pull request #210: URL: https://github.com/apache/lucene/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] msokolov commented on pull request #210: LUCENE-10016: remove fanout parameter from nearest neighbor vector search

2021-07-17 Thread GitBox
msokolov commented on pull request #210: URL: https://github.com/apache/lucene/pull/210#issuecomment-881912928 OK! Thanks for the discussion. We can always revisit when we have an actual need for a parameter. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit

2021-07-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382564#comment-17382564 ] Tomoko Uchida commented on LUCENE-10028: I opened a draft PR to provide a worki

[jira] [Updated] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit

2021-07-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10028: --- Description: With [githooks|https://git-scm.com/docs/githooks], one can automatically perf

[jira] [Updated] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit

2021-07-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10028: --- Description: With [githooks|https://git-scm.com/docs/githooks], one can automatically perf

[GitHub] [lucene] mocobeta opened a new pull request #215: LUCENE-10028: Add git pre-commit hook that runs precommit task.

2021-07-17 Thread GitBox
mocobeta opened a new pull request #215: URL: https://github.com/apache/lucene/pull/215 This adds git pre-commit hook for Lucene precommit check. (Usage) Install pre-commit hook (opt-in) ``` ./gradlew precommitHook ``` After installing, precommit will be automat

[jira] [Updated] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit

2021-07-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10028: --- Description: With [githooks|https://git-scm.com/docs/githooks], one can automatically perf

[jira] [Created] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit

2021-07-17 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-10028: -- Summary: Optionally allow to enable git pre-commit hook for precommit Key: LUCENE-10028 URL: https://issues.apache.org/jira/browse/LUCENE-10028 Project: Lucene -