[jira] [Commented] (LUCENE-9204) Move span queries to the queries module

2021-06-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366383#comment-17366383 ] David Smiley commented on LUCENE-9204: -- Nice work Michael G! bq. baseline and can

[GitHub] [lucene] dsmiley commented on a change in pull request #180: LUCENE-9959: Add non thread local based API for term vector reader usage

2021-06-20 Thread GitBox
dsmiley commented on a change in pull request #180: URL: https://github.com/apache/lucene/pull/180#discussion_r655070117 ## File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java ## @@ -112,10 +112,29 @@ protected BaseCompositeReader(R[] subReaders, C

[GitHub] [lucene] dsmiley commented on pull request #180: LUCENE-9959: Add non thread local based API for term vector reader usage

2021-06-20 Thread GitBox
dsmiley commented on pull request #180: URL: https://github.com/apache/lucene/pull/180#issuecomment-864720190 > If I understanding the above correctly, eventually we would like to also have TermVectors to be similar to Fields, and act like the abstraction API for term vectors index data an

[GitHub] [lucene] dsmiley commented on a change in pull request #180: LUCENE-9959: Add non thread local based API for term vector reader usage

2021-06-20 Thread GitBox
dsmiley commented on a change in pull request #180: URL: https://github.com/apache/lucene/pull/180#discussion_r655067190 ## File path: lucene/core/src/java/org/apache/lucene/index/TermVectors.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[jira] [Resolved] (LUCENE-9143) Add more static analysis and clean up resulting warnings/errors

2021-06-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-9143. -- Resolution: Fixed Resolving. We can and are already doing this incrementally. I don't think