[GitHub] [lucene] mocobeta commented on pull request #90: LUCENE-9353: revise format documentation of Lucene90BlockTreeTermsWriter

2021-04-17 Thread GitBox
mocobeta commented on pull request #90: URL: https://github.com/apache/lucene/pull/90#issuecomment-821911241 @jpountz Could you take a look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-04-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324302#comment-17324302 ] David Smiley commented on LUCENE-9836: -- I'm a bit confused what's going away. Woul

[GitHub] [lucene] neoremind opened a new pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-04-17 Thread GitBox
neoremind opened a new pull request #91: URL: https://github.com/apache/lucene/pull/91 https://issues.apache.org/jira/browse/LUCENE-9932 # Description In BKD index building, the input bytes must be sorted before calling BKD writer related API. The sorting method leverages MSB

[jira] [Updated] (LUCENE-9932) Performance improvement for BKD index building

2021-04-17 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] neoremind updated LUCENE-9932: -- Attachment: benchmark_data.png Description: In BKD index building, the input bytes must be sorted

[jira] [Created] (LUCENE-9932) Performance improvement for BKD index building

2021-04-17 Thread neoremind (Jira)
neoremind created LUCENE-9932: - Summary: Performance improvement for BKD index building Key: LUCENE-9932 URL: https://issues.apache.org/jira/browse/LUCENE-9932 Project: Lucene - Core Issue Type:

[GitHub] [lucene] mocobeta opened a new pull request #90: LUCENE-9353: revise format documentation of Lucene90BlockTreeTermsWriter

2021-04-17 Thread GitBox
mocobeta opened a new pull request #90: URL: https://github.com/apache/lucene/pull/90 It seems that the javadocs needs to be revised. I've tried to reflect the changes in https://github.com/apache/lucene-solr/pull/1473 to the format description. **generated javadocs with the patch**

[GitHub] [lucene] jpountz commented on a change in pull request #85: LUCENE-9907: Make MonotonicBlockPackedReader/writer depend on DirectReader/writer

2021-04-17 Thread GitBox
jpountz commented on a change in pull request #85: URL: https://github.com/apache/lucene/pull/85#discussion_r615246017 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/MonotonicBlockPackedReader.java ## @@ -72,24 +75,44 @@ private MonotonicBlockPackedReader(

[GitHub] [lucene] iverase commented on pull request #85: LUCENE-9907: Make MonotonicBlockPackedReader/writer depend on DirectReader/writer

2021-04-17 Thread GitBox
iverase commented on pull request #85: URL: https://github.com/apache/lucene/pull/85#issuecomment-821781482 Thanks @jpountz, I did not realise about that constraint. I took a different approach: Similarly to `Packed64`, I read the data into a backing byte array and implement a get me