[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-01 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313509#comment-17313509 ] Julie Tibshirani commented on LUCENE-9855: -- To me it seems best to avoid tying

[GitHub] [lucene] jpountz commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-04-01 Thread GitBox
jpountz commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r605809392 ## File path: lucene/core/src/test/org/apache/lucene/document/TestPerFieldConsistency.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene] jtibshirani commented on a change in pull request #59: LUCENE-9705: Move all test classes under lucene90 package

2021-04-01 Thread GitBox
jtibshirani commented on a change in pull request #59: URL: https://github.com/apache/lucene/pull/59#discussion_r605784161 ## File path: lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90LiveDocsFormat.java ## @@ -14,7 +14,7 @@ * See the License for the spec

[GitHub] [lucene] mocobeta merged pull request #58: Ignore sdkmanrc file on Git

2021-04-01 Thread GitBox
mocobeta merged pull request #58: URL: https://github.com/apache/lucene/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [lucene] jpountz commented on pull request #11: LUCENE-9334 Consistency of field data structures

2021-04-01 Thread GitBox
jpountz commented on pull request #11: URL: https://github.com/apache/lucene/pull/11#issuecomment-811987053 Thanks @mayya-sharipova for the benchmark. The overhead looks very reasonable to me, I don't think it should be a reason not to proceed with this change. -- This is an automated m

[GitHub] [lucene-solr] bruno-roustant merged pull request #2472: SOLR-15217: Use shardsWhitelist in ReplicationHandler.

2021-04-01 Thread GitBox
bruno-roustant merged pull request #2472: URL: https://github.com/apache/lucene-solr/pull/2472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #11: LUCENE-9334 Consistency of field data structures

2021-04-01 Thread GitBox
mayya-sharipova edited a comment on pull request #11: URL: https://github.com/apache/lucene/pull/11#issuecomment-805296177 I've run indexing benchmarking using [luceneutil](https://github.com/mikemccand/luceneutil). And here are the results: - indexing time in ms - baseline: mast

[jira] [Updated] (LUCENE-9897) Use gradle's built-in artifact checksum verification

2021-04-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9897: Parent: (was: LUCENE-9871) Issue Type: Task (was: Sub-task) > Use gradle's built-in a

[jira] [Resolved] (LUCENE-9868) Verify checksums on generated files

2021-04-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9868. - Resolution: Duplicate > Verify checksums on generated files > --

[jira] [Commented] (LUCENE-9872) Make the most painful tasks in regenerate fully incremental

2021-04-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313129#comment-17313129 ] Dawid Weiss commented on LUCENE-9872: - I filed a pull request. Getting this right (a

[GitHub] [lucene] dweiss opened a new pull request #60: LUCENE-9872: Make the most painful tasks in regenerate fully incremental

2021-04-01 Thread GitBox
dweiss opened a new pull request #60: URL: https://github.com/apache/lucene/pull/60 This also adds persistence of checksums and checksum validation for selected generation tasks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [lucene] mocobeta commented on pull request #56: LUCENE-9883: Turn on ecj missingEnumCaseDespiteDefault setting

2021-04-01 Thread GitBox
mocobeta commented on pull request #56: URL: https://github.com/apache/lucene/pull/56#issuecomment-811843729 OK, it doesn't seem to be a fun job anyway; let's leave it as it is and please turn your efforts towards things you feel more enjoyable or beneficial, @zacharymorn :) -- This i

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2479: SOLR-15288 Replicas stay DOWN after a new node is restarted when using the same directory

2021-04-01 Thread GitBox
noblepaul commented on a change in pull request #2479: URL: https://github.com/apache/lucene-solr/pull/2479#discussion_r605514906 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientTest.java ## @@ -1099,7 +1102,7 @@ public void testPerReplicaSta

[GitHub] [lucene] iverase opened a new pull request #59: LUCENE-9705: Move all test classes under lucene90 package

2021-04-01 Thread GitBox
iverase opened a new pull request #59: URL: https://github.com/apache/lucene/pull/59 This PR moves three test classes under the lucene90 package and add an entry in CHANGES.txt. With this we can close the issue. -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (LUCENE-9899) Numeric DV block compression ignores the gcd when computing the number of bits required

2021-04-01 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313041#comment-17313041 ] Adrien Grand commented on LUCENE-9899: -- We have a test for GCD compression in {{Ba

[jira] [Commented] (LUCENE-9850) Explore PFOR for Doc ID delta encoding (instead of FOR)

2021-04-01 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313013#comment-17313013 ] Adrien Grand commented on LUCENE-9850: -- I'm looking forward to JDK17 being out so t