[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2306: SOLR-15121: Move XSLT (tr param) to scripting contrib

dsmiley commented on a change in pull request #2306: URL: https://github.com/apache/lucene-solr/pull/2306#discussion_r571376095 ## File path: solr/contrib/scripting/src/java/org/apache/solr/scripting/util/xslt/XSLTLoader.java ## @@ -0,0 +1,534 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2306: SOLR-15121: Move XSLT (tr param) to scripting contrib

dsmiley commented on a change in pull request #2306: URL: https://github.com/apache/lucene-solr/pull/2306#discussion_r571375991 ## File path: solr/contrib/scripting/src/java/org/apache/solr/scripting/util/xslt/XSLTLoader.java ## @@ -0,0 +1,534 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2306: SOLR-15121: Move XSLT (tr param) to scripting contrib

dsmiley commented on a change in pull request #2306: URL: https://github.com/apache/lucene-solr/pull/2306#discussion_r571368100 ## File path: solr/contrib/scripting/src/java/org/apache/solr/scripting/response/package-info.java ## @@ -0,0 +1,21 @@ +/* + * Licensed to the Apache

[jira] [Commented] (SOLR-7913) Add stream.body support to MLT QParser

[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280064#comment-17280064 ] Isabelle Giguere commented on SOLR-7913: Patch on release tag lucene-solr 8.7.0: S

[jira] [Commented] (SOLR-15133) Document how to eliminate Failed to reserve shared memory warning

[ https://issues.apache.org/jira/browse/SOLR-15133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280063#comment-17280063 ] Shawn Heisey commented on SOLR-15133: - I wish I understood the benefits and disadvant

[jira] [Created] (SOLR-15140) Avoid insuffcient key size when creating keyPair

Ying Zhang created SOLR-15140: - Summary: Avoid insuffcient key size when creating keyPair Key: SOLR-15140 URL: https://issues.apache.org/jira/browse/SOLR-15140 Project: Solr Issue Type: Improveme

[jira] [Updated] (SOLR-7913) Add stream.body support to MLT QParser

[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-7913: --- Attachment: SOLR-7913_tag_lucene-solr-8.7.0.patch > Add stream.body support to MLT QParser > -

[jira] [Commented] (SOLR-15133) Document how to eliminate Failed to reserve shared memory warning

[ https://issues.apache.org/jira/browse/SOLR-15133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280033#comment-17280033 ] Mike Drob commented on SOLR-15133: -- The origin seems to be from [~elyograg]'s wiki page,

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2306: SOLR-15121: Move XSLT (tr param) to scripting contrib

muse-dev[bot] commented on a change in pull request #2306: URL: https://github.com/apache/lucene-solr/pull/2306#discussion_r571294563 ## File path: solr/contrib/scripting/src/java/org/apache/solr/scripting/util/xslt/XSLTLoader.java ## @@ -0,0 +1,534 @@ +/* + * Licensed to the

[GitHub] [lucene-solr-sandbox] anshumg commented on pull request #2: Setup gradle for sandbox root

anshumg commented on pull request #2: URL: https://github.com/apache/lucene-solr-sandbox/pull/2#issuecomment-774324833 Thank you @madrob This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [lucene-solr-sandbox] anshumg merged pull request #2: Setup gradle for sandbox root

anshumg merged pull request #2: URL: https://github.com/apache/lucene-solr-sandbox/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-15127) All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags

[ https://issues.apache.org/jira/browse/SOLR-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280023#comment-17280023 ] Houston Putman commented on SOLR-15127: --- I think having a conditional RUN in the Do

[jira] [Commented] (SOLR-15121) Move XSLT (tr param) to scripting contrib

[ https://issues.apache.org/jira/browse/SOLR-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280014#comment-17280014 ] David Eric Pugh commented on SOLR-15121: First cut is DONE!   The one thing I am

[GitHub] [lucene-solr-sandbox] anshumg commented on pull request #2: Setup gradle for sandbox root

anshumg commented on pull request #2: URL: https://github.com/apache/lucene-solr-sandbox/pull/2#issuecomment-774300094 I've also updated the Gradle wrappers to bring in the fixes from lucene-solr. This is an automated message

[GitHub] [lucene-solr-sandbox] madrob commented on pull request #2: Setup gradle for sandbox root

madrob commented on pull request #2: URL: https://github.com/apache/lucene-solr-sandbox/pull/2#issuecomment-774289125 On second thought, since we don't know what/how we're going to be releasing from here, let's not worry about it until we need to. -

[GitHub] [lucene-solr] madrob commented on pull request #2309: SOLR-14301: Remove external commons-codec usage in gradle validateJarChecksums

madrob commented on pull request #2309: URL: https://github.com/apache/lucene-solr/pull/2309#issuecomment-774283250 I _believe_ this was done with an external dependency because there's an issue with how checksums were handled on Windows, but I don't remember all the details and can't find

[GitHub] [lucene-solr-sandbox] anshumg commented on pull request #2: Setup gradle for sandbox root

anshumg commented on pull request #2: URL: https://github.com/apache/lucene-solr-sandbox/pull/2#issuecomment-774281078 @madrob - let me just copy them over right now in that case? This is an automated message from the Apache

[GitHub] [lucene-solr-sandbox] madrob commented on pull request #2: Setup gradle for sandbox root

madrob commented on pull request #2: URL: https://github.com/apache/lucene-solr-sandbox/pull/2#issuecomment-774278374 It's fine to check in the jar for now, but we should instead copy the modified gradlew scripts that we have on lucene-solr. There's a few extra workarounds in there - LUCEN

[jira] [Resolved] (SOLR-15123) bin/solr tools all have different styles of describing command opitons

[ https://issues.apache.org/jira/browse/SOLR-15123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh resolved SOLR-15123. Fix Version/s: 8.9 Resolution: Fixed > bin/solr tools all have different styles of d

[jira] [Commented] (SOLR-15123) bin/solr tools all have different styles of describing command opitons

[ https://issues.apache.org/jira/browse/SOLR-15123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279971#comment-17279971 ] ASF subversion and git services commented on SOLR-15123: Commit 5

[GitHub] [lucene-solr] epugh merged pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

epugh merged pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene-solr] jtibshirani commented on pull request #2310: LUCENE-9705: Create Lucene90PostingsFormat

jtibshirani commented on pull request #2310: URL: https://github.com/apache/lucene-solr/pull/2310#issuecomment-774254300 I also plan to copy over the blocktree dependencies like `BlockTreeTermsWriter`. Any thoughts on naming or package structure for these classes? In [LUCENE-9616](https://

[GitHub] [lucene-solr-sandbox] anshumg opened a new pull request #2: Setup gradle for sandbox root

anshumg opened a new pull request #2: URL: https://github.com/apache/lucene-solr-sandbox/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene-solr] jtibshirani opened a new pull request #2310: LUCENE-9705: Create Lucene90PostingsFormat

jtibshirani opened a new pull request #2310: URL: https://github.com/apache/lucene-solr/pull/2310 For now this is just a copy of Lucene90PostingsFormat. The existing Lucene84PostingsFormat was moved to backwards-codecs, along with its utility classes.

[GitHub] [lucene-solr-sandbox] anshumg merged pull request #1: Create .asf.yaml

anshumg merged pull request #1: URL: https://github.com/apache/lucene-solr-sandbox/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr-operator] HoustonPutman closed pull request #207: docs: removing step in local tutorial for collection creation

HoustonPutman closed pull request #207: URL: https://github.com/apache/lucene-solr-operator/pull/207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #207: docs: removing step in local tutorial for collection creation

HoustonPutman commented on pull request #207: URL: https://github.com/apache/lucene-solr-operator/pull/207#issuecomment-774221538 Instead, I changed the instructions to use the Collections API to create the collection. That way users have a better understanding of how to interact with the

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Description: The *nodes* Streaming Expression performs a breadth first graph traversal. This t

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Description: The *nodes* Streaming Expression performs a breadth first graph traversal. This t

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Description: The *nodes* Streaming Expression performs a breadth first graph traversal. This t

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Description: The *nodes* Streaming Expression performs a breadth first graph traversal. This t

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Description: The *nodes* Streaming Expression performs a breadth first graph traversal. This t

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Description: The *nodes* Streaming Expression performs a breadth first graph traversal. This t

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Description: The *nodes* Streaming Expression performs a breadth first graph traversal. This t

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Description: The *nodes* Streaming Expression performs a breadth first graph traversal. This t

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Description: The *nodes* Streaming Expression performs a breadth first graph traversal. This t

[GitHub] [lucene-solr] epugh commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

epugh commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r571018503 ## File path: solr/core/src/java/org/apache/solr/util/PackageTool.java ## @@ -261,44 +261,44 @@ protected void runImpl(CommandLine cli) throws Exception

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2302: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted D…

bruno-roustant commented on pull request #2302: URL: https://github.com/apache/lucene-solr/pull/2302#issuecomment-773991718 @msokolov I confirm it is backward compatible, not thanks to TestDocValuesCompression#testMergeWithUncompressedSegment() but thanks to TestBackwardsCompatibility.test

[jira] [Created] (LUCENE-9735) Hunspell: speed up flag checks by avoiding allocations

Peter Gromov created LUCENE-9735: Summary: Hunspell: speed up flag checks by avoiding allocations Key: LUCENE-9735 URL: https://issues.apache.org/jira/browse/LUCENE-9735 Project: Lucene - Core

[GitHub] [lucene-solr] asalamon74 opened a new pull request #2309: SOLR-14301: Remove external commons-codec usage in gradle validateJarChecksums

asalamon74 opened a new pull request #2309: URL: https://github.com/apache/lucene-solr/pull/2309 …Checksums # Description Right now gradle calculates SHA-1 checksums using an external commons-codec library. We can calculate SHA-1 using Java 8 classes, no need for c

[jira] [Comment Edited] (SOLR-15139) Recovering forever after upgrade to 8.8.0: Timeout waiting for collection state

[ https://issues.apache.org/jira/browse/SOLR-15139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279628#comment-17279628 ] Henrik edited comment on SOLR-15139 at 2/5/21, 11:04 AM: - It seem

[jira] [Comment Edited] (SOLR-15139) Recovering forever after upgrade to 8.8.0: Timeout waiting for collection state

[ https://issues.apache.org/jira/browse/SOLR-15139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279628#comment-17279628 ] Henrik edited comment on SOLR-15139 at 2/5/21, 11:03 AM: - It seem

[jira] [Resolved] (SOLR-15139) Recovering forever after upgrade to 8.8.0: Timeout waiting for collection state

[ https://issues.apache.org/jira/browse/SOLR-15139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrik resolved SOLR-15139. --- Resolution: Workaround It seems I had too agressive settings for my timeouts. Things started working when I

[GitHub] [lucene-solr] dweiss merged pull request #2301: LUCENE-9732: Hunspell: support dictionary entries starting with slash

dweiss merged pull request #2301: URL: https://github.com/apache/lucene-solr/pull/2301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] noblepaul commented on pull request #2281: SOLR-15118: Convert /v2/collections APIs to annotations

noblepaul commented on pull request #2281: URL: https://github.com/apache/lucene-solr/pull/2281#issuecomment-773232908 Thanks for picking this up @gerlowskija Please let me know if you need any help This is an automat

[GitHub] [lucene-solr] jaisonbi commented on a change in pull request #2302: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted D…

jaisonbi commented on a change in pull request #2302: URL: https://github.com/apache/lucene-solr/pull/2302#discussion_r570670271 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -43,11 +43,7 @@ import org.apache.lucene.

[GitHub] [lucene-solr] jaisonbi edited a comment on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

jaisonbi edited a comment on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-772993254 Thanks for the detailed suggestion:) @bruno-roustant Will add a **new custom codec** to support compression or un-compression mode. I name it as "Lucene90Ex

[jira] [Resolved] (LUCENE-9732) Hunspell: support dictionary entries starting with slash

[ https://issues.apache.org/jira/browse/LUCENE-9732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9732. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: support dictionary entries star

[GitHub] [lucene-solr] donnerpeter closed pull request #2283: LUCENE-9719: Resource files aren't deleted from build directory after…

donnerpeter closed pull request #2283: URL: https://github.com/apache/lucene-solr/pull/2283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] gerlowskija edited a comment on pull request #2281: SOLR-15118: Convert /v2/collections APIs to annotations

gerlowskija edited a comment on pull request #2281: URL: https://github.com/apache/lucene-solr/pull/2281#issuecomment-773515236 Hey, thanks for offering @noblepaul . I do have one thing I was puzzling over: How is SolrJ's `getV2Request`/`V2RequestSupport` feature intended to work

[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #2281: SOLR-15118: Convert /v2/collections APIs to annotations

gerlowskija commented on a change in pull request #2281: URL: https://github.com/apache/lucene-solr/pull/2281#discussion_r570282351 ## File path: solr/core/src/java/org/apache/solr/handler/CollectionsAPI.java ## @@ -50,11 +81,144 @@ public void getCollections(SolrQueryRequest r

[GitHub] [lucene-solr] murblanc commented on pull request #2285: SOLR-14928: introduce distributed cluster state updates

murblanc commented on pull request #2285: URL: https://github.com/apache/lucene-solr/pull/2285#issuecomment-773661420 > Is not possible to make this a per collection feature? like the per-replica state feauture? Given Zookeeper content is identical for Overseer based and distributed

[GitHub] [lucene-solr] dweiss merged pull request #2300: LUCENE-9729: Hunspell: support CHECKCOMPOUNDREP flags

dweiss merged pull request #2300: URL: https://github.com/apache/lucene-solr/pull/2300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] epugh commented on pull request #2306: SOLR-15121: Move XSLT (tr param) to scripting contrib

epugh commented on pull request #2306: URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-773656218 I still have a broken test, and need to update docs. This is an automated message from the Apache Git Service.

[jira] [Commented] (LUCENE-9732) Hunspell: support dictionary entries starting with slash

[ https://issues.apache.org/jira/browse/LUCENE-9732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279594#comment-17279594 ] ASF subversion and git services commented on LUCENE-9732: - Commi

[GitHub] [lucene-solr] msokolov commented on pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader

msokolov commented on pull request #2303: URL: https://github.com/apache/lucene-solr/pull/2303#issuecomment-773529165 I like Lucene's randomized tests too! But they didn't find this one. Since it requires a 2GB index to detect, it only turned up in the context of Anton's version of "nightl

[GitHub] [lucene-solr] dweiss commented on pull request #2283: LUCENE-9719: Resource files aren't deleted from build directory after…

dweiss commented on pull request #2283: URL: https://github.com/apache/lucene-solr/pull/2283#issuecomment-773300099 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [lucene-solr] jpountz commented on a change in pull request #2293: LUCENE-9725: Allow BM25FQuery to use other similarities.

jpountz commented on a change in pull request #2293: URL: https://github.com/apache/lucene-solr/pull/2293#discussion_r570044511 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java ## @@ -64,39 +62,35 @@ * A {@link Query} that treats

[GitHub] [lucene-solr] msokolov merged pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader

msokolov merged pull request #2303: URL: https://github.com/apache/lucene-solr/pull/2303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2283: LUCENE-9719: Resource files aren't deleted from build directory after…

donnerpeter commented on a change in pull request #2283: URL: https://github.com/apache/lucene-solr/pull/2283#discussion_r570083701 ## File path: gradle/ant-compat/folder-layout.gradle ## @@ -25,11 +25,15 @@ allprojects { test.resources.srcDirs = ['src/test-files']

[GitHub] [lucene-solr] gerlowskija commented on pull request #2281: SOLR-15118: Convert /v2/collections APIs to annotations

gerlowskija commented on pull request #2281: URL: https://github.com/apache/lucene-solr/pull/2281#issuecomment-773515236 Hey, thanks for offering @noblepaul . I do have one thing I was puzzling over: How is SolrJ's `getV2Request`/`V2RequestSupport` feature intended to work for ann

[GitHub] [lucene-solr] gerlowskija merged pull request #2250: SOLR-13608: Incremental backup file format

gerlowskija merged pull request #2250: URL: https://github.com/apache/lucene-solr/pull/2250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] jaisonbi closed pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

jaisonbi closed pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] dweiss commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

dweiss commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-773476961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2301: LUCENE-9732: Hunspell: support dictionary entries starting with slash

donnerpeter commented on a change in pull request #2301: URL: https://github.com/apache/lucene-solr/pull/2301#discussion_r570807970 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordCase.java ## @@ -53,14 +54,19 @@ static WordCase caseOf(Cha

[GitHub] [lucene-solr] epugh commented on pull request #2304: SOLR-15133: Document how to eliminate Failed to reserve shared memory warning

epugh commented on pull request #2304: URL: https://github.com/apache/lucene-solr/pull/2304#issuecomment-773428402 @ctargett I'd love a quick review of the copy editing I did... This is an automated message from the Apache

[GitHub] [lucene-solr] jpountz commented on a change in pull request #2268: LUCENE-9705: Move Lucene50CompoundFormat to Lucene90CompoundFormat

jpountz commented on a change in pull request #2268: URL: https://github.com/apache/lucene-solr/pull/2268#discussion_r570105057 ## File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestLucene50CompoundFormat.java ## @@ -0,0 +1,30 @@ +/* + *

[GitHub] [lucene-solr] donnerpeter commented on pull request #2283: LUCENE-9719: Resource files aren't deleted from build directory after…

donnerpeter commented on pull request #2283: URL: https://github.com/apache/lucene-solr/pull/2283#issuecomment-773304025 Thanks for the explanation! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

HoustonPutman commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r570372810 ## File path: solr/core/src/java/org/apache/solr/util/PackageTool.java ## @@ -261,44 +261,44 @@ protected void runImpl(CommandLine cli) throws E

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2300: LUCENE-9729: Hunspell: support CHECKCOMPOUNDREP flags

donnerpeter commented on a change in pull request #2300: URL: https://github.com/apache/lucene-solr/pull/2300#discussion_r570086999 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/CheckCompoundPattern.java ## @@ -38,36 +38,33 @@ }

[GitHub] [lucene-solr] epugh commented on pull request #2250: SOLR-13608: Incremental backup file format

epugh commented on pull request #2250: URL: https://github.com/apache/lucene-solr/pull/2250#issuecomment-773319812 I looked for some deprecated tags in the source to convey that the old approach is deprecated, and while there is some text, I don't see any of the `@deprecated` tags. The n

[GitHub] [lucene-solr] asalamon74 commented on pull request #2252: SOLR-15111: Use JDK8 Base64 instead of own implementation

asalamon74 commented on pull request #2252: URL: https://github.com/apache/lucene-solr/pull/2252#issuecomment-773249710 We also used a different way for String conversion, I modified the lines. This is an automated message fr

[GitHub] [lucene-solr] donnerpeter commented on pull request #2296: LUCENE-9728: Hunspell: add a performance test

donnerpeter commented on pull request #2296: URL: https://github.com/apache/lucene-solr/pull/2296#issuecomment-773887234 `Dictionary` changes are intended, because the test parses the corpus based on the affix file `WORDCHARS` directive, which is parsed together with the other directives i

[GitHub] [lucene-solr] jpountz commented on a change in pull request #2274: LUCENE-9705: Create Lucene90LiveDocsFormat

jpountz commented on a change in pull request #2274: URL: https://github.com/apache/lucene-solr/pull/2274#discussion_r570062574 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/Lucene50LiveDocsFormat.java ## @@ -0,0 +1,170 @@ +/* + * Lic

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2301: LUCENE-9732: Hunspell: support dictionary entries starting with slash

dweiss commented on a change in pull request #2301: URL: https://github.com/apache/lucene-solr/pull/2301#discussion_r570805734 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordCase.java ## @@ -53,14 +54,19 @@ static WordCase caseOf(CharSequ

[GitHub] [lucene-solr] dweiss commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

dweiss commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-773880886 I'll commit this patch in and create a separate issue for improving it later. This is an automated messag

[GitHub] [lucene-solr] jtibshirani merged pull request #2274: LUCENE-9705: Create Lucene90LiveDocsFormat

jtibshirani merged pull request #2274: URL: https://github.com/apache/lucene-solr/pull/2274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] mikemccand commented on pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader

mikemccand commented on pull request #2303: URL: https://github.com/apache/lucene-solr/pull/2303#issuecomment-773533648 > I like Lucene's randomized tests too! But they didn't find this one. Since it requires a 2GB index to detect, it only turned up in the context of Anton's version of "ni

[GitHub] [lucene-solr] noblepaul commented on pull request #2285: SOLR-14928: introduce distributed cluster state updates

noblepaul commented on pull request #2285: URL: https://github.com/apache/lucene-solr/pull/2285#issuecomment-773236842 Is not possible to make this a per collection feature? like the per-replica state feauture? This is an au

[GitHub] [lucene-solr] dweiss commented on pull request #2296: LUCENE-9728: Hunspell: add a performance test

dweiss commented on pull request #2296: URL: https://github.com/apache/lucene-solr/pull/2296#issuecomment-773883740 Should this be rebased? Seems to contain unrelated changes not just the test file. A JMH test would probably strip some of the boilerplate but don't know if it's worth pullin

[GitHub] [lucene-solr] jaisonbi commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

jaisonbi commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-773179495 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2268: LUCENE-9705: Move Lucene50CompoundFormat to Lucene90CompoundFormat

jtibshirani commented on a change in pull request #2268: URL: https://github.com/apache/lucene-solr/pull/2268#discussion_r570454164 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/Lucene50CompoundFormat.java ## @@ -0,0 +1,88 @@ +/* + *

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #209: Basic TLS Support

HoustonPutman commented on a change in pull request #209: URL: https://github.com/apache/lucene-solr-operator/pull/209#discussion_r570530780 ## File path: controllers/solrcloud_controller.go ## @@ -381,7 +436,7 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctr

[GitHub] [lucene-solr] janhoy merged pull request #2279: Split the publish_maven step in two TODOs

janhoy merged pull request #2279: URL: https://github.com/apache/lucene-solr/pull/2279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] ctargett commented on pull request #2304: SOLR-15133: Document how to eliminate Failed to reserve shared memory warning

ctargett commented on pull request #2304: URL: https://github.com/apache/lucene-solr/pull/2304#issuecomment-773450876 Sorry, don't have time to review today I don't think - go ahead if Houston thinks it's good to merge. This

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2293: LUCENE-9725: Allow BM25FQuery to use other similarities.

jtibshirani commented on a change in pull request #2293: URL: https://github.com/apache/lucene-solr/pull/2293#discussion_r570517621 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java ## @@ -64,39 +62,35 @@ * A {@link Query} that tr

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

mayya-sharipova commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r570454676 ## File path: lucene/core/src/java/org/apache/lucene/index/StandardDirectoryReader.java ## @@ -39,33 +40,44 @@ final IndexWriter writer;

[GitHub] [lucene-solr] jaisonbi edited a comment on pull request #2302: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted D…

jaisonbi edited a comment on pull request #2302: URL: https://github.com/apache/lucene-solr/pull/2302#issuecomment-77375 > It looks to me as if when compression is not enabled, the index format is unchanged, so this should be backwards-compatible. Is that correct? Correct.

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

bruno-roustant commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-773199705 @jaisonbi I didn't want to close this PR. I wanted to merge the first part related to LZ4 compression, and let you push a PR on another jira issue with the remaining

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2281: SOLR-15118: Convert /v2/collections APIs to annotations

noblepaul commented on a change in pull request #2281: URL: https://github.com/apache/lucene-solr/pull/2281#discussion_r570150592 ## File path: solr/core/src/java/org/apache/solr/handler/CollectionsAPI.java ## @@ -36,7 +58,16 @@ */ public class CollectionsAPI { - private

[GitHub] [lucene-solr] dweiss merged pull request #2296: LUCENE-9728: Hunspell: add a performance test

dweiss merged pull request #2296: URL: https://github.com/apache/lucene-solr/pull/2296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (LUCENE-9734) Hunspell: support suggestions based on "ph" morphological data

Peter Gromov created LUCENE-9734: Summary: Hunspell: support suggestions based on "ph" morphological data Key: LUCENE-9734 URL: https://issues.apache.org/jira/browse/LUCENE-9734 Project: Lucene - Core

[GitHub] [lucene-solr] epugh commented on a change in pull request #2275: SOLR-15123: Make all Tool option descriptions follow the same general pattern.

epugh commented on a change in pull request #2275: URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r570365526 ## File path: solr/core/src/java/org/apache/solr/util/ExportTool.java ## @@ -216,32 +216,32 @@ void end() throws IOException { Option.builder("ur

[GitHub] [lucene-solr] jtibshirani commented on pull request #2293: LUCENE-9725: Allow BM25FQuery to use other similarities.

jtibshirani commented on pull request #2293: URL: https://github.com/apache/lucene-solr/pull/2293#issuecomment-773581613 Thanks @jpountz and @jimczi for reviewing. This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] sigram commented on a change in pull request #2281: SOLR-15118: Convert /v2/collections APIs to annotations

sigram commented on a change in pull request #2281: URL: https://github.com/apache/lucene-solr/pull/2281#discussion_r570133109 ## File path: solr/core/src/java/org/apache/solr/handler/CollectionsAPI.java ## @@ -50,11 +81,144 @@ public void getCollections(SolrQueryRequest req,

[GitHub] [lucene-solr] jaisonbi commented on pull request #2302: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted D…

jaisonbi commented on pull request #2302: URL: https://github.com/apache/lucene-solr/pull/2302#issuecomment-773326313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene-solr] jtibshirani merged pull request #2293: LUCENE-9725: Allow BM25FQuery to use other similarities.

jtibshirani merged pull request #2293: URL: https://github.com/apache/lucene-solr/pull/2293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] epugh merged pull request #2304: SOLR-15133: Document how to eliminate Failed to reserve shared memory warning

epugh merged pull request #2304: URL: https://github.com/apache/lucene-solr/pull/2304 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene-solr] dweiss merged pull request #2295: LUCENE-9726: Hunspell: speed up spellchecking by stopping at a single…

dweiss merged pull request #2295: URL: https://github.com/apache/lucene-solr/pull/2295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2302: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted D…

msokolov commented on a change in pull request #2302: URL: https://github.com/apache/lucene-solr/pull/2302#discussion_r570467210 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -43,11 +43,7 @@ import org.apache.lucene.

  1   2   >