[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-12-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248302#comment-17248302 ] David Smiley commented on SOLR-14923: - Hey, nice PR! It's not as hacky as I feared i

[jira] [Updated] (SOLR-15029) More gracefully allow Shard Leader to give up leadership

2020-12-11 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-15029: - Fix Version/s: master (9.0) 8.8 > More gracefully allow Shard Leader to give up leader

[jira] [Comment Edited] (SOLR-15029) More gracefully allow Shard Leader to give up leadership

2020-12-11 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248250#comment-17248250 ] Mike Drob edited comment on SOLR-15029 at 12/11/20, 11:40 PM: -

[jira] [Commented] (SOLR-15029) More gracefully allow Shard Leader to give up leadership

2020-12-11 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248250#comment-17248250 ] Mike Drob commented on SOLR-15029: -- Without further comment, I will plan to commit this

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-12-11 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248237#comment-17248237 ] Thomas Wöckinger commented on SOLR-14923: - [~dsmiley] I have run some performance

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2120: SOLR-15029 More gracefully give up shard leadership

2020-12-11 Thread GitBox
muse-dev[bot] commented on a change in pull request #2120: URL: https://github.com/apache/lucene-solr/pull/2120#discussion_r541316136 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -692,55 +718,44 @@ public void close() { /** * Best effort

[jira] [Commented] (SOLR-14792) Remove VelocityResponseWriter from Solr 9

2020-12-11 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248193#comment-17248193 ] David Eric Pugh commented on SOLR-14792: [~ehatcher] do you think this issue is c

[jira] [Created] (SOLR-15044) Update JSON syntax: detect nested documents via schema

2020-12-11 Thread David Smiley (Jira)
David Smiley created SOLR-15044: --- Summary: Update JSON syntax: detect nested documents via schema Key: SOLR-15044 URL: https://issues.apache.org/jira/browse/SOLR-15044 Project: Solr Issue Type:

[jira] [Commented] (SOLR-14788) Solr: The Next Big Thing

2020-12-11 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248164#comment-17248164 ] Mark Robert Miller commented on SOLR-14788: --- Okay, today marks what I will call

[GitHub] [lucene-solr] madrob commented on a change in pull request #2120: SOLR-15029 More gracefully give up shard leadership

2020-12-11 Thread GitBox
madrob commented on a change in pull request #2120: URL: https://github.com/apache/lucene-solr/pull/2120#discussion_r541219690 ## File path: solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java ## @@ -1306,7 +1306,7 @@ private static void forceLeaderElectio

[GitHub] [lucene-solr] madrob commented on a change in pull request #2120: SOLR-15029 More gracefully give up shard leadership

2020-12-11 Thread GitBox
madrob commented on a change in pull request #2120: URL: https://github.com/apache/lucene-solr/pull/2120#discussion_r541218852 ## File path: solr/core/src/java/org/apache/solr/util/TestInjection.java ## @@ -337,6 +342,39 @@ public static boolean injectFailUpdateRequests() {

[jira] [Updated] (SOLR-15037) config update listener reloads solr core while schema is changed

2020-12-11 Thread Tiziano Degaetano (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tiziano Degaetano updated SOLR-15037: - Security: (was: Public) > config update listener reloads solr core while schema is ch

[jira] [Comment Edited] (LUCENE-9621) pendingNumDocs doesn't match totalMaxDoc if tragedy on flush()

2020-12-11 Thread Michael Froh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248133#comment-17248133 ] Michael Froh edited comment on LUCENE-9621 at 12/11/20, 7:21 PM: -

[jira] [Commented] (LUCENE-9621) pendingNumDocs doesn't match totalMaxDoc if tragedy on flush()

2020-12-11 Thread Michael Froh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248133#comment-17248133 ] Michael Froh commented on LUCENE-9621: -- Regarding the assertion failure, it looks l

[jira] [Commented] (LUCENE-9634) Highlighting of degenerate spans on fields *with offsets* doesn't work properly

2020-12-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248125#comment-17248125 ] Dawid Weiss commented on LUCENE-9634: - I don't know how to fix this one so leaving i

[jira] [Resolved] (LUCENE-9633) Improve match highlighter behavior for degenerate intervals (on non-existing positions)

2020-12-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9633. - Resolution: Fixed > Improve match highlighter behavior for degenerate intervals (on non-existing

[jira] [Commented] (LUCENE-9633) Improve match highlighter behavior for degenerate intervals (on non-existing positions)

2020-12-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248124#comment-17248124 ] ASF subversion and git services commented on LUCENE-9633: - Commi

[GitHub] [lucene-solr] dweiss merged pull request #2127: LUCENE-9633: Improve match highlighter behavior for degenerate intervals

2020-12-11 Thread GitBox
dweiss merged pull request #2127: URL: https://github.com/apache/lucene-solr/pull/2127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (SOLR-15043) Add more type safety to noggit

2020-12-11 Thread Mike Drob (Jira)
Mike Drob created SOLR-15043: Summary: Add more type safety to noggit Key: SOLR-15043 URL: https://issues.apache.org/jira/browse/SOLR-15043 Project: Solr Issue Type: Task Security Level: Pu

[jira] [Created] (SOLR-15042) Provide API to get current index writer without throwing IOException

2020-12-11 Thread Mike Drob (Jira)
Mike Drob created SOLR-15042: Summary: Provide API to get current index writer without throwing IOException Key: SOLR-15042 URL: https://issues.apache.org/jira/browse/SOLR-15042 Project: Solr Is

[jira] [Comment Edited] (LUCENE-9621) pendingNumDocs doesn't match totalMaxDoc if tragedy on flush()

2020-12-11 Thread Michael Froh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248119#comment-17248119 ] Michael Froh edited comment on LUCENE-9621 at 12/11/20, 6:55 PM: -

[jira] [Commented] (LUCENE-9621) pendingNumDocs doesn't match totalMaxDoc if tragedy on flush()

2020-12-11 Thread Michael Froh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248119#comment-17248119 ] Michael Froh commented on LUCENE-9621: -- I added a {{printStackTrace}} to {{onTragic

[jira] [Commented] (SOLR-14792) Remove VelocityResponseWriter from Solr 9

2020-12-11 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248099#comment-17248099 ] David Eric Pugh commented on SOLR-14792: Definitely not arguing the usefulness of

[jira] [Commented] (SOLR-14792) Remove VelocityResponseWriter from Solr 9

2020-12-11 Thread Walter Underwood (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248095#comment-17248095 ] Walter Underwood commented on SOLR-14792: - Some of the things we add to the Veloc

[jira] [Commented] (SOLR-14792) Remove VelocityResponseWriter from Solr 9

2020-12-11 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248089#comment-17248089 ] David Eric Pugh commented on SOLR-14792: It is still available, just install it a

[GitHub] [lucene-solr] madrob commented on pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-11 Thread GitBox
madrob commented on pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118#issuecomment-743349014 > Can you give me a hint where I can add such test (and maybe find some inspiration from existing tests)? You can add a test to https://github.com/apache/lucene-solr/b

[GitHub] [lucene-solr] vonbox commented on a change in pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-11 Thread GitBox
vonbox commented on a change in pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118#discussion_r541134314 ## File path: solr/core/src/java/org/apache/solr/search/FunctionQParser.java ## @@ -361,7 +361,9 @@ protected ValueSource parseValueSource(int flags) t

[jira] [Updated] (SOLR-10732) potential optimizations in callers of SolrIndexSearcher.numDocs when docset is empty

2020-12-11 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney updated SOLR-10732: -- Attachment: SOLR-10732.patch > potential optimizations in callers of SolrIndexSearcher.numDocs

[jira] [Updated] (SOLR-10732) potential optimizations in callers of SolrIndexSearcher.numDocs when docset is empty

2020-12-11 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney updated SOLR-10732: -- Attachment: SOLR-10732.patch > potential optimizations in callers of SolrIndexSearcher.numDocs

[jira] [Commented] (SOLR-14792) Remove VelocityResponseWriter from Solr 9

2020-12-11 Thread Walter Underwood (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248075#comment-17248075 ] Walter Underwood commented on SOLR-14792: - This is the first I saw about this, un

[jira] [Commented] (SOLR-10732) potential optimizations in callers of SolrIndexSearcher.numDocs when docset is empty

2020-12-11 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248077#comment-17248077 ] Michael Gibney commented on SOLR-10732: --- Thanks, [~munendrasn], that makes sense. I

[jira] [Updated] (SOLR-10732) potential optimizations in callers of SolrIndexSearcher.numDocs when docset is empty

2020-12-11 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney updated SOLR-10732: -- Attachment: (was: SOLR-10732.patch) > potential optimizations in callers of SolrIndexSearch

[jira] [Commented] (LUCENE-9621) pendingNumDocs doesn't match totalMaxDoc if tragedy on flush()

2020-12-11 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247965#comment-17247965 ] Simon Willnauer commented on LUCENE-9621: - do we have a stacktrace of the OOM as

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-12-11 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247908#comment-17247908 ] Thomas Wöckinger commented on SOLR-14923: - [~dsmiley] A first solution, created a

[GitHub] [lucene-solr] thomaswoeckinger opened a new pull request #2142: SOLR-14923: Reload RealtimeSearcher on next getInputDocument if forced

2020-12-11 Thread GitBox
thomaswoeckinger opened a new pull request #2142: URL: https://github.com/apache/lucene-solr/pull/2142 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-12-11 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247865#comment-17247865 ] Thomas Wöckinger commented on SOLR-14923: - [~dsmiley] I started to investigate on

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-12-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247738#comment-17247738 ] Dawid Weiss commented on LUCENE-9564: - I'm sorry - I remember about this but didn't