iverase opened a new pull request #2109:
URL: https://github.com/apache/lucene-solr/pull/2109
Refactor of codec classes to separate reading header/footer from reading
content of the file.
In addition the `Lucene50FieldInfosFormat` class is removed as it is not
used in the codebase.
Ignacio Vera created LUCENE-9627:
Summary: Small refactor of codec classes
Key: LUCENE-9627
URL: https://issues.apache.org/jira/browse/LUCENE-9627
Project: Lucene - Core
Issue Type: Wish
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r533044192
##
File path:
lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java
##
@@ -745,7 +745,7 @@ public synchronized IndexIn
[
https://issues.apache.org/jira/browse/SOLR-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241170#comment-17241170
]
ASF subversion and git services commented on SOLR-15009:
Commit b
msokolov opened a new pull request #2108:
URL: https://github.com/apache/lucene-solr/pull/2108
The subject line is the main thrust, but there are a few subsidiary changes
that were needed in order to achieve that (see below), and I made a few
incidental improvements to HNSW-related classes
cammiemw commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r532933758
##
File path: lucene/core/src/java/org/apache/lucene/search/IndriScorer.java
##
@@ -0,0 +1,37 @@
+package org.apache.lucene.search;
+
+import java.io
cammiemw commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r532927287
##
File path: lucene/core/src/java/org/apache/lucene/search/IndriAndScorer.java
##
@@ -0,0 +1,59 @@
+package org.apache.lucene.search;
+
+import java
[
https://issues.apache.org/jira/browse/SOLR-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter resolved SOLR-14958.
---
Fix Version/s: master (9.0)
8.8
Resolution: Fixed
> zkHost
cammiemw commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r532908661
##
File path:
lucene/core/src/java/org/apache/lucene/search/similarities/IndriDirichletSimilarity.java
##
@@ -0,0 +1,108 @@
+/*
+ *
===
cammiemw commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r532907950
##
File path: lucene/core/src/java/org/apache/lucene/search/Scorable.java
##
@@ -30,6 +30,13 @@
* Returns the score of the current document match
cammiemw commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r532905390
##
File path: lucene/core/src/java/org/apache/lucene/search/IndriAndScorer.java
##
@@ -0,0 +1,59 @@
+package org.apache.lucene.search;
+
+import java
cammiemw commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r532905253
##
File path: lucene/core/src/java/org/apache/lucene/search/IndriAndQuery.java
##
@@ -0,0 +1,22 @@
+package org.apache.lucene.search;
Review comment
cammiemw commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r532905011
##
File path: lucene/core/src/java/org/apache/lucene/search/IndriAndQuery.java
##
@@ -0,0 +1,22 @@
+package org.apache.lucene.search;
+
+import java.
madrob closed pull request #2092:
URL: https://github.com/apache/lucene-solr/pull/2092
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241012#comment-17241012
]
ASF subversion and git services commented on SOLR-14958:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-14289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241013#comment-17241013
]
ASF subversion and git services commented on SOLR-14289:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240984#comment-17240984
]
ASF subversion and git services commented on SOLR-12182:
Commit a
thelabdude merged pull request #2010:
URL: https://github.com/apache/lucene-solr/pull/2010
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
thelabdude commented on pull request #2010:
URL: https://github.com/apache/lucene-solr/pull/2010#issuecomment-735976873
thank you for the review @noblepaul and @anshumg ... going to merge to
master now.
This is an automated
[
https://issues.apache.org/jira/browse/SOLR-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-15009.
--
Fix Version/s: master (9.0)
8.8
Assignee: Mike Drob
Resolution: Fixed
[
https://issues.apache.org/jira/browse/SOLR-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240959#comment-17240959
]
ASF subversion and git services commented on SOLR-15009:
Commit c
madrob commented on pull request #2092:
URL: https://github.com/apache/lucene-solr/pull/2092#issuecomment-735961986
Committed in cb5ba42bd7d9777eaf76705f17a3407fd2897b10
This is an automated message from the Apache Git Servic
[
https://issues.apache.org/jira/browse/SOLR-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240960#comment-17240960
]
ASF subversion and git services commented on SOLR-15009:
Commit 3
dsmiley commented on pull request #2107:
URL: https://github.com/apache/lucene-solr/pull/2107#issuecomment-735945736
See `org.apache.solr.core.TestCoreContainer#testSharedLib` which looks
interesting. You might do something similar and add to TestConfig, and ignore
the built-in core in Te
[
https://issues.apache.org/jira/browse/SOLR-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240915#comment-17240915
]
ASF subversion and git services commented on SOLR-14958:
Commit 3
[
https://issues.apache.org/jira/browse/LUCENE-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Sokolov updated LUCENE-9626:
Description:
I ran some KNN tests constructing an index under the profiler.
||function
Michael Sokolov created LUCENE-9626:
---
Summary: Represent HNSW neighbors with primitive arrays instead of
Neighbor Objects
Key: LUCENE-9626
URL: https://issues.apache.org/jira/browse/LUCENE-9626
Proj
tmortagne commented on pull request #2107:
URL: https://github.com/apache/lucene-solr/pull/2107#issuecomment-735817609
I was wondering where would be the best place to add unit tests actually, I
could not find a SolrConfigTest but maybe you have a idea of a place dedicated
to SolrConfig va
dsmiley commented on pull request #2107:
URL: https://github.com/apache/lucene-solr/pull/2107#issuecomment-735813730
+1 LGTM. I assume you will test this manually? (good enough). LMK when
done; I'll merge this.
This is an
[
https://issues.apache.org/jira/browse/SOLR-15017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240780#comment-17240780
]
Thomas Mortagne commented on SOLR-15017:
Here it is: https://github.com/apache/lu
tmortagne opened a new pull request #2107:
URL: https://github.com/apache/lucene-solr/pull/2107
Fixes https://issues.apache.org/jira/browse/SOLR-15017
This is an automated message from the Apache Git Service.
To respond to th
Michael Sokolov created LUCENE-9625:
---
Summary: Benchmark KNN search with ann-benchmarks
Key: LUCENE-9625
URL: https://issues.apache.org/jira/browse/LUCENE-9625
Project: Lucene - Core
Issue
jpountz commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-735763595
> what I understand is the files read by for example
CompressingStoredFieldsReader, they hold versioning in the header?
When we want to make changes to a file format w
[
https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240740#comment-17240740
]
ASF subversion and git services commented on LUCENE-9624:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9624.
--
Fix Version/s: 8.8
Resolution: Fixed
> fix duplicate compute on maxUnpatchedValue
> ---
jpountz merged pull request #2106:
URL: https://github.com/apache/lucene-solr/pull/2106
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jpountz commented on pull request #2106:
URL: https://github.com/apache/lucene-solr/pull/2106#issuecomment-735760219
Thank you!
This is an automated message from the Apache Git Service.
To respond to the message, please log o
gf2121 opened a new pull request #2106:
URL: https://github.com/apache/lucene-solr/pull/2106
# Description
in [LUCENE-9027|https://github.com/apache/lucene-solr/pull/973] lucene
introduced SIMD to decode postings, which leaves a very small problem. since
this is a hot way when index
[
https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-9624:
-
Description:
in [LUCENE-9027|[https://github.com/apache/lucene-solr/pull/973]] lucene
introduced SIMD t
Feng Guo created LUCENE-9624:
Summary: fix duplicate compute on maxUnpatchedValue
Key: LUCENE-9624
URL: https://issues.apache.org/jira/browse/LUCENE-9624
Project: Lucene - Core
Issue Type: Improv
iverase commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-735732072
> SegmentInfos certainly cannot know the endianness of the file up-front.
But for other file formats, we could know this on a per-file-format basis? E.g.
Lucene86PointsForma
[
https://issues.apache.org/jira/browse/SOLR-15022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240682#comment-17240682
]
Andrzej Bialecki commented on SOLR-15022:
-
This documentation depends on some of
Andrzej Bialecki created SOLR-15022:
---
Summary: RefGuide documentation for /cluster/plugin API
Key: SOLR-15022
URL: https://issues.apache.org/jira/browse/SOLR-15022
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9623:
--
Status: Open (was: Patch Available)
> Add module descriptor (module-info.java) to lucene jars
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9623:
--
Status: Patch Available (was: Open)
> Add module descriptor (module-info.java) to lucene jars
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240637#comment-17240637
]
Uwe Schindler commented on LUCENE-9623:
---
When developing LUCENE-9281 i was not abl
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240636#comment-17240636
]
Uwe Schindler commented on LUCENE-9623:
---
bq. Yes, I think so. I copy-pasted the au
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240633#comment-17240633
]
Tomoko Uchida commented on LUCENE-9623:
---
bq. We also need some testing of the arti
[
https://issues.apache.org/jira/browse/SOLR-15017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240630#comment-17240630
]
Thomas Mortagne commented on SOLR-15017:
bq. basically don't exit early from this
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240619#comment-17240619
]
Tomoko Uchida commented on LUCENE-9623:
---
{quote}bq.I'm really excited to try the m
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240609#comment-17240609
]
Uwe Schindler edited comment on LUCENE-9623 at 11/30/20, 9:55 AM:
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240610#comment-17240610
]
Uwe Schindler commented on LUCENE-9623:
---
Ah I have seen in the examples above that
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240609#comment-17240609
]
Uwe Schindler commented on LUCENE-9623:
---
By the way, this is why this issues was a
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240604#comment-17240604
]
Uwe Schindler edited comment on LUCENE-9623 at 11/30/20, 9:38 AM:
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240604#comment-17240604
]
Uwe Schindler commented on LUCENE-9623:
---
We also need some testing of the artifact
[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240543#comment-17240543
]
Dawid Weiss commented on LUCENE-9623:
-
I'm really not sure how it should work. :) I'
56 matches
Mail list logo
