[jira] [Commented] (SOLR-14851) Http2SolrClient doesn't handle keystore type correctly

2020-11-26 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239522#comment-17239522 ] Andras Salamon commented on SOLR-14851: --- Thanks for the improvements [~janhoy] the

[GitHub] [lucene-solr] noblepaul opened a new pull request #2099: SOLR-14977: improved plugin configuration

2020-11-26 Thread GitBox
noblepaul opened a new pull request #2099: URL: https://github.com/apache/lucene-solr/pull/2099 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene-solr] dweiss commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
dweiss commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734320016 The "slow" wrapper would be needed for the many IndexInput, IndexOutput implementations that don't have optimized versions and are part of the code at the moment. By "slow" I

[GitHub] [lucene-solr] rmuir commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
rmuir commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734302940 > If you requested the reverse byte order it'd have to either wrap (slow) or return an optimized version (which in this case is simple too - clone the underlying buffer, switc

[jira] [Commented] (SOLR-14851) Http2SolrClient doesn't handle keystore type correctly

2020-11-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239272#comment-17239272 ] Jan Høydahl commented on SOLR-14851: I added a unit test, ref-guide updates, CHANGES.

[GitHub] [lucene-solr] janhoy opened a new pull request #2098: SOLR-14851 Http2SolrClient doesn't handle keystore type

2020-11-26 Thread GitBox
janhoy opened a new pull request #2098: URL: https://github.com/apache/lucene-solr/pull/2098 Based on patch by Andras Salamon in https://issues.apache.org/jira/browse/SOLR-14851 Signed-off-by: Jan Høydahl # Description Make truststore and keystore type configurable

[jira] [Resolved] (SOLR-14575) Solr restore is failing when basic authentication is enabled

2020-11-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-14575. Resolution: Cannot Reproduce Closing, as reporter reports that the issue was solved by upgrading to

[GitHub] [lucene-solr] dweiss commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
dweiss commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734261626 It's very much what RandomAccessInput interface is at the moment, btw. This is an automated message from the

[GitHub] [lucene-solr] dweiss commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
dweiss commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734261088 Perhaps I wasn't too clear but I think it'd be the same - for example, ByteBufferIndexInput would just implement ComplexTypeDataInput itself, by default assuming a certain by

[GitHub] [lucene-solr] rmuir commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
rmuir commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734260852 I think there is plenty of opportunity to make performance regressions with this change, we should have benchmarks showing the improvement before we commit any such drastic ch

[GitHub] [lucene-solr] rmuir commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
rmuir commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734258556 > These places only read bytes, they wouldn't need to know about the byte order (making things much simpler). And slower in the case of mmap: which is our default implem

[GitHub] [lucene-solr] dweiss commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
dweiss commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734255849 I took a look out of curiosity. Here are my conclusions: - making DataInput/DataOutput know about the byte-order indeed introduces a lot of byteOrder-juggling around. I

[jira] [Issue Comment Deleted] (SOLR-7229) Allow DIH to handle attachments as separate documents

2020-11-26 Thread Nazerke Seidan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nazerke Seidan updated SOLR-7229: - Comment: was deleted (was: Hi Tim, I was wondering whether this project is still open or not? I w

[GitHub] [lucene-solr] dweiss commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
dweiss commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734223008 Yes, exactly. And in those cases when you can't determine endianness from implicit information, some kind of probing will be required to determine it. Maybe you're right, @iv

[GitHub] [lucene-solr] dweiss commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
dweiss commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734221687 As is frequently the case I don't have all the answers until I take a look at this... My feeling is that this "endianness" should apply at the lowest common denominator where

[GitHub] [lucene-solr] jpountz commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
jpountz commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734218972 SegmentInfos certainly cannot know the endianness of the file up-front. But for other file formats, we could know this on a per-file-format basis? E.g. `Lucene86PointsFormat

[GitHub] [lucene-solr] iverase commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-11-26 Thread GitBox
iverase commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-734208944 I am working in the assumption that you don't know the Endianness of a file when you open it. Therefore I don't see how your approach can work except that the property in th

[jira] [Created] (SOLR-15019) Replica placement API needs a way to fetch existing replica metrics

2020-11-26 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-15019: --- Summary: Replica placement API needs a way to fetch existing replica metrics Key: SOLR-15019 URL: https://issues.apache.org/jira/browse/SOLR-15019 Project: Solr