[jira] [Commented] (SOLR-14837) prometheus-exporter: different metrics ports publishes mixed metrics

2020-11-18 Thread Fadi Mohsen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235233#comment-17235233 ] Fadi Mohsen commented on SOLR-14837: changed file name, [~janhoy] do you have any ide

[jira] [Updated] (SOLR-14837) prometheus-exporter: different metrics ports publishes mixed metrics

2020-11-18 Thread Fadi Mohsen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fadi Mohsen updated SOLR-14837: --- Attachment: (was: patch.log) > prometheus-exporter: different metrics ports publishes mixed metri

[jira] [Updated] (SOLR-14837) prometheus-exporter: different metrics ports publishes mixed metrics

2020-11-18 Thread Fadi Mohsen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fadi Mohsen updated SOLR-14837: --- Attachment: SOLR-14837.patch > prometheus-exporter: different metrics ports publishes mixed metrics >

[jira] [Updated] (SOLR-14837) prometheus-exporter: different metrics ports publishes mixed metrics

2020-11-18 Thread Fadi Mohsen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fadi Mohsen updated SOLR-14837: --- Attachment: SOLR-14837.log > prometheus-exporter: different metrics ports publishes mixed metrics > -

[jira] [Updated] (SOLR-14837) prometheus-exporter: different metrics ports publishes mixed metrics

2020-11-18 Thread Fadi Mohsen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fadi Mohsen updated SOLR-14837: --- Attachment: (was: SOLR-14837.log) > prometheus-exporter: different metrics ports publishes mixed

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-18 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r526615461 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-18 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r526607397 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] rmuir commented on pull request #2088: LUCENE-9617: Reset lowestUnassignedFieldNumber in FieldNumbers.clear()

2020-11-18 Thread GitBox
rmuir commented on pull request #2088: URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-730067131 I'm suspicious that this is safe to do. What if another thread is calling addDocument at the same time? This

[jira] [Comment Edited] (LUCENE-9616) Improve test coverage for internal format versions

2020-11-18 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235072#comment-17235072 ] Julie Tibshirani edited comment on LUCENE-9616 at 11/19/20, 12:07 AM:

[jira] [Commented] (LUCENE-9616) Improve test coverage for internal format versions

2020-11-18 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235072#comment-17235072 ] Julie Tibshirani commented on LUCENE-9616: -- I also suspect it's enough to keep

[jira] [Commented] (SOLR-14999) Add built-in option to advertise Solr with a different port than Jetty listens on.

2020-11-18 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235050#comment-17235050 ] Houston Putman commented on SOLR-14999: --- +1 I'm a fan of that idea. It might be dif

[GitHub] [lucene-solr] madrob commented on a change in pull request #2089: SOLR-14999: Option to set the advertised port for Solr.

2020-11-18 Thread GitBox
madrob commented on a change in pull request #2089: URL: https://github.com/apache/lucene-solr/pull/2089#discussion_r526487616 ## File path: solr/solr-ref-guide/src/format-of-solr-xml.adoc ## @@ -134,9 +134,10 @@ The hostname Solr uses to access cores. The url context path.

[jira] [Commented] (SOLR-14999) Add built-in option to advertise Solr with a different port than Jetty listens on.

2020-11-18 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235047#comment-17235047 ] Mike Drob commented on SOLR-14999: -- Borrowing from Mark's comments in the linked thread,

[jira] [Updated] (SOLR-14999) Add built-in option to advertise Solr with a different port than Jetty listens on.

2020-11-18 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-14999: -- Description: Currently the default settings in {{solr.xml}} allow the specification of one por

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2089: SOLR-14999: Option to set the advertised port for Solr.

2020-11-18 Thread GitBox
HoustonPutman opened a new pull request #2089: URL: https://github.com/apache/lucene-solr/pull/2089 https://issues.apache.org/jira/browse/SOLR-14999 I am open to suggestions on the naming of this new option. Currently I have `-Dsolr.port.advertise` and `SOLR_PORT_ADVERTISE`, because

[GitHub] [lucene-solr] msfroh opened a new pull request #2088: LUCENE-9617: Reset lowestUnassignedFieldNumber in FieldNumbers.clear()

2020-11-18 Thread GitBox
msfroh opened a new pull request #2088: URL: https://github.com/apache/lucene-solr/pull/2088 FieldNumbers.clear() is called from IndexWriter.deleteAll(), which is supposed to completely reset the state of the index. This includes clearing all known fields. Prior to this change,

[GitHub] [lucene-solr] madrob commented on a change in pull request #2083: SOLR-15001 Docker: require init_var_solr.sh

2020-11-18 Thread GitBox
madrob commented on a change in pull request #2083: URL: https://github.com/apache/lucene-solr/pull/2083#discussion_r526336171 ## File path: solr/docker/include/scripts/init-var-solr ## @@ -31,31 +31,31 @@ function check_dir_writability { } if [ ! -d "$DIR/data" ]; then -

[GitHub] [lucene-solr] madrob commented on a change in pull request #2083: SOLR-15001 Docker: require init_var_solr.sh

2020-11-18 Thread GitBox
madrob commented on a change in pull request #2083: URL: https://github.com/apache/lucene-solr/pull/2083#discussion_r526336171 ## File path: solr/docker/include/scripts/init-var-solr ## @@ -31,31 +31,31 @@ function check_dir_writability { } if [ ! -d "$DIR/data" ]; then -

[jira] [Created] (LUCENE-9617) FieldNumbers.clear() should reset lowestUnassignedFieldNumber

2020-11-18 Thread Michael Froh (Jira)
Michael Froh created LUCENE-9617: Summary: FieldNumbers.clear() should reset lowestUnassignedFieldNumber Key: LUCENE-9617 URL: https://issues.apache.org/jira/browse/LUCENE-9617 Project: Lucene - Core

[jira] [Updated] (SOLR-14560) Learning To Rank Interleaving

2020-11-18 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-14560: Fix Version/s: 8.8 master (9.0) > Learning To Rank Interleaving

[jira] [Resolved] (SOLR-14560) Learning To Rank Interleaving

2020-11-18 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti resolved SOLR-14560. - Resolution: Fixed Thanks [~cpoerschke] for all the reviewing help! This new feat

[GitHub] [lucene-solr] madrob commented on pull request #2086: SOLR-14985: Slow indexing and search performance when using HttpClusterStateProvider

2020-11-18 Thread GitBox
madrob commented on pull request #2086: URL: https://github.com/apache/lucene-solr/pull/2086#issuecomment-729873570 @thelabdude this seems like something you'd be interested in was well. This is an automated message from the

[GitHub] [lucene-solr] madrob commented on a change in pull request #2086: SOLR-14985: Slow indexing and search performance when using HttpClusterStateProvider

2020-11-18 Thread GitBox
madrob commented on a change in pull request #2086: URL: https://github.com/apache/lucene-solr/pull/2086#discussion_r526311005 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/impl/CountingHttpClusterStateProvider.java ## @@ -0,0 +1,72 @@ +/* + * Licensed to the

[jira] [Commented] (SOLR-14560) Learning To Rank Interleaving

2020-11-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234899#comment-17234899 ] ASF subversion and git services commented on SOLR-14560: Commit f

[GitHub] [lucene-solr] alessandrobenedetti commented on pull request #1571: SOLR-14560: Interleaving for Learning To Rank

2020-11-18 Thread GitBox
alessandrobenedetti commented on pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#issuecomment-729864396 Thanks @cpoerschke for the thorough review! This is an automated message from the Apache Git Ser

[jira] [Commented] (SOLR-14560) Learning To Rank Interleaving

2020-11-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234888#comment-17234888 ] ASF subversion and git services commented on SOLR-14560: Commit a

[jira] [Commented] (SOLR-14560) Learning To Rank Interleaving

2020-11-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234887#comment-17234887 ] ASF subversion and git services commented on SOLR-14560: Commit a

[GitHub] [lucene-solr] alessandrobenedetti merged pull request #1571: SOLR-14560: Interleaving for Learning To Rank

2020-11-18 Thread GitBox
alessandrobenedetti merged pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-11-18 Thread Clemens Stukenbrock (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234877#comment-17234877 ] Clemens Stukenbrock commented on LUCENE-9021: - Hello [~mkhl],  do you have a

[GitHub] [lucene-solr] thelabdude commented on pull request #2010: SOLR-12182: Don't persist base_url in ZK as the scheme is variable, compute from node_name instead

2020-11-18 Thread GitBox
thelabdude commented on pull request #2010: URL: https://github.com/apache/lucene-solr/pull/2010#issuecomment-729783538 Hi @noblepaul thanks for taking a look ... so we decided to not try to handle the upgrade to TLS using a rolling restart (as described in my comment ^) in this PR ... als

[jira] [Comment Edited] (LUCENE-9378) Configurable compression for BinaryDocValues

2020-11-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234755#comment-17234755 ] Adrien Grand edited comment on LUCENE-9378 at 11/18/20, 3:56 PM: -

[jira] [Commented] (LUCENE-9378) Configurable compression for BinaryDocValues

2020-11-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234755#comment-17234755 ] Adrien Grand commented on LUCENE-9378: -- [~gworah] I'm pretty sure that the drop is

[jira] [Commented] (LUCENE-9616) Improve test coverage for internal format versions

2020-11-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234746#comment-17234746 ] Adrien Grand commented on LUCENE-9616: -- I gave it a try on my PR for LUCENE-9613 by

[jira] [Commented] (LUCENE-9613) Create blocks for ords when it helps in Lucene80DocValuesFormat

2020-11-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234742#comment-17234742 ] Adrien Grand commented on LUCENE-9613: -- I opened a pull request that writes ordinal

[GitHub] [lucene-solr] jpountz opened a new pull request #2087: LUCENE-9613: Split ordinals into blocks when it saves 10+% space.

2020-11-18 Thread GitBox
jpountz opened a new pull request #2087: URL: https://github.com/apache/lucene-solr/pull/2087 This changes the way that doc values write ordinals so that Lucene splits into blocks if it would save more than 10% space, like we do for numeric fields. By the way, we are now using the sa

[GitHub] [lucene-solr] rmuir commented on pull request #2080: LUCENE-8947: Skip field length accumulation when norms are disabled

2020-11-18 Thread GitBox
rmuir commented on pull request #2080: URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-729757207 `totalTermFreq`/`sumTotalTermFreq` are about term frequencies, nothing to do with the norms... but this norms check is the only thing guarding against overflow. we can't just

[jira] [Commented] (LUCENE-9616) Improve test coverage for internal format versions

2020-11-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234719#comment-17234719 ] Adrien Grand commented on LUCENE-9616: -- I don't know if I would go as far as includ

[jira] [Commented] (SOLR-14973) Solr 8.6 is shipping libraries that are incompatible with each other

2020-11-18 Thread Tim Allison (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234714#comment-17234714 ] Tim Allison commented on SOLR-14973: Backporting and confirming that I didn't break a

[jira] [Commented] (SOLR-14973) Solr 8.6 is shipping libraries that are incompatible with each other

2020-11-18 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234688#comment-17234688 ] Kevin Risden commented on SOLR-14973: - [~tallison] If its not a lot of work, then sur

[jira] [Commented] (SOLR-13821) Package Store

2020-11-18 Thread marian vasile caraiman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234644#comment-17234644 ] marian vasile caraiman commented on SOLR-13821: --- I saw in the design docume

[GitHub] [lucene-solr] shalinmangar opened a new pull request #2086: SOLR-14985: Slow indexing and search performance when using HttpClusterStateProvider

2020-11-18 Thread GitBox
shalinmangar opened a new pull request #2086: URL: https://github.com/apache/lucene-solr/pull/2086 # Description HttpClusterStateProvider fetches and caches Aliases and Live Nodes for 5 seconds. But all calls to getState are live. These collection states are supposed to be cached in

[jira] [Commented] (SOLR-15007) Aggregate core handler=/select and /update metrics at the node level metric too

2020-11-18 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234635#comment-17234635 ] Andrzej Bialecki commented on SOLR-15007: - Please check out {{MetricsCollectorHan

[GitHub] [lucene-solr] noblepaul commented on pull request #2010: SOLR-12182: Don't persist base_url in ZK as the scheme is variable, compute from node_name instead

2020-11-18 Thread GitBox
noblepaul commented on pull request #2010: URL: https://github.com/apache/lucene-solr/pull/2010#issuecomment-729684303 Before I go further, can I know * Does this work for a rolling restart? * How does one migrate to this? -

[GitHub] [lucene-solr] dsmiley commented on pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-11-18 Thread GitBox
dsmiley commented on pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-729668076 > we could still document how to perform PGP checks on the jars Just confirming... we agree that ./verify-docker.sh is needless, and we need to just _document_ (e.g. i

[GitHub] [lucene-solr] s1monw commented on a change in pull request #2085: LUCENE-9508: Fix DocumentsWriter to block threads until unstalled

2020-11-18 Thread GitBox
s1monw commented on a change in pull request #2085: URL: https://github.com/apache/lucene-solr/pull/2085#discussion_r526058298 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@ -371,19 +371,15 @@ public void close() throws IOException { pr

[GitHub] [lucene-solr] s1monw commented on a change in pull request #2085: LUCENE-9508: Fix DocumentsWriter to block threads until unstalled

2020-11-18 Thread GitBox
s1monw commented on a change in pull request #2085: URL: https://github.com/apache/lucene-solr/pull/2085#discussion_r526058138 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4258,4 +4258,47 @@ public void testPendingNumDocs() throws Excep

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2085: LUCENE-9508: Fix DocumentsWriter to block threads until unstalled

2020-11-18 Thread GitBox
dweiss commented on a change in pull request #2085: URL: https://github.com/apache/lucene-solr/pull/2085#discussion_r526032942 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4258,4 +4258,47 @@ public void testPendingNumDocs() throws Excep

[GitHub] [lucene-solr] s1monw commented on pull request #2085: LUCENE-9508: Fix DocumentsWriter to block threads until unstalled

2020-11-18 Thread GitBox
s1monw commented on pull request #2085: URL: https://github.com/apache/lucene-solr/pull/2085#issuecomment-729631181 @mikemccand can you take a look pls This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene-solr] s1monw opened a new pull request #2085: LUCENE-9508: Fix DocumentsWriter to block threads until unstalled

2020-11-18 Thread GitBox
s1monw opened a new pull request #2085: URL: https://github.com/apache/lucene-solr/pull/2085 DWStallControl expects the caller to loop on top of the wait call to make progress with flushing if the DW is stalled. This logic wasn't applied such that DW only stalled for one second and th

[jira] [Comment Edited] (LUCENE-9584) PointInSetQuery does not terminate early if result iterator has no docs

2020-11-18 Thread hackerwin7 (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220608#comment-17220608 ] hackerwin7 edited comment on LUCENE-9584 at 11/18/20, 10:57 AM: --

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-18 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525918279 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-18 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525917794 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-18 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525912478 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-18 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525910929 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-18 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525909321 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -p

[GitHub] [lucene-solr] janhoy commented on pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-11-18 Thread GitBox
janhoy commented on pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-729525514 > what do you imagine `verify-docker.sh` would be doing under the hood It would verify the sha512 sum of each jar with the corresponding checksum published by the proje

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-18 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729520080 > I stated a bit earlier, removing WindowsDirectory should be a separate PR. It's not the same thing (it's not about DirectIO), it works around aproblem with positional

[GitHub] [lucene-solr] uschindler commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-18 Thread GitBox
uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729516294 I stated a bit earlier, removing WindowsDirectory should be a separate PR. It's not the same thing (it's not about DirectIO), it works around aproblem with positional rea