[GitHub] [lucene-solr] zacharymorn commented on pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

2020-11-11 Thread GitBox
zacharymorn commented on pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-725853994 > All of it looks good, Zach. Sorry about my lack of consistency here but on as second thought I think we should add a safety switch of perhaps force-disabling the nativ

[GitHub] [lucene-solr] zacharymorn commented on pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

2020-11-11 Thread GitBox
zacharymorn commented on pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-725807511 > Added the kill switch, Zach. I think you need to merge with master and then update the overview file that Tomoko moved to package-info.java (grep for "build-native-uni

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

2020-11-11 Thread GitBox
zacharymorn commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r521802817 ## File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp ## @@ -38,12 +38,12 @@ #ifdef LINUX /* - * Class: org_apache_lucene_st

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

2020-11-11 Thread GitBox
zacharymorn commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r521801016 ## File path: .gitignore ## @@ -8,6 +8,10 @@ build/ /.idea/ #IntelliJ creates this folder, ignore. /dev-tools/missing-doclet/out/ +*.iml R

[jira] [Commented] (SOLR-14975) Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames

2020-11-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230334#comment-17230334 ] Erick Erickson commented on SOLR-14975: --- [~broustant] 1> do you intend to backport

[GitHub] [lucene-solr] rmuir opened a new pull request #2077: LUCENE-9605: update snowball to d8cf01ddf37a, adds Yiddish

2020-11-11 Thread GitBox
rmuir opened a new pull request #2077: URL: https://github.com/apache/lucene-solr/pull/2077 Just merged their master branch, regenerated the patch file, and reran `gradlew snowball`, precommit and tests. This is an automated

[jira] [Updated] (LUCENE-9605) update snowball to latest (adds Yiddish stemmer)

2020-11-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9605: Fix Version/s: master (9.0) > update snowball to latest (adds Yiddish stemmer) > -

[jira] [Created] (LUCENE-9605) update snowball to latest (adds Yiddish stemmer)

2020-11-11 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9605: --- Summary: update snowball to latest (adds Yiddish stemmer) Key: LUCENE-9605 URL: https://issues.apache.org/jira/browse/LUCENE-9605 Project: Lucene - Core Issue

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521708062 ## File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java ## @@ -114,6 +118,16 @@ public synchronized ApiInfo getPlugin(Str

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521707653 ## File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java ## @@ -366,7 +381,7 @@ public void m2(SolrQueryRequest req, SolrQu

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521707503 ## File path: solr/core/src/java/org/apache/solr/api/ConfigurablePlugin.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521707369 ## File path: solr/core/src/java/org/apache/solr/api/AnnotatedApi.java ## @@ -62,6 +63,8 @@ public class AnnotatedApi extends Api implements Perm

[jira] [Commented] (SOLR-14986) Restrict the properties possible to define with "property.name=value" when creating a collection

2020-11-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230270#comment-17230270 ] Erick Erickson commented on SOLR-14986: --- It's a sticky wicket. Short form: I don't

[GitHub] [lucene-solr] dweiss commented on pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

2020-11-11 Thread GitBox
dweiss commented on pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-725648046 Added the kill switch, Zach. I think you need to merge with master and then update the overview file that Tomoko moved to package-info.java (grep for "build-native-unix" and

[jira] [Resolved] (SOLR-14971) AtomicUpdate 'remove' fails on 'pints' fields

2020-11-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-14971. Fix Version/s: 8.8 master (9.0) Resolution: Fixed > AtomicUpdate

[jira] [Commented] (SOLR-14971) AtomicUpdate 'remove' fails on 'pints' fields

2020-11-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230138#comment-17230138 ] Jason Gerlowski commented on SOLR-14971: On the github PR, Munendra pointed out t

[jira] [Commented] (SOLR-14971) AtomicUpdate 'remove' fails on 'pints' fields

2020-11-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230134#comment-17230134 ] ASF subversion and git services commented on SOLR-14971: Commit 8

[jira] [Comment Edited] (SOLR-14788) Solr: The Next Big Thing

2020-11-11 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230125#comment-17230125 ] Ilan Ginzburg edited comment on SOLR-14788 at 11/11/20, 5:38 PM: --

[jira] [Commented] (SOLR-14788) Solr: The Next Big Thing

2020-11-11 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230125#comment-17230125 ] Ilan Ginzburg commented on SOLR-14788: -- ??Most of the work done by the overseer is u

[jira] [Commented] (SOLR-14971) AtomicUpdate 'remove' fails on 'pints' fields

2020-11-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230121#comment-17230121 ] ASF subversion and git services commented on SOLR-14971: Commit a

[GitHub] [lucene-solr] gerlowskija merged pull request #2056: SOLR-14971: Handle atomic-removes on uncommitted docs

2020-11-11 Thread GitBox
gerlowskija merged pull request #2056: URL: https://github.com/apache/lucene-solr/pull/2056 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] gerlowskija commented on pull request #2056: SOLR-14971: Handle atomic-removes on uncommitted docs

2020-11-11 Thread GitBox
gerlowskija commented on pull request #2056: URL: https://github.com/apache/lucene-solr/pull/2056#issuecomment-725554469 Deciding to keep the implementation as-is for now. We can revisit if other type-related bugs pop up, or anyone has insight into what the downstream effects of the bulk

[jira] [Updated] (LUCENE-9604) Add (precommit) checks to prevent split packages

2020-11-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9604: -- Description: (Follow-up issue for LUCENE-9499) We could scan all java files via sourceSets an

[jira] [Created] (LUCENE-9604) Add (precommit) checks to prevent split packages

2020-11-11 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-9604: - Summary: Add (precommit) checks to prevent split packages Key: LUCENE-9604 URL: https://issues.apache.org/jira/browse/LUCENE-9604 Project: Lucene - Core Is

[jira] [Resolved] (LUCENE-9499) Clean up package name conflicts between modules (split packages)

2020-11-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-9499. --- Resolution: Fixed > Clean up package name conflicts between modules (split packages) > -

[jira] [Commented] (SOLR-14993) Unable to download zookeeper files of 1byte in size

2020-11-11 Thread Allen Sooredoo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229979#comment-17229979 ] Allen Sooredoo commented on SOLR-14993: --- Thanks a lot. My current hack is to add a

[jira] [Comment Edited] (SOLR-14993) Unable to download zookeeper files of 1byte in size

2020-11-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229973#comment-17229973 ] Erick Erickson edited comment on SOLR-14993 at 11/11/20, 1:04 PM: -

[jira] [Assigned] (SOLR-14993) Unable to download zookeeper files of 1byte in size

2020-11-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-14993: - Assignee: Erick Erickson > Unable to download zookeeper files of 1byte in size > ---

[jira] [Commented] (SOLR-14993) Unable to download zookeeper files of 1byte in size

2020-11-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229973#comment-17229973 ] Erick Erickson commented on SOLR-14993: --- Hmmm, that really doesn't look right, why

[jira] [Resolved] (SOLR-12821) IndexSizeTriggerTest.testMixedBounds() failures

2020-11-11 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-12821. - Resolution: Won't Fix Autoscaling framework (the code in 8x) is EOL. > IndexSizeTriggerT

[jira] [Resolved] (SOLR-13641) Undocumented and untested "cleanupThread" functionality in LFUCache and FastLRUCache

2020-11-11 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-13641. - Resolution: Won't Fix LFUCache is EOL in Solr 8x and removed in Solr 9.0. > Undocumented

[jira] [Resolved] (SOLR-14233) JsonSchemaCreator should support Map payloads

2020-11-11 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14233. - Resolution: Fixed This has been fixed in SOLR-14871. > JsonSchemaCreator should support

[jira] [Resolved] (SOLR-14275) Policy calculations are very slow for large clusters and large operations

2020-11-11 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14275. - Resolution: Won't Fix This implementation is EOL in Solr 8x. > Policy calculations are v

[jira] [Resolved] (SOLR-14948) Autoscaling maxComputeOperations override causes exceptions

2020-11-11 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14948. - Resolution: Fixed > Autoscaling maxComputeOperations override causes exceptions > ---

[jira] [Resolved] (SOLR-14749) Provide a clean API for cluster-level event processing

2020-11-11 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14749. - Resolution: Fixed > Provide a clean API for cluster-level event processing >

[jira] [Updated] (SOLR-14683) Review the metrics API to ensure consistent placeholders for missing values

2020-11-11 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14683: Fix Version/s: (was: master (9.0)) 8.8 > Review the metrics API to e

[GitHub] [lucene-solr] sigram commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
sigram commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521325883 ## File path: solr/core/src/java/org/apache/solr/api/ConfigurablePlugin.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [lucene-solr] sigram commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
sigram commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521325883 ## File path: solr/core/src/java/org/apache/solr/api/ConfigurablePlugin.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [lucene-solr] sigram commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
sigram commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521325883 ## File path: solr/core/src/java/org/apache/solr/api/ConfigurablePlugin.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [lucene-solr] sigram commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
sigram commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521325260 ## File path: solr/core/src/java/org/apache/solr/api/AnnotatedApi.java ## @@ -62,6 +63,8 @@ public class AnnotatedApi extends Api implements Permiss

[GitHub] [lucene-solr] sigram commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
sigram commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521323363 ## File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java ## @@ -114,6 +118,16 @@ public synchronized ApiInfo getPlugin(String

[GitHub] [lucene-solr] sigram commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

2020-11-11 Thread GitBox
sigram commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521322184 ## File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java ## @@ -366,7 +381,7 @@ public void m2(SolrQueryRequest req, SolrQuery

[jira] [Commented] (SOLR-14683) Review the metrics API to ensure consistent placeholders for missing values

2020-11-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229939#comment-17229939 ] ASF subversion and git services commented on SOLR-14683: Commit 9

[jira] [Commented] (SOLR-14975) Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames

2020-11-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229899#comment-17229899 ] ASF subversion and git services commented on SOLR-14975: Commit 9

[jira] [Commented] (SOLR-14975) Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames

2020-11-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229896#comment-17229896 ] ASF subversion and git services commented on SOLR-14975: Commit 6

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

2020-11-11 Thread GitBox
dweiss commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r521238097 ## File path: .gitignore ## @@ -8,6 +8,10 @@ build/ /.idea/ #IntelliJ creates this folder, ignore. /dev-tools/missing-doclet/out/ +*.iml Review

[jira] [Comment Edited] (SOLR-14993) Unable to download zookeeper files of 1byte in size

2020-11-11 Thread Allen Sooredoo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229875#comment-17229875 ] Allen Sooredoo edited comment on SOLR-14993 at 11/11/20, 9:49 AM: -

[jira] [Comment Edited] (SOLR-14993) Unable to download zookeeper files of 1byte in size

2020-11-11 Thread Allen Sooredoo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229875#comment-17229875 ] Allen Sooredoo edited comment on SOLR-14993 at 11/11/20, 9:49 AM: -

[jira] [Commented] (SOLR-14993) Unable to download zookeeper files of 1byte in size

2020-11-11 Thread Allen Sooredoo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229875#comment-17229875 ] Allen Sooredoo commented on SOLR-14993: --- Hi,   sorry about that, I wanted to do a v

[jira] [Comment Edited] (SOLR-14993) Unable to download zookeeper files of 1byte in size

2020-11-11 Thread Allen Sooredoo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229875#comment-17229875 ] Allen Sooredoo edited comment on SOLR-14993 at 11/11/20, 9:48 AM: -