[GitHub] [lucene-solr] noblepaul opened a new pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

noblepaul opened a new pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Commented] (SOLR-14928) Remove Overseer ClusterStateUpdater

[ https://issues.apache.org/jira/browse/SOLR-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227087#comment-17227087 ] Ilan Ginzburg commented on SOLR-14928: -- I pushed a first [commit|https://github.com

[jira] [Commented] (SOLR-9188) BlockUnknown property makes inter-node communication impossible

[ https://issues.apache.org/jira/browse/SOLR-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227004#comment-17227004 ] Jan Høydahl commented on SOLR-9188: --- If you believe you have found a similar bug in 8.6,

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

msokolov commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518351139 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ## @@ -139,6 +140,7 @@ void collectAnyHit(int doc, int hitsCollect

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

cpoerschke commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518364159 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java ## @@ -146,93 +149,114 @@ public LTRQParser(String qstr,

[GitHub] [lucene-solr] thelabdude commented on pull request #2010: SOLR-12182: Don't persist base_url in ZK as the scheme is variable, compute from node_name instead

thelabdude commented on pull request #2010: URL: https://github.com/apache/lucene-solr/pull/2010#issuecomment-722639840 I think this is ready for review again ... still have to create CHANGES.txt entry and update the ref guide but let's get through another round of reviews, esp. around the

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2010: SOLR-12182: Don't persist base_url in ZK as the scheme is variable, compute from node_name instead

muse-dev[bot] commented on a change in pull request #2010: URL: https://github.com/apache/lucene-solr/pull/2010#discussion_r518357932 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -1401,8 +1420,7 @@ public ZkCoreNodeProps getLeaderProps(final St

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2062: LUCENE-9589 Swedish minimal stemmer

dweiss commented on a change in pull request #2062: URL: https://github.com/apache/lucene-solr/pull/2062#discussion_r518352675 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/sv/SwedishMinimalStemFilterFactory.java ## @@ -0,0 +1,60 @@ +/* + * Licensed

[GitHub] [lucene-solr] janhoy commented on a change in pull request #2062: LUCENE-9589 Swedish minimal stemmer

janhoy commented on a change in pull request #2062: URL: https://github.com/apache/lucene-solr/pull/2062#discussion_r518323263 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/sv/SwedishMinimalStemFilterFactory.java ## @@ -0,0 +1,60 @@ +/* + * Licensed

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518316774 ## File path: lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java ## @@ -485,4 +491,186 @@ public void testD

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518316315 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java ## @@ -0,0 +1,324 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518293629 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/TeamDraftInterleaving.java ## @@ -0,0 +1,87 @@ +/* + * Licensed

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518292659 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRInterleavingRescorer.java ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apa

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518291805 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java ## @@ -271,17 +287

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518290312 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java ## @@ -146,93 +149,114 @@ public LTRQParser(Stri

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226930#comment-17226930 ] Erick Erickson commented on SOLR-8330: -- Without thinking about it too much, I'm in fa

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226927#comment-17226927 ] Mikhail Khludnev commented on SOLR-8673: I think it's good. However, it's worth to

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518269182 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -166,64 +186,77 @@ public void scoreFeatures(IndexSearc

[GitHub] [lucene-solr] gerlowskija commented on pull request #2056: SOLR-14971: Handle atomic-removes on uncommitted docs

gerlowskija commented on pull request #2056: URL: https://github.com/apache/lucene-solr/pull/2056#issuecomment-722539440 I thought of doing a `toNativeType` conversion on the "original" Collection, but didn't like how it changed SolrInputDocument values for field-vals supposedly unaffected

[jira] [Comment Edited] (SOLR-14683) Review the metrics API to ensure consistent placeholders for missing values

[ https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226897#comment-17226897 ] Chris M. Hostetter edited comment on SOLR-14683 at 11/5/20, 5:47 PM: --

[jira] [Commented] (SOLR-14683) Review the metrics API to ensure consistent placeholders for missing values

[ https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226897#comment-17226897 ] Chris M. Hostetter commented on SOLR-14683: --- Where it's in the spec or not, Sol

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

cpoerschke commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518217755 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java ## @@ -210,50 +216,59 @@ pu

[jira] [Commented] (SOLR-14951) Upgrade Angular JS 1.7.9 to 1.8.0

[ https://issues.apache.org/jira/browse/SOLR-14951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226862#comment-17226862 ] Cassandra Targett commented on SOLR-14951: -- It looks like this didn't make it in

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226823#comment-17226823 ] David Smiley commented on SOLR-8330: I'm looking at logs to debug a problem, and the l

[jira] [Commented] (SOLR-9188) BlockUnknown property makes inter-node communication impossible

[ https://issues.apache.org/jira/browse/SOLR-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226817#comment-17226817 ] Yevhen Tienkaiev commented on SOLR-9188: Same issue found in 8.6 > BlockUnknown p

[jira] [Comment Edited] (SOLR-9188) BlockUnknown property makes inter-node communication impossible

[ https://issues.apache.org/jira/browse/SOLR-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226817#comment-17226817 ] Yevhen Tienkaiev edited comment on SOLR-9188 at 11/5/20, 4:45 PM: --

[GitHub] [lucene-solr] saatchibhalla commented on pull request #2040: SOLR-14965 add overseer queue size metrics

saatchibhalla commented on pull request #2040: URL: https://github.com/apache/lucene-solr/pull/2040#issuecomment-722489672 @sigram Would you mind taking another look at this PR whenever you have a chance? This is an automat

[jira] [Created] (SOLR-14986) Restrict the properties possible to define with "property.name=value" when creating a collection

Erick Erickson created SOLR-14986: - Summary: Restrict the properties possible to define with "property.name=value" when creating a collection Key: SOLR-14986 URL: https://issues.apache.org/jira/browse/SOLR-14986

[jira] [Updated] (SOLR-14985) Slow indexing and search performance when using HttpClusterStateProvider

[ https://issues.apache.org/jira/browse/SOLR-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-14985: - Description: HttpClusterStateProvider fetches and caches Aliases and Live Nodes f

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

cpoerschke commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518156348 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRInterleavingRescorer.java ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Softw

[jira] [Commented] (SOLR-14985) Slow indexing and search performance when using HttpClusterStateProvider

[ https://issues.apache.org/jira/browse/SOLR-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226782#comment-17226782 ] Shalin Shekhar Mangar commented on SOLR-14985: -- Linking to SOLR-14966 and SO

[jira] [Created] (SOLR-14985) Slow indexing and search performance when using HttpClusterStateProvider

Shalin Shekhar Mangar created SOLR-14985: Summary: Slow indexing and search performance when using HttpClusterStateProvider Key: SOLR-14985 URL: https://issues.apache.org/jira/browse/SOLR-14985

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518147905 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/SolrQueryRequestContextUtils.java ## @@ -47,12 +47,12 @@ public static Featur

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518145813 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRInterleavingTransformerFactory.java ## @@ -0,0 +1,120 @

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518141759 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java ## @@ -146,93 +149,114 @@ public LTRQParser(Stri

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r500956870 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java ## @@ -146,93 +149,114 @@ public LTRQParser(Stri

[jira] [Commented] (SOLR-14683) Review the metrics API to ensure consistent placeholders for missing values

[ https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226729#comment-17226729 ] Andrzej Bialecki commented on SOLR-14683: - Prometheus best practices recommend "a

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

msokolov commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518055212 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apach

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

cpoerschke commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518035475 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRInterleavingRescorer.java ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Softw

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2047: LUCENE-9592: Use doubles in VectorUtil to maintain precision.

msokolov commented on a change in pull request #2047: URL: https://github.com/apache/lucene-solr/pull/2047#discussion_r518030964 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -25,47 +25,22 @@ private VectorUtil() { } - public static fl

[jira] [Commented] (SOLR-14749) Provide a clean API for cluster-level event processing

[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226705#comment-17226705 ] ASF subversion and git services commented on SOLR-14749: Commit 0

[jira] [Commented] (SOLR-14749) Provide a clean API for cluster-level event processing

[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226674#comment-17226674 ] Andrzej Bialecki commented on SOLR-14749: - Thanks [~noble.paul] and [~ilan] for c

[GitHub] [lucene-solr] mocobeta commented on pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

mocobeta commented on pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#issuecomment-722333573 The changes look okay to me; the refactoring on misc module shouldn't change its behaviour while some classes are moved under o.a.l.misc package. I'm going to merge it in

[GitHub] [lucene-solr] sigram commented on pull request #1962: SOLR-14749 Provide a clean API for cluster-level event processing

sigram commented on pull request #1962: URL: https://github.com/apache/lucene-solr/pull/1962#issuecomment-722317372 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] sigram closed pull request #1962: SOLR-14749 Provide a clean API for cluster-level event processing

sigram closed pull request #1962: URL: https://github.com/apache/lucene-solr/pull/1962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14749) Provide a clean API for cluster-level event processing

[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226657#comment-17226657 ] ASF subversion and git services commented on SOLR-14749: Commit b

[jira] [Commented] (LUCENE-9536) Optimize OrdinalMap when one segment contains all distinct values?

[ https://issues.apache.org/jira/browse/LUCENE-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226644#comment-17226644 ] ASF subversion and git services commented on LUCENE-9536: - Commi

[jira] [Commented] (LUCENE-9536) Optimize OrdinalMap when one segment contains all distinct values?

[ https://issues.apache.org/jira/browse/LUCENE-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226645#comment-17226645 ] ASF subversion and git services commented on LUCENE-9536: - Commi

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

cpoerschke commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r517960447 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -166,64 +186,77 @@ public void scoreFeatures(IndexSearcher index

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226632#comment-17226632 ] Thomas Wöckinger commented on SOLR-14923: - Some comments about: {quote}When there

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517941795 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsR

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226628#comment-17226628 ] Tim Owen commented on SOLR-8673: I've attached a patch that I used and it allowed me to po

[jira] [Updated] (SOLR-8673) o.a.s.search.facet classes not public/extendable

[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Owen updated SOLR-8673: --- Attachment: SOLR-8673.patch > o.a.s.search.facet classes not public/extendable > -

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

dweiss commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517932599 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsRef

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517929357 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsR

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517929357 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsR

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517910420 ## File path: lucene/misc/src/test/org/apache/lucene/misc/index/TestIndexSplitter.java ## @@ -60,9 +67,9 @@ public void test() throws Exception {

[jira] [Commented] (LUCENE-9600) Clean up package name conflicts for misc module

[ https://issues.apache.org/jira/browse/LUCENE-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226594#comment-17226594 ] Tomoko Uchida commented on LUCENE-9600: --- I opened [https://github.com/apache/lucen

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2064: LUCENE-9660: Clean up package name conflicts between misc and core modules

dweiss commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517899107 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsRef

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2064: LUCENE-9660: Clean up package name conflicts between misc and core modules

dweiss commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517898320 ## File path: lucene/misc/src/test/org/apache/lucene/misc/index/TestIndexSplitter.java ## @@ -60,9 +67,9 @@ public void test() throws Exception {

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9660: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517897531 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/DocHelper.java ## @@ -35,7 +35,8 @@ import org.apache.lucene.search.similaritie

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9660: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517897262 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsR

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9660: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517895258 ## File path: lucene/misc/src/test/org/apache/lucene/misc/index/TestIndexSplitter.java ## @@ -60,9 +67,9 @@ public void test() throws Exception {

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

cpoerschke commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r517889175 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java ## @@ -146,93 +149,114 @@ public LTRQParser(String qstr,

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9660: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517891574 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/MultiPassIndexSplitter.java ## @@ -101,7 +111,7 @@ public void split(IndexReader in,

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9660: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517888111 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexSplitter.java ## @@ -123,8 +118,8 @@ private SegmentCommitInfo getInfo(String na

[GitHub] [lucene-site] johtani commented on a change in pull request #33: Fix change log URL

johtani commented on a change in pull request #33: URL: https://github.com/apache/lucene-site/pull/33#discussion_r517865206 ## File path: content/core/core_news/2020-11-03-8-7-0-available.md ## @@ -19,8 +19,8 @@ Faster sorting by field. When a doc-value field is also indexed w

[GitHub] [lucene-solr] mocobeta opened a new pull request #2064: LUCENE-9660: Clean up package name conflicts between misc and core modules

mocobeta opened a new pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064 This refactors misc module to resolve package name conflicts between misc and lucene-core. - moves `o.a.l.document`, `o.a.l.index`, `o.a.l.search`, `o.a.l.store`, `o.a.l.util`, and their s

[GitHub] [lucene-site] atris commented on a change in pull request #33: Fix change log URL

atris commented on a change in pull request #33: URL: https://github.com/apache/lucene-site/pull/33#discussion_r517862652 ## File path: content/core/core_news/2020-11-03-8-7-0-available.md ## @@ -19,8 +19,8 @@ Faster sorting by field. When a doc-value field is also indexed wit