anshumg commented on a change in pull request #2026:
URL: https://github.com/apache/lucene-solr/pull/2026#discussion_r511735403
##
File path:
lucene/spatial-extras/src/test/org/apache/lucene/spatial/TestQueryEqualsHashCode.java
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apac
[
https://issues.apache.org/jira/browse/LUCENE-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220400#comment-17220400
]
Julie Tibshirani commented on LUCENE-9583:
--
> Without it, we would need to load
jtibshirani opened a new pull request #2028:
URL: https://github.com/apache/lucene-solr/pull/2028
This ensures that vector values are sorted when sorting an index
after-the-fact
using `SortingCodecReader`.
This is an auto
dweiss commented on pull request #2026:
URL: https://github.com/apache/lucene-solr/pull/2026#issuecomment-716184631
ok.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
MarcusSorealheis commented on pull request #2026:
URL: https://github.com/apache/lucene-solr/pull/2026#issuecomment-716184493
@dweiss I'm of the opinion that they could happen in parallel because we
know in which direction we are going given the current state. The enforcement
will obviousl
dweiss commented on pull request #2026:
URL: https://github.com/apache/lucene-solr/pull/2026#issuecomment-716183934
Wouldn't it be better to add test convention enforcement first, followed by
gradual rename of all convention-excluded files? I filed a suggestion on how
this could be done -
[
https://issues.apache.org/jira/browse/SOLR-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220349#comment-17220349
]
Erick Erickson commented on SOLR-14954:
---
I managed to totally mess up my repo, so a
ErickErickson opened a new pull request #2027:
URL: https://github.com/apache/lucene-solr/pull/2027
Found the file again after totally messing up my repository.
This is an automated message from the Apache Git Service.
To res
[
https://issues.apache.org/jira/browse/SOLR-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220324#comment-17220324
]
Erick Erickson commented on SOLR-14844:
---
I messed up my fork, so relinking the PRs
ErickErickson closed pull request #2024:
URL: https://github.com/apache/lucene-solr/pull/2024
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ErickErickson closed pull request #2011:
URL: https://github.com/apache/lucene-solr/pull/2011
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ErickErickson closed pull request #2025:
URL: https://github.com/apache/lucene-solr/pull/2025
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ErickErickson closed pull request #1796:
URL: https://github.com/apache/lucene-solr/pull/1796
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220311#comment-17220311
]
ASF subversion and git services commented on SOLR-14354:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220312#comment-17220312
]
ASF subversion and git services commented on SOLR-14354:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220313#comment-17220313
]
Cao Manh Dat commented on SOLR-14354:
-
Done on reverting, thank you [~dsmiley]
> Htt
CaoManhDat commented on pull request #2019:
URL: https://github.com/apache/lucene-solr/pull/2019#issuecomment-716163706
Thank you @dsmiley
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220307#comment-17220307
]
ASF subversion and git services commented on SOLR-14354:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220308#comment-17220308
]
ASF subversion and git services commented on SOLR-14354:
Commit 1
CaoManhDat merged pull request #2019:
URL: https://github.com/apache/lucene-solr/pull/2019
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
epugh commented on a change in pull request #2016:
URL: https://github.com/apache/lucene-solr/pull/2016#discussion_r511606718
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -278,6 +278,13 @@ configure(project(":solr:contrib:langid")) {
}
}
+configure(proje
rmuir commented on a change in pull request #2016:
URL: https://github.com/apache/lucene-solr/pull/2016#discussion_r511605458
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -278,6 +278,13 @@ configure(project(":solr:contrib:langid")) {
}
}
+configure(proje
ErickErickson commented on pull request #2026:
URL: https://github.com/apache/lucene-solr/pull/2026#issuecomment-716144601
LGTM. We can check these in piecemeal rather than do them all at once, as
you say the PRs get massive...
-
[
https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220273#comment-17220273
]
ASF subversion and git services commented on LUCENE-9455:
-
Commi
bruno-roustant closed pull request #1998:
URL: https://github.com/apache/lucene-solr/pull/1998
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
MarcusSorealheis opened a new pull request #2026:
URL: https://github.com/apache/lucene-solr/pull/2026
# Description
Janitor here, moving a closer to a standard test file naming convention,
starting with Lucene.
# Solution
Janitorial work based on the work
26 matches
Mail list logo
