[GitHub] [lucene-solr] noblepaul opened a new pull request #1598: SOLR-14409: Existing violations allow bypassing policy rules when add…

2020-06-21 Thread GitBox
noblepaul opened a new pull request #1598: URL: https://github.com/apache/lucene-solr/pull/1598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene-solr] megancarey commented on pull request #1592: SOLR-14579 First pass at dismantling Utils

2020-06-21 Thread GitBox
megancarey commented on pull request #1592: URL: https://github.com/apache/lucene-solr/pull/1592#issuecomment-647226554 cc @noblepaul - It looks like you authored the Utils class. Can you please take a look at this change when you get a chance?

[jira] [Commented] (LUCENE-9414) EagerCheapMergePolicy

2020-06-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141607#comment-17141607 ] David Smiley commented on LUCENE-9414: -- [~mikemccand]: I forked this off to its own

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1222: LUCENE-9414 EagerCheapMergePolicy

2020-06-21 Thread GitBox
dsmiley commented on a change in pull request #1222: URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443271656 ## File path: lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1222: LUCENE-9414 EagerCheapMergePolicy

2020-06-21 Thread GitBox
dsmiley commented on a change in pull request #1222: URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443271570 ## File path: lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1222: LUCENE-9414 EagerCheapMergePolicy

2020-06-21 Thread GitBox
dsmiley commented on a change in pull request #1222: URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443271454 ## File path: lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1222: LUCENE-9414 EagerCheapMergePolicy

2020-06-21 Thread GitBox
dsmiley commented on a change in pull request #1222: URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443271340 ## File path: lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java ## @@ -0,0 +1,202 @@ +/* Review comment: Why do you thi

[jira] [Created] (LUCENE-9414) EagerCheapMergePolicy

2020-06-21 Thread David Smiley (Jira)
David Smiley created LUCENE-9414: Summary: EagerCheapMergePolicy Key: LUCENE-9414 URL: https://issues.apache.org/jira/browse/LUCENE-9414 Project: Lucene - Core Issue Type: New Feature

[jira] [Resolved] (LUCENE-8965) ConcurrentMergeScheduler should maybe sometimes do synchronously

2020-06-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8965. -- Resolution: Won't Fix Obsoleted by LUCENE-8962 > ConcurrentMergeScheduler should maybe someti

[GitHub] [lucene-solr] dsmiley closed pull request #856: LUCENE-8965 SometimesConcurrentMergeScheduler

2020-06-21 Thread GitBox
dsmiley closed pull request #856: URL: https://github.com/apache/lucene-solr/pull/856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1576: Alternative approach to LUCENE-8962

2020-06-21 Thread GitBox
dsmiley commented on a change in pull request #1576: URL: https://github.com/apache/lucene-solr/pull/1576#discussion_r443266362 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -2144,39 +2145,43 @@ private synchronized boolean updatePendingMerg

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141583#comment-17141583 ] David Smiley commented on LUCENE-8962: -- I'm surprised to see that {{IndexWriterCon

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1432: SOLR-14404 CoreContainer level custom requesthandlers

2020-06-21 Thread GitBox
dsmiley commented on a change in pull request #1432: URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r443254655 ## File path: solr/core/src/java/org/apache/solr/api/AnnotatedApi.java ## @@ -48,6 +34,12 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory

[jira] [Updated] (SOLR-14268) Re-creating deleted Managed Stopwords lists results in error

2020-06-21 Thread Thomas Corthals (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Corthals updated SOLR-14268: --- Description: Creating a Managed Stopwords list that has the same name as a previously delete

[GitHub] [lucene-solr] dsmiley merged pull request #1582: Remove some needless toAbsolutePath calls

2020-06-21 Thread GitBox
dsmiley merged pull request #1582: URL: https://github.com/apache/lucene-solr/pull/1582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14581) Document the way auto commits work in SolrCloud

2020-06-21 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141573#comment-17141573 ] Erick Erickson commented on SOLR-14581: --- Oh, let's mention the word "theorem" and i

[jira] [Commented] (LUCENE-9411) Fail complation on warnings

2020-06-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141571#comment-17141571 ] Gus Heck commented on LUCENE-9411: -- Do we have other category X ([https://www.apache.o

[jira] [Commented] (LUCENE-9411) Fail complation on warnings

2020-06-21 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141570#comment-17141570 ] Erick Erickson commented on LUCENE-9411: The short form is that java generates c

[jira] [Commented] (LUCENE-9411) Fail complation on warnings

2020-06-21 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141504#comment-17141504 ] Erick Erickson commented on LUCENE-9411: Getting pretty close. The remaining iss

[GitHub] [lucene-solr] rmuir commented on pull request #1593: LUCENE-9409: Check file lengths before creating slices.

2020-06-21 Thread GitBox
rmuir commented on pull request #1593: URL: https://github.com/apache/lucene-solr/pull/1593#issuecomment-647110482 Sorry, I'm against this change. The test is broken. It looks like we are willing to make bad tradeoffs in order to deliver CorruptIndexException and only CorruptIndexException

[jira] [Commented] (LUCENE-9409) TestAllFilesDetectTruncation failures

2020-06-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141346#comment-17141346 ] ASF subversion and git services commented on LUCENE-9409: - Commi

[jira] [Commented] (LUCENE-9409) TestAllFilesDetectTruncation failures

2020-06-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141345#comment-17141345 ] ASF subversion and git services commented on LUCENE-9409: - Commi