[jira] [Commented] (SOLR-14151) Make schema components load from packages

2019-12-28 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004681#comment-17004681 ] Noble Paul commented on SOLR-14151: --- we will not support SPI from packages. > Make sc

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-28 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361828027 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-28 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361828673 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-28 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361828293 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-28 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361829906 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-28 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361828632 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-28 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361828618 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-28 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361827668 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-28 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361830391 ## File path: solr/solrj/src/java/org/apache/solr/common/params/Highl

[GitHub] [lucene-solr] dsmiley commented on issue #1124: SOLR-14151 :Schema components to be loadable from packages

2019-12-28 Thread GitBox
dsmiley commented on issue #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#issuecomment-569474142 > The problem is that SRL is directly used in all APIs I don't consider this a problem. Solr has a lot of plugin a

[jira] [Commented] (SOLR-14141) eliminate JKS keystore from solr SSL docs

2019-12-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004598#comment-17004598 ] Robert Muir commented on SOLR-14141: yeah, like i said the worst is, anyone who has e

[jira] [Commented] (SOLR-14141) eliminate JKS keystore from solr SSL docs

2019-12-28 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004595#comment-17004595 ] Kevin Risden commented on SOLR-14141: - {quote}you can specify jks and it will read pk

[jira] [Commented] (SOLR-14141) eliminate JKS keystore from solr SSL docs

2019-12-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004593#comment-17004593 ] Robert Muir commented on SOLR-14141: we accomplish that with the explicit storetype p

[GitHub] [lucene-solr] risdenk commented on a change in pull request #1121: SOLR-11207: Add OWASP dependency checker to gradle build

2019-12-28 Thread GitBox
risdenk commented on a change in pull request #1121: SOLR-11207: Add OWASP dependency checker to gradle build URL: https://github.com/apache/lucene-solr/pull/1121#discussion_r361818552 ## File path: gradle/validation/dependency-check.gradle ## @@ -0,0 +1,12 @@ +// This add

[GitHub] [lucene-solr] risdenk commented on a change in pull request #1121: SOLR-11207: Add OWASP dependency checker to gradle build

2019-12-28 Thread GitBox
risdenk commented on a change in pull request #1121: SOLR-11207: Add OWASP dependency checker to gradle build URL: https://github.com/apache/lucene-solr/pull/1121#discussion_r361818500 ## File path: gradle/validation/dependency-check.gradle ## @@ -0,0 +1,12 @@ +// This add

[jira] [Commented] (SOLR-14141) eliminate JKS keystore from solr SSL docs

2019-12-28 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004590#comment-17004590 ] Kevin Risden commented on SOLR-14141: - Looked over the changes. Looks good. The only

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

2019-12-28 Thread GitBox
noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361817112 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageAwareSolrClassLoader.java ##

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages

2019-12-28 Thread GitBox
noblepaul commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361817070 ## File path: solr/core/src/java/org/apache/solr/core/MemClassLoader.java ## @@ -53,

[jira] [Commented] (SOLR-13778) Windows JDK SSL Test Failure trend: SSLException: Software caused connection abort: recv failed

2019-12-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004586#comment-17004586 ] Robert Muir commented on SOLR-13778: With the attached RecvRepro.java I see the follo

[jira] [Commented] (SOLR-13486) race condition between leader's "replay on startup" and non-leader's "recover from leader" can leave replicas out of sync (TestCloudConsistency)

2019-12-28 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004577#comment-17004577 ] Erick Erickson commented on SOLR-13486: --- At least I can get this to reproduce fairl

[jira] [Commented] (SOLR-13808) Query DSL should let to cache filter

2019-12-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004576#comment-17004576 ] ASF subversion and git services commented on SOLR-13808: Commit 3

[jira] [Commented] (SOLR-13808) Query DSL should let to cache filter

2019-12-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004572#comment-17004572 ] ASF subversion and git services commented on SOLR-13808: Commit c

[jira] [Commented] (SOLR-13808) Query DSL should let to cache filter

2019-12-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004570#comment-17004570 ] ASF subversion and git services commented on SOLR-13808: Commit 3

[jira] [Comment Edited] (SOLR-13756) ivy cannot download org.restlet.ext.servlet jar

2019-12-28 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004548#comment-17004548 ] Joel Bernstein edited comment on SOLR-13756 at 12/28/19 6:44 PM: --

[jira] [Commented] (SOLR-13756) ivy cannot download org.restlet.ext.servlet jar

2019-12-28 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004548#comment-17004548 ] Joel Bernstein commented on SOLR-13756: --- I opened a ticket for this on the restlet

[jira] [Updated] (SOLR-12490) Query DSL supports for further referring and exclusion in JSON facets

2019-12-28 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-12490: Attachment: SOLR-12490.patch > Query DSL supports for further referring and exclusion in JS

[jira] [Assigned] (SOLR-12490) Query DSL supports for further referring and exclusion in JSON facets

2019-12-28 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev reassigned SOLR-12490: --- Assignee: Mikhail Khludnev > Query DSL supports for further referring and exclusion

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2019-12-28 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004489#comment-17004489 ] Mikhail Khludnev commented on SOLR-10912: - [~sarowe], regarding ??Since Allen Wi

[GitHub] [lucene-solr] Traktormaster commented on issue #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-28 Thread GitBox
Traktormaster commented on issue #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#issuecomment-569408594 Basically the whole patch has been reworked, here are the highlights: - About half as m

[jira] [Commented] (SOLR-13759) Optimize Queries when query filtering by TRA router.field

2019-12-28 Thread mosh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004426#comment-17004426 ] mosh commented on SOLR-13759: - Gus, you're absolutely right about the *FilterQuery* parsing p

[jira] [Commented] (SOLR-12490) Query DSL supports for further referring and exclusion in JSON facets

2019-12-28 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004423#comment-17004423 ] Lucene/Solr QA commented on SOLR-12490: --- | (x) *{color:red}-1 overall{color}* | \\