Re: [PR] [SIP] fix error running data fusion queries - Physical input schema should be the same as the one converted from logical input schema [iceberg-rust]

2024-10-12 Thread via GitHub
FANNG1 commented on PR #664: URL: https://github.com/apache/iceberg-rust/pull/664#issuecomment-2408481893 @a-agmon this's a draft PR, Does it works for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-10-12 Thread via GitHub
liurenjie1024 commented on code in PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#discussion_r1797634121 ## crates/integrations/datafusion/src/table/table_provider_factory.rs: ## @@ -0,0 +1,301 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

Re: [PR] feat: implement IcebergTableProviderFactory for datafusion [iceberg-rust]

2024-10-12 Thread via GitHub
liurenjie1024 commented on PR #600: URL: https://github.com/apache/iceberg-rust/pull/600#issuecomment-2408470892 > remind @liurenjie1024 Sorry for late reply, would you mind to fix comments and resolve conflicts? -- This is an automated message from the Apache Git Service. To respon

Re: [PR] feat: SQL Catalog - Tables [iceberg-rust]

2024-10-12 Thread via GitHub
liurenjie1024 merged PR #610: URL: https://github.com/apache/iceberg-rust/pull/610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

<    1   2