Re: [I] Create Table in SQL Catalog fails if location is not mentioned but write.data.path and write.metadata.path are [iceberg-python]

2024-06-04 Thread via GitHub
github-actions[bot] commented on issue #161: URL: https://github.com/apache/iceberg-python/issues/161#issuecomment-2148611489 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apac

Re: [I] Create Table in SQL Catalog fails if location is not mentioned but write.data.path and write.metadata.path are [iceberg-python]

2024-06-04 Thread via GitHub
github-actions[bot] closed issue #161: Create Table in SQL Catalog fails if location is not mentioned but write.data.path and write.metadata.path are URL: https://github.com/apache/iceberg-python/issues/161 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Incremental Append Scan [iceberg-python]

2024-06-04 Thread via GitHub
hililiwei commented on code in PR #533: URL: https://github.com/apache/iceberg-python/pull/533#discussion_r1626799873 ## pyiceberg/table/__init__.py: ## @@ -1754,6 +1788,134 @@ def to_arrow(self) -> pa.Table: def to_pandas(self, **kwargs: Any) -> pd.DataFrame: retu

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-04 Thread via GitHub
anuragmantri commented on code in PR #10434: URL: https://github.com/apache/iceberg/pull/10434#discussion_r1626801304 ## open-api/rest-catalog-open-api.py: ## @@ -361,23 +361,29 @@ class RemovePartitionStatisticsUpdate(BaseUpdate): class TableRequirement(BaseModel): -ty

Re: [PR] Incremental Append Scan [iceberg-python]

2024-06-04 Thread via GitHub
hililiwei commented on code in PR #533: URL: https://github.com/apache/iceberg-python/pull/533#discussion_r1626816089 ## pyiceberg/table/__init__.py: ## @@ -1754,6 +1788,134 @@ def to_arrow(self) -> pa.Table: def to_pandas(self, **kwargs: Any) -> pd.DataFrame: retu

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

2024-06-04 Thread via GitHub
nastra commented on PR #10442: URL: https://github.com/apache/iceberg/pull/10442#issuecomment-2148744879 I'll take a look later today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Incremental Append Scan [iceberg-python]

2024-06-04 Thread via GitHub
hililiwei commented on code in PR #533: URL: https://github.com/apache/iceberg-python/pull/533#discussion_r1626843860 ## pyiceberg/table/__init__.py: ## @@ -1754,6 +1788,134 @@ def to_arrow(self) -> pa.Table: def to_pandas(self, **kwargs: Any) -> pd.DataFrame: retu

Re: [PR] Spark 3.4: Incremental scan specify branch [iceberg]

2024-06-04 Thread via GitHub
hililiwei commented on PR #8384: URL: https://github.com/apache/iceberg/pull/8384#issuecomment-2148781543 @amogh-jahagirdar @nastra Would you please take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Introduces the new IcebergSink based on the new V2 Flink Sink Abstraction [iceberg]

2024-06-04 Thread via GitHub
hililiwei commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1626868928 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java: ## @@ -0,0 +1,767 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-04 Thread via GitHub
flyrain commented on code in PR #10434: URL: https://github.com/apache/iceberg/pull/10434#discussion_r1626883398 ## open-api/rest-catalog-open-api.yaml: ## @@ -2597,12 +2598,15 @@ components: assert-last-assigned-partition-id: '#/components/schemas/AssertLastAssigned

Re: [PR] Open-API: TableRequirements should use union of subclasses [iceberg]

2024-06-04 Thread via GitHub
flyrain commented on code in PR #10434: URL: https://github.com/apache/iceberg/pull/10434#discussion_r1626883398 ## open-api/rest-catalog-open-api.yaml: ## @@ -2597,12 +2598,15 @@ components: assert-last-assigned-partition-id: '#/components/schemas/AssertLastAssigned

Re: [I] Flink sink writes duplicate data in upsert mode [iceberg]

2024-06-04 Thread via GitHub
zhongqishang commented on issue #10431: URL: https://github.com/apache/iceberg/issues/10431#issuecomment-2148804889 > @zhongqishang: Do you see anything more in the logs? Exceptions/retries, or something like this? I have not found any Exceptions/retries around the wrong snapshot time

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-06-04 Thread via GitHub
ZENOTME commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1626973971 ## crates/iceberg/src/writer/mod.rs: ## @@ -92,6 +92,7 @@ pub trait CurrentFileStatus { #[cfg(test)] mod tests { + Review Comment: Remove this? ##

[PR] Core: Reword the error message [iceberg]

2024-06-04 Thread via GitHub
ajantha-bhat opened a new pull request, #10446: URL: https://github.com/apache/iceberg/pull/10446 Users are assuming it is File not found error and it is better to have a message that clarifies that it is missing in metadata but not in the disk. https://apache-iceberg.slack.com/archi

Re: [PR] Flink 1.17: Supports batch queries using time ranges [iceberg]

2024-06-04 Thread via GitHub
hililiwei commented on code in PR #7362: URL: https://github.com/apache/iceberg/pull/7362#discussion_r1627005705 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceBounded.java: ## @@ -129,6 +129,9 @@ protected List run( try (CloseableIter

Re: [PR] Flink 1.17: Supports batch queries using time ranges [iceberg]

2024-06-04 Thread via GitHub
hililiwei commented on code in PR #7362: URL: https://github.com/apache/iceberg/pull/7362#discussion_r1627007316 ## docs/flink-configuration.md: ## @@ -116,7 +116,8 @@ env.getConfig() | case-sensitive | connector.iceberg.case-sensitive | N/A

Re: [PR] Flink 1.17: Supports batch queries using time ranges [iceberg]

2024-06-04 Thread via GitHub
hililiwei commented on code in PR #7362: URL: https://github.com/apache/iceberg/pull/7362#discussion_r1627008564 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java: ## @@ -413,6 +415,141 @@ public void testIncrementalRead() throws Exception {

Re: [PR] Flink 1.17: Supports batch queries using time ranges [iceberg]

2024-06-04 Thread via GitHub
hililiwei commented on PR #7362: URL: https://github.com/apache/iceberg/pull/7362#issuecomment-2148919364 I've updated this PR, could you guys please take another look? @stevenzwu @pvary -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Bump Hive 2.3.10 [iceberg]

2024-06-04 Thread via GitHub
pan3793 opened a new pull request, #10447: URL: https://github.com/apache/iceberg/pull/10447 Hive 2.3.10 is the final release of branch-2.3, which focuses on mitigating CVE dependencies. https://github.com/apache/hive/blob/rel/release-2.3.10/RELEASE_NOTES.txt Spark upgraded Hiv

<    1   2